search for: idedevic

...@devices = @newdevices; @@ -2285,6 +2294,13 @@ sub _remap_block_devices $map{'xvd'.$1} = $mapped; } $map{$device} = $mapped; + # Also add a mapping for previously saved hd->sd conversions + if (defined($idemap{$device})) { + my $idedevice; + $idedevice = $idemap{$device}; + $map{$idedevice} = $mapped; + } + $letter++; } -- 1.8.1.4

During the conversion process, hd* block devices under Xen are mapped to sd* devices for use under guestfs. These sd devices are later remapped to vd* (or sd/hd) devices, for future use under kvm. The current code fails to track the original hd* device names. This causes subsequent remappings of the block devices (in such places as /etc/fstab, and /boot/grub/menu.lst), to skip the hd* devices,

...-2286,12 +2601,21 @@ sub _remap_block_devices > $map{'xvd'.$1} = $mapped; > } > $map{$device} = $mapped; > + # Also add a mapping for previously saved hd->sd conversions > + if (defined($idemap{$device})) { > + my $idedevice; > + $idedevice = $idemap{$device}; > + $map{$idedevice} = $mapped; > + } > + I've had a change to think about this change properly, and I'm pretty sure it's not required. The reason is that the only place %idemap is modified is in the section...

Matt, Thanks for the extensive comments. I'll go through them in detail, but it won't be until next week. For the time being, here's a quick take on some of the main issues: > I do have a major concern, though, which is this is basically a fork of > RedHat.pm. There are well over 1,000 identical lines of code between the > 2 modules. Many of the differences are relatively

...ed; > + } > + $map{$device} = $mapped; > + # Also add a mapping for previously saved hd->sd conversions > + #if (defined($idemap{$device}) && (($idemap{$device}) ne "")){ > + if (defined($idemap{$device})){ > + my $idedevice; > + $idedevice = $idemap{$device}; > + $map{$idedevice} = $mapped; > + } > + > + $letter++; > + } > + > + eval { > + # Update bare device references in fstab and grub's menu.lst and device.map > + foreach my...

This is a new conversion module to convert SUSE Linux and openSUSE guests. The converter is based on the RedHat module, and should offer the same functionality on both SUSE and RedHat hosts. There are a few additional messages in this module, such as reporting of packages when installing through zypper or the local virt-v2v repo. These messages don't necessarily flow unless verbose switches

...$map{'xvd'.$1} = $mapped; + } + $map{$device} = $mapped; + # Also add a mapping for previously saved hd->sd conversions + #if (defined($idemap{$device}) && (($idemap{$device}) ne "")){ + if (defined($idemap{$device})){ + my $idedevice; + $idedevice = $idemap{$device}; + $map{$idedevice} = $mapped; + } + + $letter++; + } + + eval { + # Update bare device references in fstab and grub's menu.lst and device.map + foreach my $spec ($g->aug_match('/files/etc/fstab/*/s...

...# uses xvdX natively. + if ($device =~ /^(?:h|s)d([a-z]+)/) { + $map{'xvd'.$1} = $mapped; + } + $map{$device} = $mapped; + # Also add a mapping for previously saved hd->sd conversions + if (defined($idemap{$device})) { + my $idedevice; + $idedevice = $idemap{$device}; + $map{$idedevice} = $mapped; + } + + $letter++; + } + + eval { + # Update bare device references in fstab and grub's menu.lst and device.map + foreach my $spec ($g->aug_match('/files/etc/fstab/*/s...