search for: iccsense

The power sensors can be configured to sample the readout values over time. Nvidia does this too, so nouveau should probably do that too. Karol Herbst (4): iccsense: remove read function iccsense: convert to linked list iccsense: split sensor into own struct iccsense: configure sensors like nvidia does drm/nouveau/include/nvkm/subdev/iccsense.h | 6 +- drm/nouveau/nouveau_hwmon.c | 2 +- drm/nouveau/nvkm/subdev/iccsense/base.c | 2...

The power sensors can be configured to sample the readout values over time. Nvidia does this too, so nouveau should probably do that too. v2: use list_del and rework an error message Karol Herbst (4): iccsense: remove read function iccsense: convert to linked list iccsense: split sensor into own struct iccsense: configure sensors like nvidia does drm/nouveau/include/nvkm/subdev/iccsense.h | 6 +- drm/nouveau/nouveau_hwmon.c | 2 +- drm/nouveau/nvkm/subdev/iccsense/base.c | 2...

Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/include/nvkm/subdev/iccsense.h | 4 +--- drm/nouveau/nouveau_hwmon.c | 2 +- drm/nouveau/nvkm/subdev/iccsense/base.c | 32 +++++++++++++----------------- drm/nouveau/nvkm/subdev/iccsense/priv.h | 1 + 4 files changed, 17 insertions(+), 22 deletions(-) diff --git a/drm/nouveau/include/nvkm/subdev/iccsen...

...al work v3: fix ina2x9 calculations v4: don't kmalloc(0), fix the lsb/pga stuff Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/include/nvkm/subdev/bios/extdev.h | 3 + drm/nouveau/include/nvkm/subdev/i2c.h | 31 ++++++ drm/nouveau/include/nvkm/subdev/iccsense.h | 5 + drm/nouveau/nvkm/engine/device/base.c | 20 ++++ drm/nouveau/nvkm/subdev/iccsense/Kbuild | 1 + drm/nouveau/nvkm/subdev/iccsense/base.c | 150 +++++++++++++++++++++++++- drm/nouveau/nvkm/subdev/iccsense/gf100.c | 31 ++++++ drm/nouveau/nvkm/subdev/iccsense...

...umption is also exported via hwmon, so "sensors" will be able to print it in userspace. This work is based on Martins initial power sensor work and most of the ground work was just copied from him. Happy testing changes in v3: fixes ina2x9, rebase on current master Karol Herbst (2): iccsense: implement for ina209, ina219 and ina3221 hwmon: add power consumption Martin Peres (2): subdev/iccsense: add new subdev for power sensors nvbios/iccsense: add parsing of the SENSE table drm/nouveau/include/nvif/device.h | 1 + drm/nouveau/include/nvkm/core/device.h...

...s" will be able to print it in userspace. I am pretty sure I got the INA2X9 bits right, but somebody should check if it's working on his card. This work is based on Martins initial power sensor work and most of the ground work was just copied from him. Happy testing Karol Herbst (2): iccsense: implement for ina209, ina219 and ina3221 hwmon: add power consumption Martin Peres (2): subdev/iccsense: add new subdev for power sensors nvbios/iccsense: add parsing of the SENSE table drm/nouveau/include/nvif/device.h | 1 + drm/nouveau/include/nvkm/core/device.h...

Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/include/nvkm/subdev/iccsense.h | 1 + drm/nouveau/nvkm/subdev/iccsense/base.c | 141 ++++++++++++++++++++--------- drm/nouveau/nvkm/subdev/iccsense/priv.h | 15 ++- 3 files changed, 112 insertions(+), 45 deletions(-) diff --git a/drm/nouveau/include/nvkm/subdev/iccsense.h b/drm/nouveau/include/nvkm/subdev/iccsense.h...

...ground work was just copied from him. Happy testing changes in v3: fixes ina2x9, rebase on current master changes in v4: some minor ina2x9 fixes and get it to work on maxwell gen2 changes in v5: final polishing Tested-by: Stefan Hühner <stefan at huehner.org> on gm206 Karol Herbst (4): iccsense: implement for ina209, ina219 and ina3221 hwmon: add power consumption hwmon: don't require therm to be valid to get any data bios/extdev: also parse v4.1 table Martin Peres (2): subdev/iccsense: add new subdev for power sensors nvbios/iccsense: add parsing of the SENSE table drm/n...

...wer sensor work and most of the ground work was just copied from him. Happy testing changes in v3: fixes ina2x9, rebase on current master changes in v4: some minor ina2x9 fixes and get it to work on maxwell gen2 Tested-by: Stefan Hühner <stefan at huehner.org> on gm206 Karol Herbst (4): iccsense: implement for ina209, ina219 and ina3221 hwmon: add power consumption hwmon: don't require therm to be valid to get any data bios/extdev: also parse v4.1 table Martin Peres (2): subdev/iccsense: add new subdev for power sensors nvbios/iccsense: add parsing of the SENSE table drm/n...

...config is already included in the vbios. This commit addresses that issue and with that we should be able to read out the right power consumption for every GPU with a INA209, INA219 and INA3221. Signed-off-by: Karol Herbst <karolherbst at gmail.com> --- drm/nouveau/include/nvkm/subdev/bios/iccsense.h | 10 +- drm/nouveau/nvkm/subdev/bios/iccsense.c | 33 +++++- drm/nouveau/nvkm/subdev/iccsense/base.c | 129 ++++++++---------------- drm/nouveau/nvkm/subdev/iccsense/priv.h | 2 +- 4 files changed, 82 insertions(+), 92 deletions(-) diff --git a/drm/nouveau/include/nv...

The INA3221 is usually found on mid and high end kepler+ gpus Marins Patch implements the new iccsense subdev and all needed bits for the INA3221 power sensor. My Patch implements the hwmon power1 interface to expose the current power consumption through hwmon (and can be read out via sysfs or the sensors tool) Please test these patches for Fermi+ GPUs, that nothing gets messed up and works as exp...

From: Martin Peres <martin.peres at free.fr> v4: don't kmalloc(0) Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/include/nvkm/subdev/bios/iccsense.h | 16 ++++ drm/nouveau/nvkm/subdev/bios/Kbuild | 1 + drm/nouveau/nvkm/subdev/bios/iccsense.c | 97 +++++++++++++++++++++++++ 3 files changed, 114 insertions(+) create mode 100644 drm/nouveau/include/nvkm/subdev/bios/iccsense.h create mode 100644 drm/nouveau/nvkm/subdev/bio...

...>): fix power_rail mapping for ina3221 minor code cleanups Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/include/nvkm/core/device.h | 83 +++++++------- drm/nouveau/include/nvkm/subdev/bios/extdev.h | 4 + drm/nouveau/include/nvkm/subdev/bios/iccsense.h | 16 +++ drm/nouveau/include/nvkm/subdev/i2c.h | 31 +++++ drm/nouveau/include/nvkm/subdev/iccsense.h | 17 +++ drm/nouveau/nvkm/core/subdev.c | 83 +++++++------- drm/nouveau/nvkm/engine/device/base.c | 143 +++++++++++++---------- drm/nouveau/nvkm/...

Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/nvkm/subdev/iccsense/base.c | 68 +++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/drm/nouveau/nvkm/subdev/iccsense/base.c b/drm/nouveau/nvkm/subdev/iccsense/base.c index b6f6222..6f3709e 100644 --- a/drm/nouveau/nvkm/subdev/iccsense/base.c +++ b/drm/nouveau/nvkm/subdev/iccsense/base.c @...

Signed-off-by: Karol Herbst <karolherbst at gmail.com> --- drm/nouveau/include/nvkm/subdev/iccsense.h | 3 +++ drm/nouveau/nvkm/subdev/iccsense/base.c | 13 ++++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drm/nouveau/include/nvkm/subdev/iccsense.h b/drm/nouveau/include/nvkm/subdev/iccsense.h index 3c2ddd9..b7a9b04 100644 --- a/drm/nouveau/include/nvkm/subdev/iccse...

...n Ian King <colin.king at canonical.com> The default sensor->type case leaks memory allocated to rail. Fix this by free'ing rail before we continue with the next loop iteration. Signed-off-by: Colin Ian King <colin.king at canonical.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c index 323c79a..79b0eb5 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccs...

From: Martin Peres <martin.peres at free.fr> Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/include/nvkm/core/device.h | 83 +++++++++---------- drm/nouveau/include/nvkm/subdev/iccsense.h | 10 +++ drm/nouveau/nvkm/core/subdev.c | 83 +++++++++---------- drm/nouveau/nvkm/engine/device/base.c | 124 +++++++++++++++-------------- drm/nouveau/nvkm/engine/device/priv.h | 1 + drm/nouveau/nvkm/subdev/Kbuild | 1 + drm/nouveau/nvkm/subdev/iccsense...

From: Martin Peres <martin.peres at free.fr> Signed-off-by: Karol Herbst <nouveau at karolherbst.de> --- drm/nouveau/include/nvkm/core/device.h | 83 +++++++++---------- drm/nouveau/include/nvkm/subdev/iccsense.h | 10 +++ drm/nouveau/nvkm/core/subdev.c | 83 +++++++++---------- drm/nouveau/nvkm/engine/device/base.c | 124 +++++++++++++++-------------- drm/nouveau/nvkm/engine/device/priv.h | 1 + drm/nouveau/nvkm/subdev/Kbuild | 1 + drm/nouveau/nvkm/subdev/iccsense...

..."continue" and in those cases the memory already allocated for rail is leaked and we again allocate new memory for it. Lets free the memory before continuing with the loop. Signed-off-by: Sudip Mukherjee <sudip.mukherjee at codethink.co.uk> --- drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c index 323c79a..756ff07 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c +++ b/drivers/g...

struct pw_rail_t is allocated as an array in function nvios_iccsense_parse, and stored to a struct member of local variable. However, the array is not freed when the local variable becomes invalid, and the reference is not passed on, leading to a memory leak. Fix this by freeing struct pw_rail_t when exiting nvkm_iccsense_oneinit. Signed-off-by: Keita Suzuki <k...