search for: iblock

...+++++++++++++++++++++++++++++++---------- 1 files changed, 198 insertions(+), 44 deletions(-) diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index b2c52b3..4527f16 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -90,7 +90,7 @@ static int ocfs2_symlink_get_block(struct inode *inode, sector_t iblock, iblock; buffer_cache_bh = sb_getblk(osb->sb, blkno); if (!buffer_cache_bh) { - mlog(ML_ERROR, "couldn't getblock for symlink!\n"); + mlog(ML_ERROR, "couldn't get block for symlink!\n"); goto bail; } @@ -191,7 +191,9 @@ static int ocfs2_get_...

...; --- fs/ocfs2/aops.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 80fa3fc..f27c1cc 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -576,6 +576,14 @@ static int ocfs2_direct_IO_get_blocks(struct inode *inode, sector_t iblock, inode_blocks = ocfs2_blocks_for_bytes(inode->i_sb, i_size_read(inode)); /* + * For a read which begins past the end of file, we return a hole. + */ + if (!create && (iblock >= inode_blocks)) { + ret = 0; + goto bail; + } + + /* * Any write past EOF is not allowed because...

Hi all! Several times now I have seen the following: fsck-ing the ext3 fs I get hundreds (if not thousands) of messages: Indoe NNNN, i_blocks is K, should be (K-8). FIXED: Interestingly the difference is *always* *always* *always* 8. Can someone explain me what was going on? Why this? Thanks a lot and all the best Norbert

...sritepages->mpage_da_map_blocks->ext4_get_blocks->ext4_ext_get_blocks-> ext4_ext_handle_uninitialized_extents->ext4_ext_convert_to_initialized->ext4_ext_insert_extent if ext4_ext_handle_uninitialized_extents is called, then line 3306 must be satisfied. that is we have in_range(iblock, ee_block, ee_len) = true. so iblock >= ee_block fs/ext4/extents.c 3306 <+++<+++if (in_range(iblock, ee_block, ee_len)) { 3307 <+++<+++<+++newblock = iblock - ee_block + ee_...

...++++++++++++++++++++++++++++++----------- 1 files changed, 189 insertions(+), 44 deletions(-) diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index b2c52b3..b730010 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -90,7 +90,7 @@ static int ocfs2_symlink_get_block(struct inode *inode, sector_t iblock, iblock; buffer_cache_bh = sb_getblk(osb->sb, blkno); if (!buffer_cache_bh) { - mlog(ML_ERROR, "couldn't getblock for symlink!\n"); + mlog(ML_ERROR, "couldn't get block for symlink!\n"); goto bail; } @@ -191,7 +191,9 @@ static int ocfs2_get_...

...+++++++++++++++++++++++++++++++---------- 1 files changed, 198 insertions(+), 44 deletions(-) diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index b2c52b3..4527f16 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -90,7 +90,7 @@ static int ocfs2_symlink_get_block(struct inode *inode, sector_t iblock, iblock; buffer_cache_bh = sb_getblk(osb->sb, blkno); if (!buffer_cache_bh) { - mlog(ML_ERROR, "couldn't getblock for symlink!\n"); + mlog(ML_ERROR, "couldn't get block for symlink!\n"); goto bail; } @@ -191,7 +191,9 @@ static int ocfs2_get_...

...o > decode nvme Read/Write/Flush operations and translate -> submit to > existing backend drivers. Let me call the "eventfd based LIO NVMe fabric driver" as "tcm_eventfd_nvme" Currently, LIO frontend driver(iscsi, fc, vhost-scsi etc) talk to LIO backend driver(fileio, iblock etc) with SCSI commands. Did you mean the "tcm_eventfd_nvme" driver need to translate NVMe commands to SCSI commands and then submit to backend driver? But I thought the future "LIO NVMe target" can support frontend driver talk to backend driver directly with NVMe commands wit...

...o > decode nvme Read/Write/Flush operations and translate -> submit to > existing backend drivers. Let me call the "eventfd based LIO NVMe fabric driver" as "tcm_eventfd_nvme" Currently, LIO frontend driver(iscsi, fc, vhost-scsi etc) talk to LIO backend driver(fileio, iblock etc) with SCSI commands. Did you mean the "tcm_eventfd_nvme" driver need to translate NVMe commands to SCSI commands and then submit to backend driver? But I thought the future "LIO NVMe target" can support frontend driver talk to backend driver directly with NVMe commands wit...

...mit to > > > existing backend drivers. > > > > Let me call the "eventfd based LIO NVMe fabric driver" as > > "tcm_eventfd_nvme" > > > > Currently, LIO frontend driver(iscsi, fc, vhost-scsi etc) talk to LIO > > backend driver(fileio, iblock etc) with SCSI commands. > > > > Did you mean the "tcm_eventfd_nvme" driver need to translate NVMe > > commands to SCSI commands and then submit to backend driver? > > > > IBLOCK + FILEIO + RD_MCP don't speak SCSI, they simply process I/Os with > LB...

...mit to > > > existing backend drivers. > > > > Let me call the "eventfd based LIO NVMe fabric driver" as > > "tcm_eventfd_nvme" > > > > Currently, LIO frontend driver(iscsi, fc, vhost-scsi etc) talk to LIO > > backend driver(fileio, iblock etc) with SCSI commands. > > > > Did you mean the "tcm_eventfd_nvme" driver need to translate NVMe > > commands to SCSI commands and then submit to backend driver? > > > > IBLOCK + FILEIO + RD_MCP don't speak SCSI, they simply process I/Os with > LB...

.../ BUG is described in s://bug.oraclecorp.com/pls/bug/webbug_print.show?c_rptno=7183894. solution: /1) moves the clearing of page cache truncate_inode_pages() from ocfs2_truncate_file() to/ /ocfs2_set_inode_size() after resizing inode size and i_blocks./ /2) in ocfs2_get_block(), add checks on iblock >= inode->i_blocks. if true, return -EIO. 3) //a kernel bug fix is needed for 2.6.9 kernel. //see https://bugzilla.redhat.com/show_bug.cgi?id=453359/ aops.c | 6 ++++++ file.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) -------------- next part -------------- A non-te...

Hi, I did some more in-depth testing of OCFS2 quota code, especially with ECC feature enabled and spotted some problems. First four patches fix them. I need the fifth patch to be able to mount OCFS2 filesystem with 2.6.31-rc3. The sixth patch fixes a potential problem when quota syncing interval is updated while the cluster is running (which is not possible currently). Joel, could you please

...o_scsi, ext2 3. Instead of vhost, also tried loopback and no problem. Using loopback, host can use the new block device, while vhost is used by guest (qemu). http://www.linux-iscsi.org/wiki/Tcm_loop Test directly in host, not find ext4 error. Have issue: 1. vhost_scsi & virtio_scsi, ext4 a. iblock b, fileio, file located in /tmp (ram), no device based. 2, Have tried 4.7-r2 and 4.5-rc1 on D02 board, both have issue. Since I need kvm specific patch for D02, so it may not freely to switch to older version. 3. Also test with ext4, disabling journal mkfs.ext4 -O ^has_journal /dev/sda Do you h...

...o_scsi, ext2 3. Instead of vhost, also tried loopback and no problem. Using loopback, host can use the new block device, while vhost is used by guest (qemu). http://www.linux-iscsi.org/wiki/Tcm_loop Test directly in host, not find ext4 error. Have issue: 1. vhost_scsi & virtio_scsi, ext4 a. iblock b, fileio, file located in /tmp (ram), no device based. 2, Have tried 4.7-r2 and 4.5-rc1 on D02 board, both have issue. Since I need kvm specific patch for D02, so it may not freely to switch to older version. 3. Also test with ext4, disabling journal mkfs.ext4 -O ^has_journal /dev/sda Do you h...

...fs diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index ef6cd30..93628b0 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c @@ -540,8 +540,7 @@ static int ocfs2_direct_IO_get_blocks(st struct buffer_head *bh_result, int create) { int ret; - u64 vbo_max; /* file offset, max_blocks from iblock */ - u64 p_blkno; + u64 p_blkno, inode_blocks; int contig_blocks; unsigned char blocksize_bits = inode->i_sb->s_blocksize_bits; unsigned long max_blocks = bh_result->b_size >> inode->i_blkbits; @@ -550,12 +549,23 @@ static int ocfs2_direct_IO_get_blocks(st * nicely aligne...

...r both virtio-scsi-raw and virtio-scsi/tcm_vhost setups was happening before VIRTIO_CONFIG_S_DRIVER_OK had been set, causing VIRTIO_SCSI_S_BAD_TARGET to occur. This fixes a bug with virtio-scsi/tcm_vhost where LUN scan was not detecting LUNs. Tested with virtio-scsi-raw + virtio-scsi/tcm_vhost w/ IBLOCK on 3.5-rc2 code. Reviewed-by: Paolo Bonzini <pbonzini at redhat.com> Cc: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com> Cc: Zhi Yong Wu <wuzhy at cn.ibm.com> Cc: Christoph Hellwig <hch at lst.de> Cc: Hannes Reinecke <hare at suse.de> Cc: <stable at vger.kernel.or...

...r both virtio-scsi-raw and virtio-scsi/tcm_vhost setups was happening before VIRTIO_CONFIG_S_DRIVER_OK had been set, causing VIRTIO_SCSI_S_BAD_TARGET to occur. This fixes a bug with virtio-scsi/tcm_vhost where LUN scan was not detecting LUNs. Tested with virtio-scsi-raw + virtio-scsi/tcm_vhost w/ IBLOCK on 3.5-rc2 code. Reviewed-by: Paolo Bonzini <pbonzini at redhat.com> Cc: Stefan Hajnoczi <stefanha at linux.vnet.ibm.com> Cc: Zhi Yong Wu <wuzhy at cn.ibm.com> Cc: Christoph Hellwig <hch at lst.de> Cc: Hannes Reinecke <hare at suse.de> Cc: <stable at vger.kernel.or...

...operations and translate -> submit to > > existing backend drivers. > > Let me call the "eventfd based LIO NVMe fabric driver" as > "tcm_eventfd_nvme" > > Currently, LIO frontend driver(iscsi, fc, vhost-scsi etc) talk to LIO > backend driver(fileio, iblock etc) with SCSI commands. > > Did you mean the "tcm_eventfd_nvme" driver need to translate NVMe > commands to SCSI commands and then submit to backend driver? > IBLOCK + FILEIO + RD_MCP don't speak SCSI, they simply process I/Os with LBA + length based on SGL memory or p...

...address a client bug with tcm_vhost I ran into.. Also, tcm_vhost driver has been merged into a single source + header file that is now living under /drivers/vhost/, along with latest tcm_vhost changes from Zhi's tcm_vhost tree. Here are a couple of screenshots of the code in action using raw IBLOCK backends provided by FusionIO ioDrive Duo: http://linux-iscsi.org/images/Virtio-scsi-tcm-vhost-3.5-rc2-3.png http://linux-iscsi.org/images/Virtio-scsi-tcm-vhost-3.5-rc2-4.png So the next steps on my end will be converting tcm_vhost to submit backend I/O from cmwq context, along with fio ben...

...address a client bug with tcm_vhost I ran into.. Also, tcm_vhost driver has been merged into a single source + header file that is now living under /drivers/vhost/, along with latest tcm_vhost changes from Zhi's tcm_vhost tree. Here are a couple of screenshots of the code in action using raw IBLOCK backends provided by FusionIO ioDrive Duo: http://linux-iscsi.org/images/Virtio-scsi-tcm-vhost-3.5-rc2-3.png http://linux-iscsi.org/images/Virtio-scsi-tcm-vhost-3.5-rc2-4.png So the next steps on my end will be converting tcm_vhost to submit backend I/O from cmwq context, along with fio ben...