search for: i_apps_map

...;t continue. For an example > diff --git a/v2v/types.ml b/v2v/types.ml > index 08e1631..7f8a9b3 100644 > --- a/v2v/types.ml > +++ b/v2v/types.ml > @@ -315,7 +315,7 @@ type inspect = { > i_mountpoints : (string * string) list; > i_apps : Guestfs.application2 list; > i_apps_map : Guestfs.application2 list StringMap.t; > - i_uefi : bool; > + i_uefi : string list option; I think what you really want is for the type to be "string list" (not option), and for empty list to mean BIOS. (Assuming that UEFI cannot have zero system partitions -- as far as I unde...

A very miscellaneous set of cleanups to how we handle the Windows registry in virt-v2v, firstboot, and inspection code. This should all be straightforward non-controversial refactoring. Some highlights: - Add a new mllib Registry module containing various utility functions that are currently scattered all around. - Only compute the software/system hive paths once during inspection, and

This patch is just for discussion. There are still a couple of issues that I'm trying to fix. One is that all of the test guests I have, even ones with static IPs, have multiple interfaces, some using DHCP, so the conditions for adding the Powershell script don't kick in. This makes testing very awkward. However a bigger issue is that I think the premise is wrong. In some registries

v1 was here with much discussion: https://www.redhat.com/archives/libguestfs/2018-December/msg00048.html v2: - Fix the case where there are multiple interfaces. Note this does not preserve order correctly (see patch for comment on why that is a hard problem). - Preserve name servers. This patch is still for discussion only. I'd like to see what might be done to get this upstream

OUnit2 has an OUnit (v1) compatibility module. Unfortunately it is rather gravely broken: https://forge.ocamlcore.org/tracker/?func=detail&aid=1392&group_id=162&atid=730 Since there is no new release fixing this, it's easier to switch to using OUnit2 for unit tests. --- .gitignore | 2 +- README | 2 +- mllib/JSON_tests.ml | 56

..."error uncompressing %s, see earlier error messages") filename; diff --git a/v2v/inspect_source.ml b/v2v/inspect_source.ml index 2b80f12..65dcb88 100644 --- a/v2v/inspect_source.ml +++ b/v2v/inspect_source.ml @@ -86,7 +86,7 @@ let rec inspect_source root_choice g = i_apps_map = apps_map; i_uefi = uefi } in - if verbose () then printf "%s%!" (string_of_inspect inspect); + debug "%s" (string_of_inspect inspect); sanity_check_inspection inspect; @@ -162,7 +162,7 @@ and has_uefi_bootable_device g = with G.Error msg as exn ->...

Add a Common_utils.debug function for printing messages only when in verbose mode. Rich.

This patch series adds stable bus and slot numbers for removable drives (CDs and floppies) when the guest is converted using virt-v2v or virt-p2v. Previously we were a bit random about this. After this patch series, the bus and slot numbers and preserved if at all possible. BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1238053 Rich.

...-453,7 +453,7 @@ let rec main () = if debug_gc then Gc.compact () -and inspect_source ~verbose g root_choice = +and inspect_source g root_choice = let roots = g#inspect_os () in let roots = Array.to_list roots in @@ -581,7 +581,7 @@ and inspect_source ~verbose g root_choice = i_apps_map = apps_map; i_uefi = uefi } in - if verbose then printf "%s%!" (string_of_inspect inspect); + if verbose () then printf "%s%!" (string_of_inspect inspect); inspect (* Conversion can fail if there is no space on the guest filesystems @@ -622,7 +622,7 @@ and check_...

.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.

https://bugzilla.redhat.com/show_bug.cgi?id=1167623