search for: i_app

....compile "^initr(?:d|amfs)-.*(?:\\.img)?$" in + let kernel_pkgs = List.filter ( + fun { G.app2_name = name } -> + name = "kernel" + || String.is_prefix name "kernel-" + || String.is_prefix name "linux-image-" + ) inspect.i_apps in + if verbose () then ( + let names = List.map (fun { G.app2_name = name } -> name) kernel_pkgs in + eprintf "candidate kernel packages in this guest: %s%!\n" + (String.concat " " names) + ); List.filter_map ( - function - | { G.app2_n...

...* failure in inspection, and we shouldn't continue. For an example > diff --git a/v2v/types.ml b/v2v/types.ml > index 08e1631..7f8a9b3 100644 > --- a/v2v/types.ml > +++ b/v2v/types.ml > @@ -315,7 +315,7 @@ type inspect = { > i_mountpoints : (string * string) list; > i_apps : Guestfs.application2 list; > i_apps_map : Guestfs.application2 list StringMap.t; > - i_uefi : bool; > + i_uefi : string list option; I think what you really want is for the type to be "string list" (not option), and for empty list to mean BIOS. (Assuming that UEFI canno...

In case qemu-guest-agent is already installed in the guest, do not try to install it again from the RHV Tools ISO. Pino Toscano (2): v2v: linux: install linux tools after unconfigurations v2v: linux: do not install qemu-guest-agent if already installed v2v/convert_linux.ml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) -- 2.21.0

...ence, special case this situation, and + * leave open-vm-tools installed in this case. + *) + let has_ubuntu_server = + if family = `Debian_family then + List.exists ( + fun { G.app2_name = name } -> + name = "ubuntu-server" + ) inspect.i_apps + else false in List.iter ( fun { G.app2_name = name } -> if String.is_prefix name "vmware-tools-libraries-" then @@ -301,7 +313,7 @@ let convert (g : G.guestfs) inspect source output rcaps = List.push_front name remove else if String.is_p...

....fc20.x86_64 + * tar-1.26-30.fc20.x86_64 *) + let rpm_major, rpm_minor = + let ver = List.find_map ( + function + | { G.app2_name = name; G.app2_version = version } + when name = "rpm" -> Some version + | _ -> None + ) inspect.i_apps in + match String.nsplit "." ver with + | [major] -> int_of_string major, 0 + | major :: minor :: _ -> int_of_string major, int_of_string minor + | _ -> error (f_"unrecognized RPM version: %s") ver in + let is_rpm_lt_4_11 = + rpm_major <...

...*) + let is_rpm_lt_4_11 () = + let ver = + try + let ver = List.find_map ( + function + | { G.app2_name = name; G.app2_version = version } + when name = "rpm" -> Some version + | _ -> None + ) inspect.i_apps in + if PCRE.matches re_version ver then + (int_of_string (PCRE.sub 1), int_of_string (PCRE.sub 2)) + else + (0, 0) + with Not_found -> + (* 'rpm' not installed? Hmm... *) + (0, 0) in + ver < (4, 11) + in l...

...false in - if is_rhel_lt_5 then - pkg_name + let is_rpm_lt_4_11 () = + let ver = List.find_map ( + function + | { G.app2_name = name; G.app2_version = version } + when name = "rpm" -> Some version + | _ -> None + ) inspect.i_apps in + let ver = + if PCRE.matches re_version ver then + (int_of_string (PCRE.sub 1), int_of_string (PCRE.sub 2)) else - sprintf "%ld:%s" app.G.app2_epoch pkg_name - ) else - pkg_name in + (0, 0) in + ver < (4, 11) + in...

..."mcafee" +let rex_norton = PCRE.compile ~caseless:true "norton" +let rex_sophos = PCRE.compile ~caseless:true "sophos" +let rex_avg_tech = PCRE.compile ~caseless:true "avg technologies" (* RHBZ#1261436 *) let rec detect_antivirus { Types.i_type = t; i_apps = apps } = assert (t = "windows"); @@ -44,5 +44,4 @@ and check_app { Guestfs.app2_name = name; name =~ rex_sophos || publisher =~ rex_avg_tech -and (=~) str rex = - try ignore (Str.search_forward rex str 0); true with Not_found -> false +and (=~) str rex = PCRE.mat...

...ert (g : G.guestfs) inspect source output rcaps = ) and install_linux_tools () = - Windows_virtio.install_linux_tools g inspect + let has_qemu_guest_agent = + List.exists ( + fun { G.app2_name = name } -> + name = "qemu-guest-agent" + ) inspect.i_apps in + if not has_qemu_guest_agent then + Windows_virtio.install_linux_tools g inspect and configure_kernel () = (* Previously this function would try to install kernels, but we -- 2.21.0

...e = name } -> name = "kernel" - || String.is_prefix name "kernel-" + || (String.is_prefix name "kernel-" && not (String.is_suffix name "-devel")) || String.is_prefix name "linux-image-" ) inspect.i_apps in if verbose () then ( -- 2.26.2

...x86_64 > *) > + let rpm_major, rpm_minor = > + let ver = List.find_map ( > + function > + | { G.app2_name = name; G.app2_version = version } > + when name = "rpm" -> Some version > + | _ -> None > + ) inspect.i_apps in This has the nasty side effect of Not_found exception escaping if for some reason we can't find the rpm version. I think you should catch that case and assume old RPM. > + match String.nsplit "." ver with > + | [major] -> int_of_string major, 0 > + |...

This patch is just for discussion. There are still a couple of issues that I'm trying to fix. One is that all of the test guests I have, even ones with static IPs, have multiple interfaces, some using DHCP, so the conditions for adding the Powershell script don't kick in. This makes testing very awkward. However a bigger issue is that I think the premise is wrong. In some registries

...ff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml index b85406e..500e060 100644 --- a/v2v/convert_linux.ml +++ b/v2v/convert_linux.ml @@ -33,31 +33,10 @@ open Common_utils open Utils open Types +open Linux_kernels module G = Guestfs -(* Kernel information. *) -type kernel_info = { - ki_app : G.application2; (* The RPM package data. *) - ki_name : string; (* eg. "kernel-PAE" *) - ki_version : string; (* version-release *) - ki_arch : string; (* Kernel architecture. *) - ki_vmlinuz : string; (* The path of the...

Hi, this patch series attempt to uninstall VMware tools on all the Linux guests, and reduce the uninstallation time needed in some cases: - v2v tries to workaround the slowest part of the tarball-installed VMware tools - v2v uninstalls the open source VMware tools (open-vm-tools) Thanks, Pino Toscano (2): v2v: linux: remove open-vm-tools packages v2v: linux: try to trick

This is a sort of follow-up to the Linux_bootloaders patch. It turns out all the kernel detection code is nicely self- contained and can therefore be moved to its own module. Rich.

v1 was here with much discussion: https://www.redhat.com/archives/libguestfs/2018-December/msg00048.html v2: - Fix the case where there are multiple interfaces. Note this does not preserve order correctly (see patch for comment on why that is a hard problem). - Preserve name servers. This patch is still for discussion only. I'd like to see what might be done to get this upstream

A very miscellaneous set of cleanups to how we handle the Windows registry in virt-v2v, firstboot, and inspection code. This should all be straightforward non-controversial refactoring. Some highlights: - Add a new mllib Registry module containing various utility functions that are currently scattered all around. - Only compute the software/system hive paths once during inspection, and

OUnit2 has an OUnit (v1) compatibility module. Unfortunately it is rather gravely broken: https://forge.ocamlcore.org/tracker/?func=detail&aid=1392&group_id=162&atid=730 Since there is no new release fixing this, it's easier to switch to using OUnit2 for unit tests. --- .gitignore | 2 +- README | 2 +- mllib/JSON_tests.ml | 56

...string_suffix app.G.app2_name "-debug" || - string_suffix app.G.app2_name "-dbg" in + String.is_suffix app.G.app2_name "-debug" || + String.is_suffix app.G.app2_name "-dbg" in Some { ki_app = app; @@ -298,7 +298,7 @@ let rec convert ~keep_serial_console (g : G.guestfs) inspect source = sprintf "/files%s/title[%d]/kernel" grub_config (idx+1) in Some expr with G.Error msg - when string_find msg "aug_get: no mat...

...display-name", JSON.String display_name; + "epoch", JSON.Int (Int64.of_int32 epoch); + "version", JSON.String version; + "release", JSON.String release; + "arch", JSON.String arch; + ] + ) inspect.i_apps in + + let firmware_dict = + match inspect.i_firmware with + | I_BIOS -> + [ + "type", JSON.String "bios"; + ] + | I_UEFI devices -> + [ + "type", JSON.String "uefi"; + "devices&quo...