search for: hwmon_device_register_with_info

This patch creates special group attributes for special attrs like "*auto_point*". We check if we need them, and if we do, we set them up in special_groups structure, that then we pass to hwmon_device_register_with_info. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-13 10:13:26.331391326 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-13 10:15:02.274073273 +0200 @@ -417,6 +417,23 @@ nouveau_hwmon_get_power1_crit(struct nou return iccsense->power_w_crit; } +static struct at...

..._* and implement the code inside > nouveau_temp_write > v6 -> v7: > * Got rid of all dummy functions that only had a return, and moved > code into the switch statements. > > > This patchseries replaces the deprecated hwmon_device_register function with the > new one hwmon_device_register_with_info. > It also does some cleanup. > > Oscar Salvador (5): > nouveau/hwmon: Add config for all sensors and their settings > nouveau/hwmon: Add nouveau_hwmon_ops structure with > .is_visible/.read_string > nouveau/hwmon: Remove old code, add .write/.read operations &gt...

Hi again, I've split the patches as Karol Herbst suggested. I hope now it's fine. This series of patches introduce the new hwmon_device_register_with_info and gets rid of the old hwmon_device_register. This patch adds the default sensors with their possible config values. Just to prepare for the next patches --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12 19:18:09.638073562 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c...

This patch replaces symbolic permissions with the numeric ones and adds me to the authors too. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-13 10:18:37.471129756 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-13 10:19:58.182025638 +0200 @@ -1,5 +1,6 @@ /* - * Copyright 2010 Red Hat Inc. + * Copyright 2010 Red Hat Inc. (Ben Skeggs) + * Copyright 2017 Oscar

This patch introduces the structure "struct hwmon_ops" and sets up the ".visible" operation. Is also a preparation for the next patch. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12 19:18:09.638073562 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-12 19:19:44.244797202 +0200 @@ -692,6 +692,78 @@ static const struct attribute_group hwmo

2017-04-13 11:08 GMT+02:00 Oscar Salvador <osalvador.vilardaga at gmail.com>: > This patch introduces the structure "struct hwmon_ops" and sets up the ".visible" operation. > Is also a preparation for the next patch where all work is being done. > > --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12 19:22:29.070573187 +0200 > +++

...c3104d20571 100644 --- a/drivers/gpu/drm/nouveau/nouveau_hwmon.c +++ b/drivers/gpu/drm/nouveau/nouveau_hwmon.c @@ -741,7 +741,7 @@ nouveau_hwmon_init(struct drm_device *dev) special_groups[i++] = &pwm_fan_sensor_group; } - special_groups[i] = 0; + special_groups[i] = NULL; hwmon_dev = hwmon_device_register_with_info(dev->dev, "nouveau", dev, &nouveau_chip_info, special_groups); -- 2.17.1

This patch introduces the structure "struct hwmon_ops" and sets up the ".visible" operation. Is also a preparation for the next patch where all work is being done. --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12 19:22:29.070573187 +0200 +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-12 19:21:32.391338011 +0200 @@ -764,6 +764,166 @@ static const

...mplement the code inside nouveau_temp_write v6 -> v7: * Got rid of all dummy functions that only had a return, and moved code into the switch statements. v7 -> v8: * Fix warnings This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Oscar Salvador (5): nouveau/hwmon: Add config for all sensors and their settings nouveau/hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau/hwmon: Remove old code, add .write/.read operations nouveau/hwmon: expose the auto_point and...

...ite * Get rid of nouveau_hwmon_set_temp_* and implement the code inside nouveau_temp_write v6 -> v7: * Got rid of all dummy functions that only had a return, and moved code into the switch statements. This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Oscar Salvador (5): nouveau/hwmon: Add config for all sensors and their settings nouveau/hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau/hwmon: Remove old code, add .write/.read operations nouveau/hwmon: expose the auto_point and...

Hi! This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Here is the list of patches and what they do: 1/ Adds config structures for all sensors and their possible settings. This patch and the next one are just preparing the code for what it comes. 2/ Now everything goes through nouveua_hwmon_ops. There we set up wich fu...

...ix-ups: Versions: v1 -> v2: * Keep temp attrs as read only v2 -> v3: * Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Here is the list of patches and what they do: 1/ Adds config structures for all sensors and their possible settings. This patch and the next one are just preparing the code for what it comes. 2/ Now everything goes through nouveua_hwmon_ops. There we set up wich fu...

...rature attrs as RW again * Get rid of nouveau_hwmon_set_pwm1/_enable and implement the code inside nouveau_pwm_write * Get rid of nouveau_hwmon_set_temp_* and implement the code inside nouveau_temp_write This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Oscar Salvador (5): nouveau/hwmon: Add config for all sensors and their settings nouveau/hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau/hwmon: Remove old code, add .write/.read operations nouveau/hwmon: expose the auto_point and...

This patch creates a special group attributes for attrs like "*auto_point*". We check if we have support for them, and if we do, we gather them all in an attribute_group's structure which is the parameter regarding special groups of hwmon_device_register_with_info. --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c index 538bf67..655ae11 100644 --- a/drivers/gpu/drm/nouveau/nouveau_hwmon...

This patch creates a special group attributes for attrs like "*auto_point*". We check if we have support for them, and if we do, we gather them all in an attribute_group's structure which is the parameter regarding special groups of hwmon_device_register_with_info. Signed-off-by: Oscar Salvador <osalvador.vilardaga at gmail.com> --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c...

This patch creates a special group attributes for attrs like "*auto_point*". We check if we have support for them, and if we do, we gather them all in an attribute_group's structure which is the parameter regarding special groups of hwmon_device_register_with_info. Signed-off-by: Oscar Salvador <osalvador.vilardaga at gmail.com> --- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c i...

...* Code fix-ups: struct and string as const and add return within switch due to fallthrough * Add Signed-off-by to all commits v3 -> v4: * Rever const to struct attribute. Kbuild complains. This patchseries replaces the deprecated hwmon_device_register function with the new one hwmon_device_register_with_info. It also does some cleanup. Oscar Salvador (5): nouveau_hwmon: Add config for all sensors and their settings nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string nouveau_hwmon: Remove old code, add .write/.read operations nouveau_hwmon: Add support for auto_poin...

...*iccsense = nvxx_iccsense(&drm->client.device); struct nouveau_hwmon *hwmon; struct device *hwmon_dev; int ret = 0; @@ -943,78 +877,16 @@ nouveau_hwmon_init(struct drm_device *de return -ENOMEM; hwmon->dev = dev; - hwmon_dev = hwmon_device_register(dev->dev); + hwmon_dev = hwmon_device_register_with_info(dev->dev, "nouveau", dev, + &nouveau_chip_info, NULL); if (IS_ERR(hwmon_dev)) { ret = PTR_ERR(hwmon_dev); NV_ERROR(drm, "Unable to register hwmon device: %d\n", ret); return ret; } - dev_set_drvdata(hwmon_dev, dev); - - /* set the default attributes */ -...

...re are clean ups here, please do it in a seperate patch. I highly doubt that it all has to be done within one single big patch. 2017-04-11 18:54 GMT+02:00 Oscar Salvador <osalvador.vilardaga at gmail.com>: > Hi, > > this patch replaces the old hwmon_device_register with the new > hwmon_device_register_with_info. > I've tested it on my laptop with a GeForceGT 425M and it doesn't break anything. > > > --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-11 18:27:15.477623009 +0200 > +++ linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c 2017-04-11 18:45:41.918688215 +0200...

...2.868669] nouveau 0000:01:00.0: DRM: DCB conn 05: 00000210 [ 2.868670] nouveau 0000:01:00.0: DRM: DCB conn 06: 00000211 [ 2.868671] nouveau 0000:01:00.0: DRM: DCB conn 07: 00000213 [ 2.876862] nouveau 0000:01:00.0: hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info(). [ 2.899146] nouveau 0000:01:00.0: DRM: MM: using COPY for buffer copies [ 2.947414] nouveau 0000:01:00.0: DRM: allocated 1366x768 fb: 0x70000, bo ffff98488129b800 [ 2.948762] fbcon: nouveaufb (fb0) is primary device [ 2.948872] nouveau 0000:01:00.0: fb0: nouveaufb frame buffer device...