search for: hw_queue

On Thu, Feb 13, 2020 at 8:38 PM Halil Pasic <pasic at linux.ibm.com> wrote: > > Since nobody else is going to restart our hw_queue for us, the > blk_mq_start_stopped_hw_queues() is in virtblk_done() is not sufficient > necessarily sufficient to ensure that the queue will get started again. > In case of global resource outage (-ENOMEM because mapping failure, > because of swiotlb full) our virtqueue may be empty and...

On Thu, Feb 13, 2020 at 8:38 PM Halil Pasic <pasic at linux.ibm.com> wrote: > > Since nobody else is going to restart our hw_queue for us, the > blk_mq_start_stopped_hw_queues() is in virtblk_done() is not sufficient > necessarily sufficient to ensure that the queue will get started again. > In case of global resource outage (-ENOMEM because mapping failure, > because of swiotlb full) our virtqueue may be empty and...

...sic at linux.ibm.com> wrote: > > On Tue, 18 Feb 2020 10:21:18 +0800 > Ming Lei <tom.leiming at gmail.com> wrote: > > > On Thu, Feb 13, 2020 at 8:38 PM Halil Pasic <pasic at linux.ibm.com> wrote: > > > > > > Since nobody else is going to restart our hw_queue for us, the > > > blk_mq_start_stopped_hw_queues() is in virtblk_done() is not sufficient > > > necessarily sufficient to ensure that the queue will get started again. > > > In case of global resource outage (-ENOMEM because mapping failure, > > > because of swio...

Since nobody else is going to restart our hw_queue for us, the blk_mq_start_stopped_hw_queues() is in virtblk_done() is not sufficient necessarily sufficient to ensure that the queue will get started again. In case of global resource outage (-ENOMEM because mapping failure, because of swiotlb full) our virtqueue may be empty and we can get stuck wi...

On Tue, 18 Feb 2020 10:21:18 +0800 Ming Lei <tom.leiming at gmail.com> wrote: > On Thu, Feb 13, 2020 at 8:38 PM Halil Pasic <pasic at linux.ibm.com> wrote: > > > > Since nobody else is going to restart our hw_queue for us, the > > blk_mq_start_stopped_hw_queues() is in virtblk_done() is not sufficient > > necessarily sufficient to ensure that the queue will get started again. > > In case of global resource outage (-ENOMEM because mapping failure, > > because of swiotlb full) our virtqu...

...54.769302] ? process_one_work+0x360/0x360 [ 54.769303] ? kthread_bind+0x10/0x10 [ 54.769305] ret_from_fork+0x35/0x40 [ 54.769307] ---[ end trace 923a87a9ce0e777a ]--- Thank you very much! Dongli Zhang On 2/13/20 4:37 AM, Halil Pasic wrote: > Since nobody else is going to restart our hw_queue for us, the > blk_mq_start_stopped_hw_queues() is in virtblk_done() is not sufficient > necessarily sufficient to ensure that the queue will get started again. > In case of global resource outage (-ENOMEM because mapping failure, > because of swiotlb full) our virtqueue may be empty and...

...I stumbled upon this while stress testing I/O for Protected Virtual Machines. I deliberately chose a tiny swiotlb size and have generated load with fio. With more than one virtio-blk disk in use I experienced hangs. The goal of this series is to fix those hangs. Halil Pasic (2): virtio-blk: fix hw_queue stopped on arbitrary error virtio-blk: improve virtqueue error to BLK_STS drivers/block/virtio_blk.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) base-commit: 39bed42de2e7d74686a2d5a45638d6a5d7e7d473 -- 2.17.1

...I stumbled upon this while stress testing I/O for Protected Virtual Machines. I deliberately chose a tiny swiotlb size and have generated load with fio. With more than one virtio-blk disk in use I experienced hangs. The goal of this series is to fix those hangs. Halil Pasic (2): virtio-blk: fix hw_queue stopped on arbitrary error virtio-blk: improve virtqueue error to BLK_STS drivers/block/virtio_blk.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) base-commit: 39bed42de2e7d74686a2d5a45638d6a5d7e7d473 -- 2.17.1

...chines. I deliberately chose a tiny swiotlb size and have generated > > load with fio. With more than one virtio-blk disk in use I experienced > > hangs. > > > > The goal of this series is to fix those hangs. > > > > Halil Pasic (2): > > virtio-blk: fix hw_queue stopped on arbitrary error > > virtio-blk: improve virtqueue error to BLK_STS > > > > drivers/block/virtio_blk.c | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > > > base-commit: 39bed42de2e7d74686a2d5a45638d6a5d7e7...

...g I/O for Protected Virtual > Machines. I deliberately chose a tiny swiotlb size and have generated > load with fio. With more than one virtio-blk disk in use I experienced > hangs. > > The goal of this series is to fix those hangs. > > Halil Pasic (2): > virtio-blk: fix hw_queue stopped on arbitrary error > virtio-blk: improve virtqueue error to BLK_STS > > drivers/block/virtio_blk.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > > base-commit: 39bed42de2e7d74686a2d5a45638d6a5d7e7d473 ping Hi Michael, hi Jason,...

...8 05:35:24 -0400) ---------------------------------------------------------------- virtio: fixes Some bug fixes all over the place. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Halil Pasic (2): virtio-blk: fix hw_queue stopped on arbitrary error virtio-blk: improve virtqueue error to BLK_STS Nathan Chancellor (1): virtio_balloon: Adjust label in virtballoon_probe Suman Anna (1): virtio_ring: Fix mem leak with vring_new_virtqueue() drivers/block/virtio_blk.c | 17 ++++++++++++----- drive...