search for: hvc_kick

This patch set if my first attempt to make virtio_console usable on s390. To do so, I had to change hvc_console, because s390 has no request_irq and no free_irq. I want to get feedback from the main users of hvc_console before I proceed. The basic idea of this patch set is to remove the calls to request_irq and free_irq and replace them with backend specific callbacks. Please see the

This patch set if my first attempt to make virtio_console usable on s390. To do so, I had to change hvc_console, because s390 has no request_irq and no free_irq. I want to get feedback from the main users of hvc_console before I proceed. The basic idea of this patch set is to remove the calls to request_irq and free_irq and replace them with backend specific callbacks. Please see the

Hello, When multiple hvc console ports are initialised and used via the virtio_console driver, I can interact with only the first console, the 2nd one doesn't respond. If I call hvc_kick() even if hvc_poll() returns 0, the 2nd console becomes responsive. I've checked that hvc_poll() receives data via get_chars() and feeds it to tty_insert_flip_char(). Any idea what could be going wrong? This is reproducible on Linus' git kernel as the guest kernel with the qemu.git repo....

Hello, When multiple hvc console ports are initialised and used via the virtio_console driver, I can interact with only the first console, the 2nd one doesn't respond. If I call hvc_kick() even if hvc_poll() returns 0, the 2nd console becomes responsive. I've checked that hvc_poll() receives data via get_chars() and feeds it to tty_insert_flip_char(). Any idea what could be going wrong? This is reproducible on Linus' git kernel as the guest kernel with the qemu.git repo....

...rt(port); + spin_unlock_irqrestore(&port->inbuf_lock, flags); wake_up_interruptible(&port->waitqueue); - /* Send a SIGIO indicating new data in case the process asked for it */ - send_sigio_to_port(port); - if (is_console_port(port) && hvc_poll(port->cons.hvc)) hvc_kick(); } -- 1.8.1.4

...should be balanced in their kref reference counting. Right now we get a kref every call to hvc_open: if (hp->count++ > 0) { tty_kref_get(tty); <----- here spin_unlock_irqrestore(&hp->lock, flags); hvc_kick(); return 0; } /* else count == 0 */ tty->driver_data = hp; hp->tty = tty_kref_get(tty); <------ or here if hp->count was 0 But hvc_close has: tty_kref_get(tty); if (--hp->cou...

...should be balanced in their kref reference counting. Right now we get a kref every call to hvc_open: if (hp->count++ > 0) { tty_kref_get(tty); <----- here spin_unlock_irqrestore(&hp->lock, flags); hvc_kick(); return 0; } /* else count == 0 */ tty->driver_data = hp; hp->tty = tty_kref_get(tty); <------ or here if hp->count was 0 But hvc_close has: tty_kref_get(tty); if (--hp->cou...

Hey Rusty, In this version: - Assume only one inbuf; no input buffering for ports - Remove the START/END delimiters for outgoing buffers - Remove the header that was sent along with each buffer - Remove unused buffers in the vqs at port remove time - Send a guest port open message to the host when a console port is attached - Remove cached buffers when ports are closed / disconnected - Send

Hey Rusty, In this version: - Assume only one inbuf; no input buffering for ports - Remove the START/END delimiters for outgoing buffers - Remove the header that was sent along with each buffer - Remove unused buffers in the vqs at port remove time - Send a guest port open message to the host when a console port is attached - Remove cached buffers when ports are closed / disconnected - Send

Hey Rusty, This patchset is on top of the previous one. It sends a SIGIO signal to apps that request signals for host activity. SIGIO is sent on host connect, disconnect as well as hot-unplug (which can be seen as a special case of host disconnect). Tested using several testcases in the test-virtserial repo: http://fedorapeople.org/gitweb?p=amitshah/public_git/test-virtserial.git Please apply.

Hey Rusty, This patchset is on top of the previous one. It sends a SIGIO signal to apps that request signals for host activity. SIGIO is sent on host connect, disconnect as well as hot-unplug (which can be seen as a special case of host disconnect). Tested using several testcases in the test-virtserial repo: http://fedorapeople.org/gitweb?p=amitshah/public_git/test-virtserial.git Please apply.

Hey Rusty, This is a respin of my patches on top of the series you posted. I've taken the liberty to modify your patches for style consistency and comments where needed, keeping the authorship info intact. I've had to update a few of your patches for functional changes, I've changed the authorship info on those patches. The (only) major functional change is to have a list for ports

Hey Rusty, This is a respin of my patches on top of the series you posted. I've taken the liberty to modify your patches for style consistency and comments where needed, keeping the authorship info intact. I've had to update a few of your patches for functional changes, I've changed the authorship info on those patches. The (only) major functional change is to have a list for ports

Hi Rusty, The main thing in these patches is the introduction of injecting SIGIO on host-side connect/disconnect events and when new data is available for ports. The first two patches fix bugs that I haven't seen, but look like the right thing to do. These have been tested extensively using the test-virtserial test suite. Please apply, Amit. Amit Shah (4): virtio: console: Un-block

Hi Rusty, The main thing in these patches is the introduction of injecting SIGIO on host-side connect/disconnect events and when new data is available for ports. The first two patches fix bugs that I haven't seen, but look like the right thing to do. These have been tested extensively using the test-virtserial test suite. Please apply, Amit. Amit Shah (4): virtio: console: Un-block

...d very early so boot messages can go out, +/* Console drivers are initialized very early so boot messages can go out, * so we do things slightly differently from the generic virtio initialization * of the net and block drivers. * @@ -179,7 +163,7 @@ static void hvc_handle_input(struct virt hvc_kick(); } -/*D:370 Once we're further in boot, we get probed like any other virtio device. +/* Once we're further in boot, we get probed like any other virtio device. * At this stage we set up the output virtqueue. * * To set up and manage our virtual console, we call hvc_alloc(). Sinc...

...d very early so boot messages can go out, +/* Console drivers are initialized very early so boot messages can go out, * so we do things slightly differently from the generic virtio initialization * of the net and block drivers. * @@ -179,7 +163,7 @@ static void hvc_handle_input(struct virt hvc_kick(); } -/*D:370 Once we're further in boot, we get probed like any other virtio device. +/* Once we're further in boot, we get probed like any other virtio device. * At this stage we set up the output virtqueue. * * To set up and manage our virtual console, we call hvc_alloc(). Sinc...

Hey Rusty, These updated patches in the series return -EFAULT on copy_xx_user errors and also move the copy_from_user into fops_write() instead of it being in send_buf. This enables send_buf to just read from kernel buffers, making it simpler. This also allows write()s to write more to the host in one go, removingthe 4k limitation. I do limit the writes to 32k at once to not put too much

Hey Rusty, These updated patches in the series return -EFAULT on copy_xx_user errors and also move the copy_from_user into fops_write() instead of it being in send_buf. This enables send_buf to just read from kernel buffers, making it simpler. This also allows write()s to write more to the host in one go, removingthe 4k limitation. I do limit the writes to 32k at once to not put too much

Hello, This series fixes a few bugs and races with port unplug and the various file operations: read(), write() and close(). I started coding up an alternative locking mechanism based on the discussion earlier in this series, but some of what we already have has to remain, and the new code is sufficiently different, so I'd rather it bakes for a while, and I ensure there are no regressions