search for: hurleysoftwar

...ium Bug ID: 67277 Assignee: nouveau at lists.freedesktop.org Summary: Lockdep splat on kernel 3.10.0 QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: Linux (All) Reporter: peter at hurleysoftware.com Hardware: x86-64 (AMD64) Status: NEW Version: unspecified Component: Driver/nouveau Product: xorg Created attachment 82961 --> https://bugs.freedesktop.org/attachment.cgi?id=82961&action=edit lockdep splat in kernel log On vanilla...

...Bug ID: 58087 Assignee: nouveau at lists.freedesktop.org Summary: [-next] nouveau corrupts kernel mm allocator QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: Linux (All) Reporter: peter at hurleysoftware.com Hardware: x86-64 (AMD64) Status: NEW Version: unspecified Component: Driver/nouveau Product: xorg Created attachment 71269 --> https://bugs.freedesktop.org/attachment.cgi?id=71269&action=edit kernel log showing BUG triggered by nou...

...xorg Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Driver/nouveau Assignee: nouveau at lists.freedesktop.org Reporter: peter at hurleysoftware.com QA Contact: xorg-team at lists.x.org nouveau_fbcon_sync() can be called with interrupts disabled, such as from printk(). Facilities used to implement busy wait must not require sleeping. [ 37.438494] BUG: sleeping function called from invalid context at /home/peter/src/kernels/mai...

This series was originally motivated by a deadlock, introduced in commit 1d7c71a3e2f77336df536855b0efd2dc5bdeb41b 'drm/nouveau/disp: port vblank handling to event interface', due to inverted lock order between nouveau_drm_vblank_enable() and nouveau_drm_vblank_handler() (the complete lockdep report is included in the patch 4/5 changelog). Because this series fixes the vblank event

Provide private field for event handlers exclusive use. Convert nouveau_fence_wait_uevent() and nouveau_fence_wait_uevent_handler(); drop struct nouveau_fence_uevent. Signed-off-by: Peter Hurley <peter at hurleysoftware.com> --- drivers/gpu/drm/nouveau/core/include/core/event.h | 1 + drivers/gpu/drm/nouveau/nouveau_fence.c | 20 +++++++------------- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/include/core/event.h b/drivers/gpu/drm/nouveau/core/inclu...

nouveau_event_put_locked() only has 1 call site; fold into caller. Signed-off-by: Peter Hurley <peter at hurleysoftware.com> --- drivers/gpu/drm/nouveau/core/core/event.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/core/event.c b/drivers/gpu/drm/nouveau/core/core/event.c index ce0a0ef..45bcb37 100644 --- a/drivers/gpu/drm/nouveau/core/cor...

...ased event handler list; since RCU list traversal may have stale pointers, local storage may go out of scope before handler completes. Introduce nouveau_event_handler_create/_destroy which provides suitable semantics for multiple, temporary event handlers. Signed-off-by: Peter Hurley <peter at hurleysoftware.com> --- drivers/gpu/drm/nouveau/core/core/event.c | 24 +++++++++++++++++++++++ drivers/gpu/drm/nouveau/core/include/core/event.h | 6 ++++++ drivers/gpu/drm/nouveau/nouveau_fence.c | 15 +++++++------- 3 files changed, 38 insertions(+), 7 deletions(-) diff --git a/drivers...

...e dangerously reused via nouveau_event_get/_put. For example, if nouveau_event_get is called more than once for a given handler, the event handler list will be corrupted. Migrate nouveau_event_get/_put from add/remove semantics to enable/disable semantics. Signed-off-by: Peter Hurley <peter at hurleysoftware.com> --- drivers/gpu/drm/nouveau/core/core/event.c | 20 ++++++++++++-------- drivers/gpu/drm/nouveau/core/include/core/event.h | 4 ++++ drivers/gpu/drm/nouveau/nouveau_drm.c | 8 ++------ 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/n...

On Wed, Aug 28, 2013 at 6:12 AM, Peter Hurley <peter at hurleysoftware.com> wrote: > This series was originally motivated by a deadlock, introduced in > commit 1d7c71a3e2f77336df536855b0efd2dc5bdeb41b > 'drm/nouveau/disp: port vblank handling to event interface', > due to inverted lock order between nouveau_drm_vblank_enable() > and nouveau_...

...ck_functions+0x20/0x20 [<ffffffff8122c22e>] ? trace_hardirqs_on_thunk+0x3a/0x3f [<ffffffff8109d6e7>] sys_init_module+0xb7/0xe0 [<ffffffff8155c156>] system_call_fastpath+0x1a/0x1f Reported-by: Arend van Spriel <arend at broadcom.com> Reported-by: Peter Hurley <peter at hurleysoftware.com> Reported-by: Daniel J Blueman <daniel at quora.org> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at canonical.com> --- XXX: Add Cc: stable at kernel.org if it applies to 3.7 ? diff --git a/drivers/gpu/drm/nouveau/core/core/engctx.c b/drivers/gpu/drm/nouveau/core/core/en...

...arch_cpu_idle+0x26/0x30 [<ffffffff810a5b4e>] cpu_startup_entry+0xce/0x410 [<ffffffff810ae0dc>] ? clockevents_register_device+0xdc/0x140 [<ffffffff81743d4e>] start_secondary+0x255/0x25c Reported-by: Dave Jones <davej at redhat.com> Signed-off-by: Peter Hurley <peter at hurleysoftware.com> --- drivers/gpu/drm/nouveau/core/core/event.c | 22 +++++++++++----------- .../gpu/drm/nouveau/core/engine/software/nv50.c | 1 + .../gpu/drm/nouveau/core/engine/software/nvc0.c | 1 + drivers/gpu/drm/nouveau/core/include/core/event.h | 1 + drivers/gpu/drm/nouveau/nouv...

>From recent additional locking in nouveau, it looks like we see recursive lock acquisition in 3.8-rc6: nouveau [ DEVICE][0000:01:00.0] BOOT0 : 0x0e7150a2 nouveau [ DEVICE][0000:01:00.0] Chipset: GK107 (NVE7) nouveau [ DEVICE][0000:01:00.0] Family : NVE0 nouveau [ VBIOS][0000:01:00.0] checking PRAMIN for image... nouveau [ VBIOS][0000:01:00.0] ... appears to be valid nouveau [

...-scope event handlers (ie., those stored in parent containers). This change in semantics makes explicit the handler lifetime, and distinguishes "one-of" event handlers (such as gpio) from "many temporary" event handlers (such as uevent). Signed-off-by: Peter Hurley <peter at hurleysoftware.com> --- drivers/gpu/drm/nouveau/core/core/event.c | 63 +++++++++++++++++++--- .../gpu/drm/nouveau/core/engine/software/nv50.c | 31 +++++++++-- .../gpu/drm/nouveau/core/engine/software/nvc0.c | 31 +++++++++-- drivers/gpu/drm/nouveau/core/include/core/event.h | 6 +++ .../gp...

https://bugs.freedesktop.org/show_bug.cgi?id=67878 Priority: medium Bug ID: 67878 Assignee: nouveau at lists.freedesktop.org Summary: Hardware freeze after resume from suspend QA Contact: xorg-team at lists.x.org Severity: critical Classification: Unclassified OS: Linux (All) Reporter: bgamari at gmail.com

https://bugs.freedesktop.org/show_bug.cgi?id=70390 Priority: medium Bug ID: 70390 Assignee: nouveau at lists.freedesktop.org Summary: G84: Repeated system crashes under graphics load, E[PFIFO] DMA_PUSHER and lots of E[PGRAPH] QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified

...gt; Peter De Schrijver <pdeschrijver@nvidia.com> Peter Feuerer <peter@piie.net> Peter Foley <pefoley2@verizon.net> Peter Huang <peter.huangpeng@huawei.com> Peter Huewe <peter.huewe@infineon.com> Peter Huewe <peterhuewe@gmx.de> Peter Hurley <peter@hurleysoftware.com> Peter Hutterer <peter.hutterer@who-t.net> Peter Hüwe <PeterHuewe@gmx.de> Peter Jones <pjones@redhat.com> Peter Korsgaard <jacmet@sunsite.dk> Peter Korsgaard <peter.korsgaard@barco.com> Peter Korsgaard <peter.korsgaard@barco.com> (for ocores a...

...gt; Peter De Schrijver <pdeschrijver@nvidia.com> Peter Feuerer <peter@piie.net> Peter Foley <pefoley2@verizon.net> Peter Huang <peter.huangpeng@huawei.com> Peter Huewe <peter.huewe@infineon.com> Peter Huewe <peterhuewe@gmx.de> Peter Hurley <peter@hurleysoftware.com> Peter Hutterer <peter.hutterer@who-t.net> Peter Hüwe <PeterHuewe@gmx.de> Peter Jones <pjones@redhat.com> Peter Korsgaard <jacmet@sunsite.dk> Peter Korsgaard <peter.korsgaard@barco.com> Peter Korsgaard <peter.korsgaard@barco.com> (for ocores a...

...gt; Peter De Schrijver <pdeschrijver@nvidia.com> Peter Feuerer <peter@piie.net> Peter Foley <pefoley2@verizon.net> Peter Huang <peter.huangpeng@huawei.com> Peter Huewe <peter.huewe@infineon.com> Peter Huewe <peterhuewe@gmx.de> Peter Hurley <peter@hurleysoftware.com> Peter Hutterer <peter.hutterer@who-t.net> Peter Hüwe <PeterHuewe@gmx.de> Peter Jones <pjones@redhat.com> Peter Korsgaard <jacmet@sunsite.dk> Peter Korsgaard <peter.korsgaard@barco.com> Peter Korsgaard <peter.korsgaard@barco.com> (for ocores a...

...gt; Peter De Schrijver <pdeschrijver@nvidia.com> Peter Feuerer <peter@piie.net> Peter Foley <pefoley2@verizon.net> Peter Huang <peter.huangpeng@huawei.com> Peter Huewe <peter.huewe@infineon.com> Peter Huewe <peterhuewe@gmx.de> Peter Hurley <peter@hurleysoftware.com> Peter Hutterer <peter.hutterer@who-t.net> Peter Hüwe <PeterHuewe@gmx.de> Peter Jones <pjones@redhat.com> Peter Korsgaard <jacmet@sunsite.dk> Peter Korsgaard <peter.korsgaard@barco.com> Peter Korsgaard <peter.korsgaard@barco.com> (for ocores a...

...gt; Peter De Schrijver <pdeschrijver@nvidia.com> Peter Feuerer <peter@piie.net> Peter Foley <pefoley2@verizon.net> Peter Huang <peter.huangpeng@huawei.com> Peter Huewe <peter.huewe@infineon.com> Peter Huewe <peterhuewe@gmx.de> Peter Hurley <peter@hurleysoftware.com> Peter Hutterer <peter.hutterer@who-t.net> Peter Hüwe <PeterHuewe@gmx.de> Peter Jones <pjones@redhat.com> Peter Korsgaard <jacmet@sunsite.dk> Peter Korsgaard <peter.korsgaard@barco.com> Peter Korsgaard <peter.korsgaard@barco.com> (for ocores a...