search for: httpsconnect

...++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index ed99cc7a9..f8cd37e9f 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -23,7 +23,7 @@ import ssl import sys import time -from http.client import HTTPSConnection +from http.client import HTTPSConnection as _HTTPSConnection from urllib.parse import urlparse import ovirtsdk4 as sdk @@ -38,6 +38,18 @@ timeout = 5*60 # is no formal API here. params = None +class HTTPSConnection(_HTTPSConnection): + def connect(self): + """ +...

For interest only, here is the patch required to make -o rhv-upload work with Python 2 (for RHEL 7). I don't think we want this upstream. A couple of remarks: * It's supposed to be possible to add ‘coding: utf-8’ to the top of .py files to make Python 2 accept that the file is UTF-8 (otherwise it gives an error on loading). However I added this and it didn't appear to make any

...me/wspeirs/src/cldblkdev/cldblkdev.py", line 5, in <module> import gcs File "/home/wspeirs/src/cldblkdev/gcs.py", line 2, in <module> import httplib2 File "/usr/local/lib/python2.7/dist-packages/httplib2/__init__.py", line 930, in <module> class HTTPSConnectionWithTimeout(httplib.HTTPSConnection): AttributeError: 'module' object has no attribute 'HTTPSConnection' Error in sys.excepthook: Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/apport_python_hook.py", line 63, in apport_excepthook from appo...

...ile')) > + if destination_url.scheme == "https": > + context = ssl.create_default_context() > + context.load_verify_locations(cafile = params['rhv_cafile']) > + else: > + context = None > This will create a default context inside HTTPSConnection.__init__, which will try to verify the server certificate and hostname and may fail if the certificates are not set up properly in the tests. Nir > > http = HTTPSConnection( > destination_url.hostname, > -- > 2.19.0.rc0 > > __________________________________...

....py b/v2v/rhv-upload-plugin.py > index d3e6260e97f4..413ad53b05ab 100644 > --- a/v2v/rhv-upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -26,6 +26,9 @@ import ssl > import sys > import time > > +import nbdkit > +import errno > + > from http.client import HTTPSConnection, HTTPConnection > from urllib.parse import urlparse > > @@ -461,6 +464,15 @@ def create_disk(connection): > system_service = connection.system_service() > disks_service = system_service.disks_service() > > + uuid = params.get('rhv_disk_uuid') > +...

v2 was here: https://www.redhat.com/archives/libguestfs/2018-June/msg00109.html v3: - Added/fixed all suggestions from Nir in previous review. Q: I wasn't sure if we still need the "UnsupportedError" class so I left it in. Q: Does the Unix socket always have the same name? What happens if there's more than one transfer happening? I tested this both ways, and it worked both

This adds a test of -o rhv-upload. Obviously for an upstream test we cannot require a working oVirt server. This test works by faking the ovirtsdk4 Python module, setting PYTHONPATH so that the fake module is picked up instead of the real module (if installed). However it's more complex than that because the nbdkit plugin also expects to talk to a working imageio HTTPS server. Therefore

...e.SERVER_AUTH, - cafile = cafile) + cafile = params['rhv_cafile']) if params['insecure']: context.check_hostname = False context.verify_mode = ssl.CERT_NONE http = HTTPSConnection( destination_url.hostname, destination_url.port, context = context ) elif destination_url.scheme == "http": http = HTTPConnection( destination_url.hostname, destination_url.port, ) els...

When sending request with small or no payload, it is simpler and possibly more efficient to use the high level HTTPSConnection.request(), instead of the lower level APIs. The only reason to use the lower level APIs is to avoid copying the payload, or on python 2, to use a bigger buffer size when streaming a file-like object. --- v2v/rhv-upload-plugin.py | 35 ++++++++++++++++------------------- 1 file changed, 16 inse...

.../v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -207,14 +207,25 @@ def open(readonly): else: destination_url = urlparse(transfer.proxy_url) - context = ssl.create_default_context() - context.load_verify_locations(cafile = params['rhv_cafile']) - - http = HTTPSConnection( - destination_url.hostname, - destination_url.port, - context = context - ) + if destination_url.scheme == "https": + context = \ + ssl.create_default_context(purpose = ssl.Purpose.SERVER_AUTH, + cafile...

...index f215eaecf..354cc524c 100644 > --- a/v2v/rhv-upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -19,11 +19,12 @@ > import builtins > import json > import logging > +import socket > import ssl > import sys > import time > > -from http.client import HTTPSConnection > +from http.client import HTTPSConnection, HTTPConnection > from urllib.parse import urlparse > > import ovirtsdk4 as sdk > @@ -56,6 +57,28 @@ def debug(s): > print(s, file=sys.stderr) > sys.stderr.flush() > > +def find_host(connection): > +...

My stab at fixing this: https://bugzilla.redhat.com/show_bug.cgi?id=1789279 It took me quite some time to go through the whole rfc 4122 just to realize we do not need to do anything with the versions. Martin Kletzander (2): rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279) rhv-upload: Check that rhv-disk-uuid is not already taken (RHBZ#1789279)

...-git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index 419008517..0c5eec7d3 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -19,11 +19,12 @@ import builtins import json import logging +import socket import ssl import sys import time -from http.client import HTTPSConnection +from http.client import HTTPSConnection, HTTPConnection from urllib.parse import urlparse import ovirtsdk4 as sdk @@ -117,6 +118,25 @@ def open(readonly): if time.time() > endt: raise RuntimeError("timed out waiting for disk to become unlocked") + # G...

...-git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index f215eaecf..354cc524c 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -19,11 +19,12 @@ import builtins import json import logging +import socket import ssl import sys import time -from http.client import HTTPSConnection +from http.client import HTTPSConnection, HTTPConnection from urllib.parse import urlparse import ovirtsdk4 as sdk @@ -56,6 +57,28 @@ def debug(s): print(s, file=sys.stderr) sys.stderr.flush() +def find_host(connection): + """Return the current host obje...

...-git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index 5be426897..a83b95305 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -19,11 +19,12 @@ import builtins import json import logging +import socket import ssl import sys import time -from http.client import HTTPSConnection +from http.client import HTTPSConnection, HTTPConnection from urllib.parse import urlparse import ovirtsdk4 as sdk @@ -117,6 +118,25 @@ def open(readonly): if time.time() > endt: raise RuntimeError("timed out waiting for disk to become unlocked") + # G...

On Tue, Dec 22, 2015 at 09:33:17PM -0800, John R Pierce wrote: > On 12/22/2015 7:06 PM, Fred Smith wrote: > >Attempting to install latest Calibre on Centos-7, getting: > > > >2015-12-22 21:32:38 URL:https://raw.githubusercontent.com/kovidgoyal/calibre/master/setup/linux-installer.py [25887/25887] -> "-" [1] > >Installing to /home/fredex/calibre-bin/calibre

v1 was here: https://www.redhat.com/archives/libguestfs/2018-June/msg00099.html v2: - Just fixes the two problems noted in the review of the previous version. Rich.

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check

These two patches add support for using a Unix domain socket to directly access imageio in the case where imageio is running on the conversion host (usually that means virt-v2v is running on the RHV node and something else -- eg. CFME scripts -- arranges that the RHV node is the same one running imageio). Conversions in the normal case are not affected - they happen over TCP as usual. This was

...a/v2v/rhv-upload-plugin.py >> +++ b/v2v/rhv-upload-plugin.py >> @@ -19,11 +19,12 @@ >> import builtins >> import json >> import logging >> +import socket >> import ssl >> import sys >> import time >> >> -from http.client import HTTPSConnection >> +from http.client import HTTPSConnection, HTTPConnection >> from urllib.parse import urlparse >> >> import ovirtsdk4 as sdk >> @@ -56,6 +57,28 @@ def debug(s): >> print(s, file=sys.stderr) >> sys.stderr.flush() >> >> +d...