search for: httpp_getvar

...el --- src/format.c 2008-04-19 23:24:30.000000000 -0400 +++ src/format.c 2008-11-29 15:50:59.000000000 -0500 @@ -280,12 +280,32 @@ avl_node *node; ice_config_t *config; + /* Partial hack, check for range and user agent in this function */ + const char *useragent; + useragent = httpp_getvar (client->parser, "user-agent"); + int appledevicesupp = 0; + + if (useragent && strstr(useragent, "CoreMedia")) { + appledevicesupp = 1; + } + remaining = client->refbuf->len; ptr = client->refbuf->data; client->respco...

...;refbuf->data + client->refbuf->len - 2; int bytes; const char *useragent; + char *range; + int rangenumber; + int rangenumber2; if (client_mp3 == NULL) return -1; @@ -657,7 +660,44 @@ remaining -= bytes; ptr += bytes; } + range = httpp_getvar (client->parser, "range"); + if (range != NULL) { + int ret = 0; + int rangeproblem = 0; + ret = sscanf(range, "bytes=%d-%d", &rangenumber, &rangenumber2); + if (ret != 2) { + rangeproblem = 1; + } + if (rangenu...

Hello, I work at SmarctJog.com, we have here some patches on IceCast for performance and reliability, these are mostly client/connection/source cleanups (a slave merge is underway, and some more good stuff (c)), but we'd like this to be merged in before the list gets any longer. Please find attached a list of our patches with a short desc: This one is actually not from us/me, it was found

...quot;listener_peak", "%lu", source->peak_listeners); stats_event_time (source->mount, "stream_start"); + stats_event_args (source->mount, "max_listener_duration", "%lu", source->max_listener_duration); + + const char * user_agent = httpp_getvar (source->client->parser, "user-agent"); + stats_event_args (source->mount, "user-agent", "%s", user_agent); DEBUG0("Source creation complete"); source->last_read = time (NULL); @@ -947,6 +951,8 @@ static void source_apply_mount (sou...

...t;event_number); + ERROR1("Unknown event number: %d, %s", con->event_number, client->con->ip); break; } free(con); @@ -911,7 +911,7 @@ if (strcmp("ICE", httpp_getvar(parser, HTTPP_VAR_PROTOCOL)) && strcmp("HTTP", httpp_getvar(parser, HTTPP_VAR_PROTOCOL))) { - ERROR0("Bad HTTP protocol detected"); + ERROR0("Bad HTTP protocol detected, %s", client->con->ip);...

...= 0; + ram_file_available = 0; + qtl_file_available = 0; } httpclient->refbuf->len = PER_CLIENT_REFBUF_SIZE; @@ -443,6 +467,200 @@ free (fullpath); return 0; } + if (pls_requested && pls_file_available == 0) + { + char *host = httpp_getvar (httpclient->parser, "host"); + char *sourceuri = strdup (path); + char *dot = strrchr(sourceuri, '.'); + + /* at least a couple of players (fb2k/winamp) are reported to send a + * host header but without the port number. So if we are missing the +...

...r machine serving a low-bitrate stream (24 kbit/sec). When I 'killall ezstream' to stop all sources at the same time Icecast crashes with the following stacktrace: #0 avl_get_by_key (tree=0x0, key=0xb6a01308, value_address=0xb6a01310) at ../../../src/avl/avl.c:319 #1 0x08060213 in httpp_getvar (parser=0x8cd2100, name=0x8064c56 "ice-name") at ../../../src/httpp/httpp.c:518 #2 0x08052f9e in source_update_settings (config=0x8068bc0, source=0x8cd9d78, mountinfo=0x8cbd618) at ../../src/source.c:1021 #3 0x08053114 in source_recheck_mounts () at ../../src/source.c:1395 #4...

...22 22:19:28.000000000 +0200 +++ src/format_mp3.c 2006-12-22 16:04:43.485964008 +0100 @@ -627,9 +627,11 @@ return -1; /* hack for flash player, it wants a length */ + /* IE7/Flash Maximum Content-Length is 319324133 ?? */ + /* Modified by Infomaniak Network Guy Baconniere */ if (httpp_getvar(client->parser, "x-flash-version")) { - bytes = snprintf (ptr, remaining, "Content-Length: 347122319\r\n"); + bytes = snprintf (ptr, remaining, "Content-Length: 319324133\r\n"); remaining -= bytes; ptr += bytes; }

..._filtered = 0; avl_node *node; @@ -284,9 +286,19 @@ ptr = client->refbuf->data; client->respcode = 200; - bytes = snprintf (ptr, remaining, "HTTP/1.0 200 OK\r\n" - "Content-Type: %s\r\n", source->format->contenttype); + useragent = httpp_getvar (client->parser, "user-agent"); + protocol = "HTTP/1.0"; + if (useragent) + { + if (strstr(useragent, "shoutcastsource")) /* checking "Media Play Classic" is not necessary */ + { + protocol = "ICY"; + } +...

...). When I 'killall >> ezstream' to stop all sources at the same time Icecast crashes with >> the following stacktrace: >> >> #0 avl_get_by_key (tree=0x0, key=0xb6a01308, value_address=0xb6a01310) >> at ../../../src/avl/avl.c:319 >> #1 0x08060213 in httpp_getvar (parser=0x8cd2100, name=0x8064c56 >> "ice-name") >> at ../../../src/httpp/httpp.c:518 >> #2 0x08052f9e in source_update_settings (config=0x8068bc0, >> source=0x8cd9d78, >> mountinfo=0x8cbd618) at ../../src/source.c:1021 >> #3 0x08053114 in sou...

...4; -*- */ /* format.c ** ** format plugin implementation @@ -101,7 +102,11 @@ void format_send_general_headers(format_ http_var_t *var; avl_node *node; int bytes; + char *client_is_icy; + /* if the client uses icy headers, we'll respond in kind */ + client_is_icy = httpp_getvar(client->parser, "icy-metadata"); + /* iterate through source http headers and send to client */ avl_tree_rlock(source->parser->vars); node = avl_get_first(source->parser->vars); @@ -109,8 +114,12 @@ void format_send_general_headers(format_ var =...

...;00', listen_url_size); snprintf (listenurl, listen_url_size, "http://%s:%d%s", - config->hostname, config->port, source->mount); + config->hostname, ( config->exposed_port ? config->exposed_port : config->port ), source->mount); config_release_config(); str = httpp_getvar(source->parser, "ice-audio-info"); diff --git a/src/yp.c b/src/yp.c index 4470d47..e3acb5f 100644 --- a/src/yp.c +++ b/src/yp.c @@ -584,12 +584,12 @@ static ypdata_t *create_yp_entry (const char *mount) if (url == NULL) break; config = config_get_config(); - ret = snprintf (url, len, &...

...llowing dirty/fast patch which works for me(tm): - --- connection.c Fri Dec 12 23:18:20 2003 +++ connection.c.mod Mon Jan 12 17:50:12 2004 @@ -530,12 +530,16 @@ static int _check_pass_icy(http_parser_t *parser, char *correctpass) { char *password; + int tlen; password = httpp_getvar(parser, HTTPP_VAR_ICYPASSWORD); if(!password) return 0; - - if (strcmp(password, correctpass)) + if (strstr(password, "SOURCE ") == password) password += 7; + if (strstr(password, correctpass) != password + || (password[(tlen = strlen(correctpass))] +...

Ok here's the deal. I set up Icecast and Oddcast, got them to communicate properly, but cannot access the live audio remotely. On other computers in the LAN it works perfetly. Currently I operate wirelessly behind a D-Link 514 router (a mite outdated by now, yes?) and have opened all necessary ports, turned my firewalls off, set this computer as a DMZ, pretty much everything I can think of -