search for: hovold

...ansparent_mode(aux, true); > + > + return -EINVAL; And return 0 explicitly here. > +} > +EXPORT_SYMBOL(drm_dp_lttpr_init); In any case this works well and is needed for external display on the Lenovo ThinkPad T14s, while not breaking the X13s which does not need it: Tested-by: Johan Hovold <johan+linaro at kernel.org> Johan

...It looks like you ignore errors on purpose so I guess that's fine. > + > rc = msm_dp_panel_read_sink_caps(dp->panel, connector); > if (rc) > goto end; Either way, this is needed for external display on my x1e80100 machines, while not breaking the X13s: Tested-by: Johan Hovold <johan+linaro at kernel.org> Johan

On 24-12-11 15:42:27, Johan Hovold wrote: > On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: > > > +/** > > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode > > + * @aux: DisplayPort AUX channel > > + * @enable: Enable or disable transparent mode > > + * > &...

On Thu, 26 Dec 2024, Abel Vesa <abel.vesa at linaro.org> wrote: > On 24-12-11 15:42:27, Johan Hovold wrote: >> On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: >> >> > +/** >> > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode >> > + * @aux: DisplayPort AUX channel >> > + * @enable: Enable or disable transparent m...

On Mon, Dec 30, 2024 at 03:18:35PM +0200, Jani Nikula wrote: > On Thu, 26 Dec 2024, Abel Vesa <abel.vesa at linaro.org> wrote: > > On 24-12-11 15:42:27, Johan Hovold wrote: > >> On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: > >> > >> > +/** > >> > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode > >> > + * @aux: DisplayPort AUX channel > >> > + * @enable: E...

...per for the helper that handles the explicit disabling of non-transparent mode and its disable->enable sequence mentioned in the DP Standard v2.0 section 3.6.6.1. Do this in order to move this handling out of the vendor specific driver implementation into the generic framework. Tested-by: Johan Hovold <johan+linaro at kernel.org> Signed-off-by: Abel Vesa <abel.vesa at linaro.org> --- drivers/gpu/drm/display/drm_dp_helper.c | 61 +++++++++++++++++++++++++++++++++ include/drm/display/drm_dp_helper.h | 2 ++ 2 files changed, 63 insertions(+) diff --git a/drivers/gpu/drm/display/d...

...LTTPR DPCD caps to figure out the number of such LTTPRs first. Then, for platforms (or Type-C dongles) that have at least one such an LTTPR, set its operation mode to transparent mode first and then to non-transparent, just like the mentioned section of the specification mandates. Tested-by: Johan Hovold <johan+linaro at kernel.org> Signed-off-by: Abel Vesa <abel.vesa at linaro.org> --- drivers/gpu/drm/msm/dp/dp_display.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index aff51bb973ebe08...

Looking at both i915 and nouveau DP drivers, both are setting the first LTTPR (if found) in transparent mode first and then in non-transparent mode, just like the DP v2.0 specification mentions in section 3.6.6.1. Being part of the standard, setting the LTTPR in a specific operation mode can be easily moved in the generic framework. So do that by adding a new helper. Then, the msm DP driver is

...onj@inf.ethz.ch> Joerg Roedel <joerg.roedel@amd.com> Joerg Roedel <joro@8bytes.org> Joern Engel <joern@lazybastard.org> Joern Engel <joern@logfs.org> Johan Bjornstedt <johan.bjornstedt@stericsson.com> Johan Hedberg <johan.hedberg@intel.com> Johan Hovold <jhovold@gmail.com> Johan Meiring <johanmeiring@gmail.com> Johan Rudholm <johan.rudholm@stericsson.com> Johannes Berg <johannes.berg@intel.com> Johannes Berg <johannes@sipsolutions.net> Johannes Goetzfried <Johannes.Goetzfried@informatik.stud.uni-erlangen....

...onj@inf.ethz.ch> Joerg Roedel <joerg.roedel@amd.com> Joerg Roedel <joro@8bytes.org> Joern Engel <joern@lazybastard.org> Joern Engel <joern@logfs.org> Johan Bjornstedt <johan.bjornstedt@stericsson.com> Johan Hedberg <johan.hedberg@intel.com> Johan Hovold <jhovold@gmail.com> Johan Meiring <johanmeiring@gmail.com> Johan Rudholm <johan.rudholm@stericsson.com> Johannes Berg <johannes.berg@intel.com> Johannes Berg <johannes@sipsolutions.net> Johannes Goetzfried <Johannes.Goetzfried@informatik.stud.uni-erlangen....

...onj@inf.ethz.ch> Joerg Roedel <joerg.roedel@amd.com> Joerg Roedel <joro@8bytes.org> Joern Engel <joern@lazybastard.org> Joern Engel <joern@logfs.org> Johan Bjornstedt <johan.bjornstedt@stericsson.com> Johan Hedberg <johan.hedberg@intel.com> Johan Hovold <jhovold@gmail.com> Johan Meiring <johanmeiring@gmail.com> Johan Rudholm <johan.rudholm@stericsson.com> Johannes Berg <johannes.berg@intel.com> Johannes Berg <johannes@sipsolutions.net> Johannes Goetzfried <Johannes.Goetzfried@informatik.stud.uni-erlangen....

...onj@inf.ethz.ch> Joerg Roedel <joerg.roedel@amd.com> Joerg Roedel <joro@8bytes.org> Joern Engel <joern@lazybastard.org> Joern Engel <joern@logfs.org> Johan Bjornstedt <johan.bjornstedt@stericsson.com> Johan Hedberg <johan.hedberg@intel.com> Johan Hovold <jhovold@gmail.com> Johan Meiring <johanmeiring@gmail.com> Johan Rudholm <johan.rudholm@stericsson.com> Johannes Berg <johannes.berg@intel.com> Johannes Berg <johannes@sipsolutions.net> Johannes Goetzfried <Johannes.Goetzfried@informatik.stud.uni-erlangen....

...onj@inf.ethz.ch> Joerg Roedel <joerg.roedel@amd.com> Joerg Roedel <joro@8bytes.org> Joern Engel <joern@lazybastard.org> Joern Engel <joern@logfs.org> Johan Bjornstedt <johan.bjornstedt@stericsson.com> Johan Hedberg <johan.hedberg@intel.com> Johan Hovold <jhovold@gmail.com> Johan Meiring <johanmeiring@gmail.com> Johan Rudholm <johan.rudholm@stericsson.com> Johannes Berg <johannes.berg@intel.com> Johannes Berg <johannes@sipsolutions.net> Johannes Goetzfried <Johannes.Goetzfried@informatik.stud.uni-erlangen....

...onj@inf.ethz.ch> Joerg Roedel <joerg.roedel@amd.com> Joerg Roedel <joro@8bytes.org> Joern Engel <joern@lazybastard.org> Joern Engel <joern@logfs.org> Johan Bjornstedt <johan.bjornstedt@stericsson.com> Johan Hedberg <johan.hedberg@intel.com> Johan Hovold <jhovold@gmail.com> Johan Meiring <johanmeiring@gmail.com> Johan Rudholm <johan.rudholm@stericsson.com> Johannes Berg <johannes.berg@intel.com> Johannes Berg <johannes@sipsolutions.net> Johannes Goetzfried <Johannes.Goetzfried@informatik.stud.uni-erlangen....

...onj@inf.ethz.ch> Joerg Roedel <joerg.roedel@amd.com> Joerg Roedel <joro@8bytes.org> Joern Engel <joern@lazybastard.org> Joern Engel <joern@logfs.org> Johan Bjornstedt <johan.bjornstedt@stericsson.com> Johan Hedberg <johan.hedberg@intel.com> Johan Hovold <jhovold@gmail.com> Johan Meiring <johanmeiring@gmail.com> Johan Rudholm <johan.rudholm@stericsson.com> Johannes Berg <johannes.berg@intel.com> Johannes Berg <johannes@sipsolutions.net> Johannes Goetzfried <Johannes.Goetzfried@informatik.stud.uni-erlangen....

...d.com> Joerg Roedel <joro@8bytes.org> Joern Engel <joern@lazybastard.org> Joern Engel <joern@logfs.org> Joern Rennecke <joern.rennecke@embecosm.com> Johan Bjornstedt <johan.bjornstedt@stericsson.com> Johan Hedberg <johan.hedberg@intel.com> Johan Hovold <jhovold@gmail.com> Johan Meiring <johanmeiring@gmail.com> Johan Rudholm <johan.rudholm@stericsson.com> Johan Rudholm <jrudholm@gmail.com> Johannes Berg <johannes.berg@intel.com> Johannes Berg <johannes@sipsolutions.net> Johannes Goetzfried <Johann...

...d.com> Joerg Roedel <joro@8bytes.org> Joern Engel <joern@lazybastard.org> Joern Engel <joern@logfs.org> Joern Rennecke <joern.rennecke@embecosm.com> Johan Bjornstedt <johan.bjornstedt@stericsson.com> Johan Hedberg <johan.hedberg@intel.com> Johan Hovold <jhovold@gmail.com> Johan Meiring <johanmeiring@gmail.com> Johan Rudholm <johan.rudholm@stericsson.com> Johan Rudholm <jrudholm@gmail.com> Johannes Berg <johannes.berg@intel.com> Johannes Berg <johannes@sipsolutions.net> Johannes Goetzfried <Johann...