search for: hostname_perform

...other patch. Signed-off-by: Olaf Hering <olaf at aepfle.de> diff --git a/sysprep/sysprep_operation_hostname.ml b/sysprep/sysprep_operation_hostname.ml index 3fc8800..363069b 100644 --- a/sysprep/sysprep_operation_hostname.ml +++ b/sysprep/sysprep_operation_hostname.ml @@ -45,6 +45,10 @@ let hostname_perform g root = g#write filename file; [ `Created_files ] + | "linux", ("opensuse"|"sles") -> + g#write "/etc/HOSTNAME" !hostname; + [ `Created_files ] + | "linux", ("debian"|"ubuntu") -> g#write "/...

...t a/sysprep/sysprep_operation_hostname.ml b/sysprep/sysprep_operation_hostname.ml index 1472a1c..caf5358 100644 --- a/sysprep/sysprep_operation_hostname.ml +++ b/sysprep/sysprep_operation_hostname.ml @@ -25,7 +25,7 @@ module G = Guestfs let hostname = ref "localhost.localdomain" -let hostname_perform g root = +let hostname_perform g root show_log = let typ = g#inspect_get_type root in let distro = g#inspect_get_distro root in match typ, distro with @@ -42,10 +42,12 @@ let hostname_perform g root = String.concat "\n" lines ^ sprintf "\nHOSTNAME=%s\n" !h...

...ed /var/lib/dhcpd/*\n"; [] let dhcp_server_state_op = { diff --git a/sysprep/sysprep_operation_hostname.ml b/sysprep/sysprep_operation_hostname.ml index 1472a1c..6caf8d7 100644 --- a/sysprep/sysprep_operation_hostname.ml +++ b/sysprep/sysprep_operation_hostname.ml @@ -42,10 +42,12 @@ let hostname_perform g root = String.concat "\n" lines ^ sprintf "\nHOSTNAME=%s\n" !hostname in g#write filename file; + eprintf "Modified HOSTNAME to %s\n" !hostname; [ `Created_files ] | "linux", ("debian"|"ubuntu") ->...

Here is a preliminary fix for this bug. I'm running the test suite on this now. Rich.

--- sysprep/sysprep_operation.mli | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sysprep/sysprep_operation.mli b/sysprep/sysprep_operation.mli index 61dde72..eb89db4 100644 --- a/sysprep/sysprep_operation.mli +++ b/sysprep/sysprep_operation.mli @@ -16,14 +16,16 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. *) -(** Structure used to describe sysprep

This patch is incomplete but it illustrates the idea. virt-sysprep is rewritten as a modular tool in OCaml. Only the 'utmp' and 'hostname' operations are implemented at the moment. Rich.

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

Version 1 of the patch, for discussion, but not to be applied. It does work, but needs a lot more testing. This removes all the psychopathic gettextify cruft, and replaces it with a 99 line Makefile.am. A large win, I think. The third patch implements gettext support in the OCaml tools. The fourth patch is just for illustration. It shows the consequent changes to libguestfs.pot and the po