search for: horiguchi

Forking new thread, Hello Naoya, On Mon, Apr 04, 2016 at 04:45:12AM +0000, Naoya Horiguchi wrote: > On Mon, Apr 04, 2016 at 10:39:17AM +0900, Minchan Kim wrote: > > On Fri, Apr 01, 2016 at 02:58:21PM +0200, Vlastimil Babka wrote: > > > On 03/30/2016 09:12 AM, Minchan Kim wrote: > > > >Procedure of page migration is as follows: > > > > > > &...

Forking new thread, Hello Naoya, On Mon, Apr 04, 2016 at 04:45:12AM +0000, Naoya Horiguchi wrote: > On Mon, Apr 04, 2016 at 10:39:17AM +0900, Minchan Kim wrote: > > On Fri, Apr 01, 2016 at 02:58:21PM +0200, Vlastimil Babka wrote: > > > On 03/30/2016 09:12 AM, Minchan Kim wrote: > > > >Procedure of page migration is as follows: > > > > > > &...

...mpaction (perhaps also other migration users) has to drain > > >the lru pvec... Getting rid of this stuff is worth even by itself." > > > > > >Cc: Mel Gorman <mgorman at suse.de> > > >Cc: Hugh Dickins <hughd at google.com> > > >Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> > > >Acked-by: Vlastimil Babka <vbabka at suse.cz> > > >Signed-off-by: Minchan Kim <minchan at kernel.org> > > > > [...] > > > > >@@ -974,28 +986,28 @@ static ICE_noinline int unmap_and_move(new_page_t g...

...mpaction (perhaps also other migration users) has to drain > > >the lru pvec... Getting rid of this stuff is worth even by itself." > > > > > >Cc: Mel Gorman <mgorman at suse.de> > > >Cc: Hugh Dickins <hughd at google.com> > > >Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> > > >Acked-by: Vlastimil Babka <vbabka at suse.cz> > > >Signed-off-by: Minchan Kim <minchan at kernel.org> > > > > [...] > > > > >@@ -974,28 +986,28 @@ static ICE_noinline int unmap_and_move(new_page_t g...

...Comment from Vlastimil > "Yeah, and compaction (perhaps also other migration users) has to drain > the lru pvec... Getting rid of this stuff is worth even by itself." > > Cc: Mel Gorman <mgorman at suse.de> > Cc: Hugh Dickins <hughd at google.com> > Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> > Acked-by: Vlastimil Babka <vbabka at suse.cz> > Signed-off-by: Minchan Kim <minchan at kernel.org> [...] > @@ -974,28 +986,28 @@ static ICE_noinline int unmap_and_move(new_page_t get_new_page, > list_del(&page->lru); >...

...Comment from Vlastimil > "Yeah, and compaction (perhaps also other migration users) has to drain > the lru pvec... Getting rid of this stuff is worth even by itself." > > Cc: Mel Gorman <mgorman at suse.de> > Cc: Hugh Dickins <hughd at google.com> > Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> > Acked-by: Vlastimil Babka <vbabka at suse.cz> > Signed-off-by: Minchan Kim <minchan at kernel.org> [...] > @@ -974,28 +986,28 @@ static ICE_noinline int unmap_and_move(new_page_t get_new_page, > list_del(&page->lru); >...

On Mon, Apr 04, 2016 at 04:46:31PM +0200, Vlastimil Babka wrote: > On 04/04/2016 06:45 AM, Naoya Horiguchi wrote: > > On Mon, Apr 04, 2016 at 10:39:17AM +0900, Minchan Kim wrote: ... > >>> > >>> Also (but not your fault) the put_page() preceding > >>> test_set_page_hwpoison(page)) IMHO deserves a comment saying which > >>> pin we are releasing and wh...

On Mon, Apr 04, 2016 at 04:46:31PM +0200, Vlastimil Babka wrote: > On 04/04/2016 06:45 AM, Naoya Horiguchi wrote: > > On Mon, Apr 04, 2016 at 10:39:17AM +0900, Minchan Kim wrote: ... > >>> > >>> Also (but not your fault) the put_page() preceding > >>> test_set_page_hwpoison(page)) IMHO deserves a comment saying which > >>> pin we are releasing and wh...

...nt==1 in putback_lru_page() which would take the put_page() shortcut from there. But maybe it can't be done nicely without races. > Cc: Vlastimil Babka <vbabka at suse.cz> > Cc: Mel Gorman <mgorman at suse.de> > Cc: Hugh Dickins <hughd at google.com> > Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> > Signed-off-by: Minchan Kim <minchan at kernel.org> Acked-by: Vlastimil Babka <vbabka at suse.cz> Note in -next/after 4.6-rc1 this will need some rebasing though.

...nt==1 in putback_lru_page() which would take the put_page() shortcut from there. But maybe it can't be done nicely without races. > Cc: Vlastimil Babka <vbabka at suse.cz> > Cc: Mel Gorman <mgorman at suse.de> > Cc: Hugh Dickins <hughd at google.com> > Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> > Signed-off-by: Minchan Kim <minchan at kernel.org> Acked-by: Vlastimil Babka <vbabka at suse.cz> Note in -next/after 4.6-rc1 this will need some rebasing though.

On 04/05/2016 03:54 AM, Naoya Horiguchi wrote: > On Mon, Apr 04, 2016 at 04:46:31PM +0200, Vlastimil Babka wrote: >> On 04/04/2016 06:45 AM, Naoya Horiguchi wrote: >>> On Mon, Apr 04, 2016 at 10:39:17AM +0900, Minchan Kim wrote: > ... >>>>> >>>>> Also (but not your fault) the put_page()...

...t; >"Yeah, and compaction (perhaps also other migration users) has to drain > >the lru pvec... Getting rid of this stuff is worth even by itself." > > > >Cc: Mel Gorman <mgorman at suse.de> > >Cc: Hugh Dickins <hughd at google.com> > >Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> > >Acked-by: Vlastimil Babka <vbabka at suse.cz> > >Signed-off-by: Minchan Kim <minchan at kernel.org> > > [...] > > >@@ -974,28 +986,28 @@ static ICE_noinline int unmap_and_move(new_page_t get_new_page, > > list...

On Tue, Apr 05, 2016 at 10:20:50AM +0200, Vlastimil Babka wrote: > On 04/05/2016 03:54 AM, Naoya Horiguchi wrote: > > On Mon, Apr 04, 2016 at 04:46:31PM +0200, Vlastimil Babka wrote: > >> On 04/04/2016 06:45 AM, Naoya Horiguchi wrote: > >>> On Mon, Apr 04, 2016 at 10:39:17AM +0900, Minchan Kim wrote: > > ... > >>>>> > >>>>> Also (but n...

On Tue, Apr 05, 2016 at 10:20:50AM +0200, Vlastimil Babka wrote: > On 04/05/2016 03:54 AM, Naoya Horiguchi wrote: > > On Mon, Apr 04, 2016 at 04:46:31PM +0200, Vlastimil Babka wrote: > >> On 04/04/2016 06:45 AM, Naoya Horiguchi wrote: > >>> On Mon, Apr 04, 2016 at 10:39:17AM +0900, Minchan Kim wrote: > > ... > >>>>> > >>>>> Also (but n...

On 04/04/2016 06:45 AM, Naoya Horiguchi wrote: > On Mon, Apr 04, 2016 at 10:39:17AM +0900, Minchan Kim wrote: >> Thanks for catching it, Vlastimil. >> It was my mistake. But in this chance, I looked over hwpoison code and >> I saw other places which increases num_poisoned_pages are successful >> migration, alre...

...e might do it via page_freeze_refs but what I want at this moment is to separte two semantic put and putback. ;-) > > >Cc: Vlastimil Babka <vbabka at suse.cz> > >Cc: Mel Gorman <mgorman at suse.de> > >Cc: Hugh Dickins <hughd at google.com> > >Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> > >Signed-off-by: Minchan Kim <minchan at kernel.org> > > Acked-by: Vlastimil Babka <vbabka at suse.cz> > > Note in -next/after 4.6-rc1 this will need some rebasing though. Thanks for the review!

...use put_page instead of putback_lru_page and use putback_lru_page only on failure. That makes code more readable and doesn't add overhead in put_page. Cc: Vlastimil Babka <vbabka at suse.cz> Cc: Mel Gorman <mgorman at suse.de> Cc: Hugh Dickins <hughd at google.com> Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> Signed-off-by: Minchan Kim <minchan at kernel.org> --- mm/migrate.c | 49 ++++++++++++++++++++++++++++++------------------- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index 3ad0fea5c438..bf31ea9ffaf8 100644...

...t add overhead in put_page. Comment from Vlastimil "Yeah, and compaction (perhaps also other migration users) has to drain the lru pvec... Getting rid of this stuff is worth even by itself." Cc: Mel Gorman <mgorman at suse.de> Cc: Hugh Dickins <hughd at google.com> Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> Acked-by: Vlastimil Babka <vbabka at suse.cz> Signed-off-by: Minchan Kim <minchan at kernel.org> --- mm/migrate.c | 50 +++++++++++++++++++++++++++++++------------------- 1 file changed, 31 insertions(+), 19 deletions(-) diff --git a/mm/migrate.c b...

...ugh Dickins <hughd at google.com> Cc: John Einar Reitan <john.reitan at foss.arm.com> Cc: Jonathan Corbet <corbet at lwn.net> Cc: Joonsoo Kim <iamjoonsoo.kim at lge.com> Cc: Konstantin Khlebnikov <koct9i at gmail.com> Cc: Mel Gorman <mgorman at suse.de> Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> Cc: Rafael Aquini <aquini at redhat.com> Cc: Rik van Riel <riel at redhat.com> Cc: Sergey Senozhatsky <sergey.senozhatsky at gmail.com> Cc: virtualization at lists.linux-foundation.org Cc: Gioh Kim <gi-oh.kim at profitbricks.com> Cc: Chan...

...ugh Dickins <hughd at google.com> Cc: John Einar Reitan <john.reitan at foss.arm.com> Cc: Jonathan Corbet <corbet at lwn.net> Cc: Joonsoo Kim <iamjoonsoo.kim at lge.com> Cc: Konstantin Khlebnikov <koct9i at gmail.com> Cc: Mel Gorman <mgorman at suse.de> Cc: Naoya Horiguchi <n-horiguchi at ah.jp.nec.com> Cc: Rafael Aquini <aquini at redhat.com> Cc: Rik van Riel <riel at redhat.com> Cc: Sergey Senozhatsky <sergey.senozhatsky at gmail.com> Cc: virtualization at lists.linux-foundation.org Cc: Gioh Kim <gi-oh.kim at profitbricks.com> Cc: Chan...