search for: hlper

Hi, I''m having some problems with redcloth(3.0.4 gem) and textilize. I have a string: "h2. hello _what''s up?_" which is being textilized as: <h2>hello<br /> <em>what&#8217;s up?</em></h2> so no paragraph and h2 wrapped all the way. the input is coming from firefox 1.5.2 on a mac Anybody got any idea what the problem might be? --

...else > - to_intel_crtc_state(crtc_state)->dp_m_n.tu = 0; > - } > - return ret; > + if (new_crtc) > + return 0; Not sure why we shouldn't release this? If we handle this in helpers, it would remove piles of special casing code here I think. Plus remove special code in the hlpers. > + > + return drm_dp_atomic_release_vcpi_slots(state, mgr, port); > } > > static void intel_mst_disable_dp(struct intel_encoder *encoder, > diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h > index 3faceb66f5cb..2392e12b6bce 100644 > ---...

...shouldn't release this? If we handle this in > > > > > > helpers, > > > > > > it > > > > > > would remove piles of special casing code here I think. Plus > > > > > > remove > > > > > > special code in the hlpers. > > > > > > > > > > > > > > > > > > > + > > > > > > > + return drm_dp_atomic_release_vcpi_slots(state, mgr, port); > > > > > > > } > > > > > > > > > > > > &gt...

...; > > > > + return 0; > > > > > > > > Not sure why we shouldn't release this? If we handle this in helpers, > > > > it > > > > would remove piles of special casing code here I think. Plus remove > > > > special code in the hlpers. > > > > > > > > > > > > > + > > > > > + return drm_dp_atomic_release_vcpi_slots(state, mgr, port); > > > > > } > > > > > > > > > > static void intel_mst_disable_dp(struct intel_encoder *encoder, &...

...; - } > > > - return ret; > > > + if (new_crtc) > > > + return 0; > > > > Not sure why we shouldn't release this? If we handle this in helpers, it > > would remove piles of special casing code here I think. Plus remove > > special code in the hlpers. > > > > > > > + > > > + return drm_dp_atomic_release_vcpi_slots(state, mgr, port); > > > } > > > > > > static void intel_mst_disable_dp(struct intel_encoder *encoder, > > > diff --git a/include/drm/drm_dp_mst_helper.h > &g...

..._state)->dp_m_n.tu = 0; > > - } > > - return ret; > > + if (new_crtc) > > + return 0; > > Not sure why we shouldn't release this? If we handle this in helpers, it > would remove piles of special casing code here I think. Plus remove > special code in the hlpers. > > > > + > > + return drm_dp_atomic_release_vcpi_slots(state, mgr, port); > > } > > > > static void intel_mst_disable_dp(struct intel_encoder *encoder, > > diff --git a/include/drm/drm_dp_mst_helper.h > > b/include/drm/drm_dp_mst_helper.h &gt...

..._state)->dp_m_n.tu = 0; > > - } > > - return ret; > > + if (new_crtc) > > + return 0; > > Not sure why we shouldn't release this? If we handle this in helpers, it > would remove piles of special casing code here I think. Plus remove > special code in the hlpers. > > > > + > > + return drm_dp_atomic_release_vcpi_slots(state, mgr, port); > > } > > > > static void intel_mst_disable_dp(struct intel_encoder *encoder, > > diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h > > ind...

...ret; > > > > + if (new_crtc) > > > > + return 0; > > > > > > Not sure why we shouldn't release this? If we handle this in helpers, it > > > would remove piles of special casing code here I think. Plus remove > > > special code in the hlpers. > > > > > > > > > > + > > > > + return drm_dp_atomic_release_vcpi_slots(state, mgr, port); > > > > } > > > > > > > > static void intel_mst_disable_dp(struct intel_encoder *encoder, > > > > diff --git a...

...return 0; > > > > > > > > > > Not sure why we shouldn't release this? If we handle this in helpers, > > > > > it > > > > > would remove piles of special casing code here I think. Plus remove > > > > > special code in the hlpers. > > > > > > > > > > > > > > > > + > > > > > > + return drm_dp_atomic_release_vcpi_slots(state, mgr, port); > > > > > > } > > > > > > > > > > > > static void intel_mst_disable_...

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. [sorry for still not adding your R-Bs! I ended up needing to make a lot of changes to make it so we do actually kref() each port in the atomic state] Cc: Daniel