search for: hivex_node_get_child

...nge anything. > > Anyway, now, I can see things running for some times. Then failing. > > The log file is attached. I have read it quickly. I'm tired. See you > tomorrow. > > Relevant parts : > > -------------------------------------------- > libguestfs: trace: hivex_node_get_child = 968144 > libguestfs: trace: hivex_node_get_child 968144 "firstboot" > guestfsd: main_loop: new request, len 0x40^M > guestfsd: error: failed: Argument list too long^M > guestfsd: main_loop: proc 355 (hivex_node_get_child) took 0.00 seconds^M > libguestfs: trace: hivex_nod...

...attached a patch for a new function in the hivex library that implements obtaining a handle to a "deep" node, allowing the user to enter a path like "SOFTWARE\Intel\Infinst\Uninstall" with only a previous call to load the root of, say, HKLM. When I first used libhivex, I assumed hivex_node_get_child would take such a path, but then learned that it only scans the children of the current node for a match. I do realize that hivex_node_get_child has a O(n) where n is the number of keys in the node and this means hivex_node_get_child_deep has a O(mn) where m is the number of \-separated paths; but...

Le 19/11/2014 22:19, Richard W.M. Jones a écrit : > On Wed, Nov 19, 2014 at 10:05:53PM +0100, Nicolas Ecarnot wrote: >> Nov 19 21:54:52 serv-p2v-adm1 sshd[2727]: pam_unix(sshd:session): >> session opened for user root by (uid=0) >> Nov 19 21:54:53 serv-p2v-adm1 sshd[2725]: channel 2: open failed: >> connect failed: Connection refused >> Nov 19 21:54:53

...(g : G.guestfs) inspect source rcaps = > (*----------------------------------------------------------------------*) > (* Perform the conversion of the Windows guest. *) > > + (* Find the 'Current' ControlSet. *) > + let get_current_cs root = > + let select = g#hivex_node_get_child root "Select" in > + let valueh = g#hivex_node_get_value select "Current" in > + let value = int_of_le32 (g#hivex_value_value valueh) in > + sprintf "ControlSet%03Ld" value in > + > let rec configure_firstboot () = > (match installer...

[Partly using the mailing list as a backup again ...] This commit changes virt-v2v to make registry changes to all ControlSets, not just the CurrentControlSet. Not sure what difference if any this would make. Rich.

...sertions(+), 4 deletions(-) diff --git a/src/inspect_fs_windows.c b/src/inspect_fs_windows.c index 11454df..1a34192 100644 --- a/src/inspect_fs_windows.c +++ b/src/inspect_fs_windows.c @@ -395,10 +395,11 @@ check_windows_system_registry (guestfs_h *g, struct inspect_fs *fs) errno = 0; node = hivex_node_get_child (h, root, "MountedDevices"); if (node == 0) { - if (errno != 0) - perrorf (g, "hivex_node_get_child"); - else - error (g, "hivex: could not locate HKLM\\SYSTEM\\MountedDevices"); + if (errno == 0) + /* Not found: skip getting drive letter map...

Greetings, I am suffering of several weird errors which show randomly and make me suspect some concurrency issue. Libguestfs version is 1.28.1, linux kernel 3.16, libvirt 1.2.9 and qemu 2.1. What I'm trying to do is comparing the disk state at two different point of a guest execution. Disk snapshots are taken through libvirt in different moments (I am aware of caching issue), from such

...: 36983920 libguestfs: trace: hivex_open = 0 libguestfs: trace: hivex_root guestfsd: main_loop: proc 350 (hivex_open) took 0.15 seconds guestfsd: main_loop: new request, len 0x28 guestfsd: main_loop: proc 352 (hivex_root) took 0.00 seconds libguestfs: trace: hivex_root = 4128 libguestfs: trace: hivex_node_get_child 4128 "Microsoft" guestfsd: main_loop: new request, len 0x40 libguestfs: trace: hivex_node_get_child = 4448 libguestfs: trace: hivex_node_get_child 4448 "Windows NT" guestfsd: main_loop: proc 355 (hivex_node_get_child) took 0.00 seconds guestfsd: main_loop: new request, len 0x40...

...| None -> - error (f_"cannot find HKLM\\SYSTEM\\%s in the guest registry") - (String.concat "\\" controller_path) - | Some node -> - let rec loop node i = - let controller_offset = sprintf "%04d" i in - let child = g#hivex_node_get_child node controller_offset in - if child = 0_L then controller_offset else loop node (i+1) - in - loop node 0 in + let controller_offset = get_controller_offset g root controller_path in let regedits = [ controller_path @ [ controller_offset ], @@ -400,6 +389,19 @@ and...

...(g : G.guestfs) inspect source rcaps = > (*----------------------------------------------------------------------*) > (* Perform the conversion of the Windows guest. *) > > + (* Find the 'Current' ControlSet. *) > + let get_current_cs root = > + let select = g#hivex_node_get_child root "Select" in > + let valueh = g#hivex_node_get_value select "Current" in > + let value = int_of_le32 (g#hivex_value_value valueh) in > + sprintf "ControlSet%03Ld" value in > + > let rec configure_firstboot () = > (match installer...

...dn.com/b/virtual_pc_guy/archive/2005/10/24/484461.aspx - * - * Disable the rhelscsi service (RHBZ#809273). - *) - let disable = [ "Processor"; "Intelppm"; "rhelscsi" ] in - List.iter ( - fun name -> - let node = g#hivex_node_get_child services name in - if node <> 0L then ( - (* Delete the node instead of trying to disable it (RHBZ#737600) *) - g#hivex_node_delete_child node - ) - ) disable + let node = g#hivex_node_get_child services "rhelscsi" in +...

Wait for driver installations fired by the PnP manager to complete before running firstboot scripts. The first patch is a minor refactoring to pave the way for the second patch. The latter contains the bulk of the changes as well as the description of the idea. Roman Kagan (2): v2v:windows: factor out getting CurrentControlSet v2v:windows: prevent conflicts with PnP on firstboot --- v1

This adds most of the hivex APIs directly to the libguestfs API, so that you can read and write Windows Registry hive files from libguestfs without needing to download and upload hive files from the guest. This is analogous to how Augeas APIs are exposed already (guestfs_aug_*) Also, inspection is now done using the new APIs, which fixes the following bug:

A very miscellaneous set of cleanups to how we handle the Windows registry in virt-v2v, firstboot, and inspection code. This should all be straightforward non-controversial refactoring. Some highlights: - Add a new mllib Registry module containing various utility functions that are currently scattered all around. - Only compute the software/system hive paths once during inspection, and

...rl_sound"; "prl_strg"; "prl_tg"; "prl_time"; + "prl_uprof"; "prl_va" ] in + + match services with + | None -> () + | Some services -> + List.iter ( + fun svc -> + let svc_node = g#hivex_node_get_child services svc in + if svc_node <> 0L then ( + (* Disable the service rather than delete the node as it would + * confuse the uninstaller called from firstboot script. *) + g#hivex_node_set_value svc_node "Start" 4_L (le32_of_int 4_L)...

...ename = sprintf "%s/system32/config/SYSTEM" systemroot in - let filename = g#case_sensitive_path filename in - g#hivex_open ~write:true filename; - - let root_node = g#hivex_root () in - - (* Find the 'Current' ControlSet. *) - let current_cs = - let select = g#hivex_node_get_child root_node "Select" in - let valueh = g#hivex_node_get_value select "Current" in - let value = int_of_le32 (g#hivex_value_value valueh) in - sprintf "ControlSet%03Ld" value in - - (* Add a new rhsrvany service to the system registry to execute firstboo...

...to install qemu-ga. Should it be an error? What's the chance that for a supported guest it might fail? Do the packages have complex dependencies? The patch in general looks OK. Rich. > and add_guestor_to_registry ((g, root) as reg) inspect drv_name drv_pciid = > let ddb_node = g#hivex_node_get_child root "DriverDatabase" in > > diff --git a/v2v/windows_virtio.mli b/v2v/windows_virtio.mli > index 91b3ced45..fa9997829 100644 > --- a/v2v/windows_virtio.mli > +++ b/v2v/windows_virtio.mli > @@ -40,6 +40,10 @@ val install_drivers > virtio devices if we managed t...

...s = List.map ((//) dst_path) packages in + try + Linux.install g inspect packages; + with G.Error msg -> + warning (f_"Failed to install QEMU Guest Agent: %s") msg + and add_guestor_to_registry ((g, root) as reg) inspect drv_name drv_pciid = let ddb_node = g#hivex_node_get_child root "DriverDatabase" in diff --git a/v2v/windows_virtio.mli b/v2v/windows_virtio.mli index 91b3ced45..4558d041b 100644 --- a/v2v/windows_virtio.mli +++ b/v2v/windows_virtio.mli @@ -42,6 +42,11 @@ val install_drivers (**/**) +val install_linux_tools : Guestfs.guestfs -> Types.in...

...s = List.map ((//) dst_path) packages in + try + Linux.install g inspect packages; + with G.Error msg -> + warning (f_"failed to install QEMU Guest Agent: %s") msg + and add_guestor_to_registry ((g, root) as reg) inspect drv_name drv_pciid = let ddb_node = g#hivex_node_get_child root "DriverDatabase" in diff --git a/v2v/windows_virtio.mli b/v2v/windows_virtio.mli index 91b3ced45..fa9997829 100644 --- a/v2v/windows_virtio.mli +++ b/v2v/windows_virtio.mli @@ -40,6 +40,10 @@ val install_drivers virtio devices if we managed to install those, or legacy devices...

...st.map ((//) dst_path) packages in + try + Linux.install_local g inspect packages; + with G.Error msg -> + warning (f_"failed to install QEMU Guest Agent: %s") msg + and add_guestor_to_registry ((g, root) as reg) inspect drv_name drv_pciid = let ddb_node = g#hivex_node_get_child root "DriverDatabase" in diff --git a/v2v/windows_virtio.mli b/v2v/windows_virtio.mli index 91b3ced45..fa9997829 100644 --- a/v2v/windows_virtio.mli +++ b/v2v/windows_virtio.mli @@ -40,6 +40,10 @@ val install_drivers virtio devices if we managed to install those, or legacy devices...