Displaying 11 results from an estimated 11 matches for "hisi_sas".
2020 Mar 11
6
[PATCH RFC v2 02/24] scsi: allocate separate queue for reserved commands
On Tue, Mar 10, 2020 at 09:08:56PM +0000, John Garry wrote:
> On 10/03/2020 18:32, Christoph Hellwig wrote:
> > On Wed, Mar 11, 2020 at 12:25:28AM +0800, John Garry wrote:
> > > From: Hannes Reinecke <hare at suse.com>
> > >
> > > Allocate a separate 'reserved_cmd_q' for sending reserved commands.
> >
> > Why? Reserved command
2020 Mar 11
6
[PATCH RFC v2 02/24] scsi: allocate separate queue for reserved commands
On Tue, Mar 10, 2020 at 09:08:56PM +0000, John Garry wrote:
> On 10/03/2020 18:32, Christoph Hellwig wrote:
> > On Wed, Mar 11, 2020 at 12:25:28AM +0800, John Garry wrote:
> > > From: Hannes Reinecke <hare at suse.com>
> > >
> > > Allocate a separate 'reserved_cmd_q' for sending reserved commands.
> >
> > Why? Reserved command
2020 Apr 23
0
[PATCH RFC v2 02/24] scsi: allocate separate queue for reserved commands
...get_host_dev(struct Scsi_Host *shost)
>>> {
>>> ????[ .. ]
>>> ????starget = scsi_alloc_target(&shost->shost_gendev, 0,
>>> shost->this_id);
>>> ????[ .. ]
>>>
>>> and we have typically:
>>>
>>> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: .this_id??????????????? = -1,
>>>
>>> It's _very_ uncommon to have a negative number as the SCSI target
>>> device; in
>>> fact, it _is_ an unsigned int already.
>>>
>>> But alright, I'll give it a go; let's see wh...
2020 Apr 07
0
[PATCH RFC v2 02/24] scsi: allocate separate queue for reserved commands
...gt;> struct scsi_device *scsi_get_host_dev(struct Scsi_Host *shost)
>> {
>> ?????[ .. ]
>> ?????starget = scsi_alloc_target(&shost->shost_gendev, 0,
>> shost->this_id);
>> ?????[ .. ]
>>
>> and we have typically:
>>
>> drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: .this_id??????????????? = -1,
>>
>> It's _very_ uncommon to have a negative number as the SCSI target
>> device; in fact, it _is_ an unsigned int already.
>>
>
> FWIW, the only other driver (gdth) which I see uses this API has this_id
> = -1...
2020 Apr 07
0
[PATCH RFC v2 02/24] scsi: allocate separate queue for reserved commands
...oes still seem better to use the request
> queue in the scsi device.
>
My concern is this:
struct scsi_device *scsi_get_host_dev(struct Scsi_Host *shost)
{
[ .. ]
starget = scsi_alloc_target(&shost->shost_gendev, 0, shost->this_id);
[ .. ]
and we have typically:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: .this_id = -1,
It's _very_ uncommon to have a negative number as the SCSI target
device; in fact, it _is_ an unsigned int already.
But alright, I'll give it a go; let's see what I'll end up with.
Cheers,
Hannes
--
Dr. Hannes Reinecke...
2019 Dec 11
3
[PATCH 00/24] block, scsi: final compat_ioctl cleanup
...s/ide/ide-floppy_ioctl.c | 35 +++
drivers/ide/ide-gd.c | 14 +
drivers/ide/ide-ioctls.c | 47 ++-
drivers/ide/ide-tape.c | 14 +
drivers/scsi/aic94xx/aic94xx_init.c | 3 +
drivers/scsi/ch.c | 9 +-
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 3 +
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 3 +
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 3 +
drivers/scsi/ipr.c | 3 +
drivers/scsi/isci/init.c | 3 +
drivers/scsi/mvsas/mv_init.c | 3 +
drivers/scsi/pm8001/pm8001_init.c...
2020 Mar 11
0
[PATCH -next 000/491] treewide: use fallthrough;
...4 +-
drivers/scsi/esas2r/esas2r_flash.c | 4 +-
drivers/scsi/esas2r/esas2r_init.c | 6 +-
drivers/scsi/esp_scsi.c | 6 +-
drivers/scsi/fcoe/fcoe_ctlr.c | 8 +-
drivers/scsi/g_NCR5380.c | 2 +-
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
drivers/scsi/hpsa.c | 10 +-
drivers/scsi/ibmvscsi/ibmvfc.c | 6 +-
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 6 +-
drivers/scsi/imm.c | 21 ++--
drivers/scsi/isci/phy.c...
2020 Mar 11
0
[PATCH -next 000/491] treewide: use fallthrough;
...4 +-
drivers/scsi/esas2r/esas2r_flash.c | 4 +-
drivers/scsi/esas2r/esas2r_init.c | 6 +-
drivers/scsi/esp_scsi.c | 6 +-
drivers/scsi/fcoe/fcoe_ctlr.c | 8 +-
drivers/scsi/g_NCR5380.c | 2 +-
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
drivers/scsi/hpsa.c | 10 +-
drivers/scsi/ibmvscsi/ibmvfc.c | 6 +-
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 6 +-
drivers/scsi/imm.c | 21 ++--
drivers/scsi/isci/phy.c...
2020 Mar 11
0
[PATCH -next 000/491] treewide: use fallthrough;
...4 +-
drivers/scsi/esas2r/esas2r_flash.c | 4 +-
drivers/scsi/esas2r/esas2r_init.c | 6 +-
drivers/scsi/esp_scsi.c | 6 +-
drivers/scsi/fcoe/fcoe_ctlr.c | 8 +-
drivers/scsi/g_NCR5380.c | 2 +-
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
drivers/scsi/hpsa.c | 10 +-
drivers/scsi/ibmvscsi/ibmvfc.c | 6 +-
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 6 +-
drivers/scsi/imm.c | 21 ++--
drivers/scsi/isci/phy.c...
2020 Mar 11
0
[PATCH -next 000/491] treewide: use fallthrough;
...4 +-
drivers/scsi/esas2r/esas2r_flash.c | 4 +-
drivers/scsi/esas2r/esas2r_init.c | 6 +-
drivers/scsi/esp_scsi.c | 6 +-
drivers/scsi/fcoe/fcoe_ctlr.c | 8 +-
drivers/scsi/g_NCR5380.c | 2 +-
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
drivers/scsi/hpsa.c | 10 +-
drivers/scsi/ibmvscsi/ibmvfc.c | 6 +-
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 6 +-
drivers/scsi/imm.c | 21 ++--
drivers/scsi/isci/phy.c...
2020 Mar 11
0
[PATCH -next 000/491] treewide: use fallthrough;
...4 +-
drivers/scsi/esas2r/esas2r_flash.c | 4 +-
drivers/scsi/esas2r/esas2r_init.c | 6 +-
drivers/scsi/esp_scsi.c | 6 +-
drivers/scsi/fcoe/fcoe_ctlr.c | 8 +-
drivers/scsi/g_NCR5380.c | 2 +-
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
drivers/scsi/hpsa.c | 10 +-
drivers/scsi/ibmvscsi/ibmvfc.c | 6 +-
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 6 +-
drivers/scsi/imm.c | 21 ++--
drivers/scsi/isci/phy.c...