search for: hillf

...r replying to the > > original thread. For the git send-email command to use, or tips on how to reply > > if the thread isn't in your mailbox, see the "Reply instructions" at > > https://lkml.kernel.org/r/000000000000188da1058a9c25e3 at google.com > > > Cc Hillf who should had a fix for this. > It could not be a fix in any form without the great idea you shared, Jason:) while reviewing the first version. > Hillf, would you please post a formal patch for this? (for -net) > And feel free to do this thing appropriate or that thing for fixing the r...

On Thu, Jun 13, 2019 at 4:15 PM Hillf Danton <hdanton at sina.com> wrote: > > > Hello Dmitry > > On Thu, 13 Jun 2019 20:12:06 +0800 Dmitry Vyukov wrote: > > On Thu, Jun 13, 2019 at 2:07 PM Hillf Danton <hdanton at sina.com> wrote: > > > > > > Hello Jason > > > > > > O...

Hello Dmitry On Thu, 13 Jun 2019 20:12:06 +0800 Dmitry Vyukov wrote: > On Thu, Jun 13, 2019 at 2:07 PM Hillf Danton <hdanton at sina.com> wrote: > > > > Hello Jason > > > > On Thu, 13 Jun 2019 17:10:39 +0800 Jason Wang wrote: > > > > > > This is basically a kfree(ubuf) after the second vhost_net_flush() in > > > vhost_net_release(). > > > &...

Hello Dmitry On Thu, 13 Jun 2019 20:12:06 +0800 Dmitry Vyukov wrote: > On Thu, Jun 13, 2019 at 2:07 PM Hillf Danton <hdanton at sina.com> wrote: > > > > Hello Jason > > > > On Thu, 13 Jun 2019 17:10:39 +0800 Jason Wang wrote: > > > > > > This is basically a kfree(ubuf) after the second vhost_net_flush() in > > > vhost_net_release(). > > > &...

...ally a kfree(ubuf) after the second vhost_net_flush() in > vhost_net_release(). > Fairly good catch. > Could you please post a formal patch? > I'd like very much to do that; but I wont, I am afraid, until I collect a Tested-by because of reproducer without a cutting edge. Thanks Hillf

...ally a kfree(ubuf) after the second vhost_net_flush() in > vhost_net_release(). > Fairly good catch. > Could you please post a formal patch? > I'd like very much to do that; but I wont, I am afraid, until I collect a Tested-by because of reproducer without a cutting edge. Thanks Hillf

...for this bug, please consider replying to the > original thread. For the git send-email command to use, or tips on how to reply > if the thread isn't in your mailbox, see the "Reply instructions" at > https://lkml.kernel.org/r/000000000000188da1058a9c25e3 at google.com Cc Hillf who should had a fix for this. Hillf, would you please post a formal patch for this? (for -net) > > -------------------------------------------------------------------------------- > Title: INFO: task hung in vhost_init_device_iotlb > Last occurred: 125 days ago &gt...

...e39c378f46f ("vhost-net: fix use-after-free in vhost_net_flush") flush would no longer free ubuf, just wait until ubuf users disappear instead. The following diff, in hope that may perhaps help you handle the memory leak, makes flush able to free ubuf in the path of file release. Thanks Hillf --- drivers/vhost/net.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 3beb401..dcf20b6 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -141,6 +141,7 @@ struct vhost_net { unsigned tx_zcopy_err; /* Flush...

...e39c378f46f ("vhost-net: fix use-after-free in vhost_net_flush") flush would no longer free ubuf, just wait until ubuf users disappear instead. The following diff, in hope that may perhaps help you handle the memory leak, makes flush able to free ubuf in the path of file release. Thanks Hillf --- drivers/vhost/net.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 3beb401..dcf20b6 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -141,6 +141,7 @@ struct vhost_net { unsigned tx_zcopy_err; /* Flush...

On 2019/6/6 ??10:40, Hillf Danton wrote: > > On Wed, 05 Jun 2019 16:42:05 -0700 (PDT) syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:??? 788a0249 Merge tag 'arc-5.2-rc4' of >> git://git.kernel.org/p.. >> git tree:?????? upstream &g...

On Sat, 2020-10-24 at 10:22 +0800, Hillf Danton wrote: > > Looks like we can break the lock chain by moving ttm bo's release > method out of mmap_lock, see diff below. Ah, the perfect compliment to morning java, a patchlet to wedge in and see what happens. wedge/build/boot <schlurp... ahhh> Mmm, box says no banana......

On Thu, Jun 13, 2019 at 2:07 PM Hillf Danton <hdanton at sina.com> wrote: > > > Hello Jason > > On Thu, 13 Jun 2019 17:10:39 +0800 Jason Wang wrote: > > > > This is basically a kfree(ubuf) after the second vhost_net_flush() in > > vhost_net_release(). > > > Fairly good catch. > > &g...

Fri, 26 Jul 2019 08:26:01 -0700 (PDT) > syzbot has bisected this bug to: > > commit 0ecfebd2b52404ae0c54a878c872bb93363ada36 > Author: Linus Torvalds <torvalds at linux-foundation.org> > Date: Sun Jul 7 22:41:56 2019 +0000 > > Linux 5.2 > > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=118810bfa00000 > start commit: 13bf6d6a Add

...put: https://syzkaller.appspot.com/x/log.txt?x=3D15c8f3b6a00000 >kernel config: https://syzkaller.appspot.com/x/.config?x=3Dcb38d33cd06d8d48 >compiler: gcc (GCC) 9.0.0 20181231 (experimental) >patch: https://syzkaller.appspot.com/x/patch.diff?x=3D12477101a00000 > Thanks Hillf

...0.0 20181231 (experimental) >patch: https://syzkaller.appspot.com/x/patch.diff?x=12477101a00000 > The following diff, made against the mainline master tree, purges both the node_db and the self_node_db lists in the destroy path, to free any dangling hsr node. Thanks and good weekend Hillf ------>8--- --- net/hsr/hsr_device.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c index 15c7206..c98ae6f 100644 --- a/net/hsr/hsr_device.c +++ b/net/hsr/hsr_device.c @@ -364,6 +364,12 @@ static void hsr_dev_destroy(struct net_device *hsr_...

On Fri, 23 Oct 2020 14:07:13 +0200 Mike Galbraith wrote: > On Fri, 2020-10-23 at 11:01 +0200, Sebastian Andrzej Siewior wrote: > > On 2020-10-22 07:28:20 [+0200], Mike Galbraith wrote: > > > I've only as yet seen nouveau lockdep gripage when firing up one of my > > > full distro KVM's. > > > > Could you please check !RT with the `threadirqs'

On Tue, 6 Aug 2019 21:00:10 +0300 From: Jaak Ristioja <jaak at ristioja.ee> > Hello! > > I'm writing to report a crash in the QXL / DRM code in the Linux kernel. > I originally filed the issue on LaunchPad and more details can be found > there, although I doubt whether these details are useful. > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1813620

On Tue, 6 Aug 2019 21:00:10 +0300 From: Jaak Ristioja <jaak at ristioja.ee> > Hello! > > I'm writing to report a crash in the QXL / DRM code in the Linux kernel. > I originally filed the issue on LaunchPad and more details can be found > there, although I doubt whether these details are useful. > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1813620

..._dev_cleanup(&n->dev); vhost_net_vq_reset(n); 4_> the ubufs pointer is cleared in vhost_net_vq_reset() #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master Can you give it a shoot please if there is not anything missed in the above logic? Thanks Hillf ------->8--- --- drivers/vhost/net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 3beb401..87db9b3 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -309,6 +309,8 @@ static void vhost_net_vq_reset(struct vhost_net *n) for (i...

..._dev_cleanup(&n->dev); vhost_net_vq_reset(n); 4_> the ubufs pointer is cleared in vhost_net_vq_reset() #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master Can you give it a shoot please if there is not anything missed in the above logic? Thanks Hillf ------->8--- --- drivers/vhost/net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 3beb401..87db9b3 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -309,6 +309,8 @@ static void vhost_net_vq_reset(struct vhost_net *n) for (i...