search for: have_linux_xattr

...Reporter: jeriko.one at gmx.us QA Contact: rsync-qa at samba.org Created attachment 13745 --> https://bugzilla.samba.org/attachment.cgi?id=13745&action=edit change MIGHT_NEED_RPRE to am_root <= 0 $ ./rsync -v rsync version 3.1.3dev protocol version 31 I've built with HAVE_LINUX_XATTRS I'm running rsyncd as a non root user. the args I'm sending rsyncd when connecting are {"--server", "--filter", "+x jk", "-X", ".", ".", "\0"}; code snippets are from xattrs.c in receive_xattr a name is read from t...

On Fri, Jan 10, 2014 at 05:36:39PM +0100, Pino Toscano wrote: > +int > +copy_xattrs (const char *src, const char *dest) > +{ > + abort (); > +} Is this called in the case where someone does copy-attributes foo bar xattributes:true on a version of libguestfs with no support for xattrs? It's probably better to silently ignore this case instead of crashing. Rich. --

...implemented) would cause regressions in such old Linux systems. > We don't care about RHEL 5 since it > now has its own branch ("oldlinux"), so the code might be made simpler > by an accompanying patch which reduces all of the HAVE_*XATTR* macros > down to a single one (HAVE_LINUX_XATTRS). Sounds reasonable; attached a patch for it. -- Pino Toscano

.../test-fuse.c | 4 ---- lib/fuse.c | 2 +- m4/guestfs-libraries.m4 | 1 - 4 files changed, 3 insertions(+), 12 deletions(-) diff --git a/daemon/xattr.c b/daemon/xattr.c index bbe571b3f8bb..b10f6bddf4d0 100644 --- a/daemon/xattr.c +++ b/daemon/xattr.c @@ -37,12 +37,8 @@ #ifdef HAVE_LINUX_XATTRS -# ifdef HAVE_ATTR_XATTR_H -# include <attr/xattr.h> -# else -# ifdef HAVE_SYS_XATTR_H -# include <sys/xattr.h> -# endif +# ifdef HAVE_SYS_XATTR_H +# include <sys/xattr.h> # endif int diff --git a/fuse/test-fuse.c b/fuse/test-fuse.c index 5ce8322f0d0e..ac0a49348a3a 10...

...t char *dest) if (user_only ? !HAS_PREFIX(name, USER_PREFIX) : HAS_PREFIX(name, SYSTEM_PREFIX)) continue; + + if (!strcmp(name, "security.evm")) + continue; #endif datum_len = 0; @@ -828,7 +834,9 @@ void receive_xattr(int f, struct file_struct *file) } #ifdef HAVE_LINUX_XATTRS /* Non-root can only save the user namespace. */ - if (am_root <= 0 && !HAS_PREFIX(name, USER_PREFIX)) { + if (am_root <= 0 && + (!HAS_PREFIX(name, USER_PREFIX) || + !strcmp(name, "security.evm"))) { if (!am_root) { free(ptr); continue;...

...goto error; + } + + CHROOT_IN; + ret = setxattr (dest, &buf[i], attrval, vlen, 0); + CHROOT_OUT; + if (ret == -1) { + reply_with_perror ("setxattr: %s, %s", dest, &buf[i]); + goto error; + } + } + + return 1; + + error: + return 0; +} + #else /* no HAVE_LINUX_XATTRS */ OPTGROUP_LINUXXATTRS_NOT_AVAILABLE +int +copy_xattrs (const char *src, const char *dest) +{ + abort (); +} + #endif /* no HAVE_LINUX_XATTRS */ diff --git a/fish/Makefile.am b/fish/Makefile.am index bd0485f..fb0e99e 100644 --- a/fish/Makefile.am +++ b/fish/Makefile.am @@ -279,6 +279,7 @@...

...ww.kame.net/ AC_EGREP_CPP(yes, [ @@ -940,7 +950,7 @@ if test x"$enable_xattr_support" = x"no" AC_MSG_RESULT(no) else case "$host_os" in - *linux*) + *linux* | *cygwin*) AC_MSG_RESULT(Using Linux xattrs) AC_DEFINE(HAVE_LINUX_XATTRS, 1, [True if you have Linux xattrs]) AC_DEFINE(SUPPORT_XATTRS, 1) -- Lapo Luchini - http://lapo.it/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 896 bytes Desc: OpenPGP digital signature URL: <...

...es:true > > on a version of libguestfs with no support for xattrs? It's probably > better to silently ignore this case instead of crashing. This version shouldn't be ever called, since it is called when optgroup_linuxxattrs_available returns true, which is not the case in the !HAVE_LINUX_XATTRS block (where the abort version of copy_xattrs is implemented). -- Pino Toscano

Hi, attached there is a prototype of patch for adding a new copy-attributes command. Such command would allow copy the attributes of a "file" to another, so for example in guestfish: copy-attributes foo bar permissions:true xattributes:false would only copy the permissions of foo to bar, not copying its extended attributes too. Just few notes: - my first daemon command, so

https://bugzilla.samba.org/show_bug.cgi?id=9594 Summary: Error transferring user and non-user xattr using --fake-super under Linux Product: rsync Version: 3.1.0 Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: P5 Component: core AssignedTo: wayned at

This is a PoC patch for NFSv4/ZFS ACLs. The objective of the patch is that rsync --acls support NFSv4/ZFS ACLs without requiring a new command line option NFSv4 ACLs can't be represented using POSIX draft ACLs, if an NFSv4 ACL is present a separate POSIX draft ACL will not be present and there are new APIs to access NFSv4 ACLs. So we need to distinguish between NFSv4 ACLs and POSIX ACLs in

...probably has none of them, and RHEL 5 / Ubuntu 10.10 probably had only some of them. We don't care about RHEL 5 since it now has its own branch ("oldlinux"), so the code might be made simpler by an accompanying patch which reduces all of the HAVE_*XATTR* macros down to a single one (HAVE_LINUX_XATTRS). > + ssize_t len, vlen, ret; > + CLEANUP_FREE char *buf = NULL, *attrval = NULL; > + size_t i, attrval_len = 0; > + > + CHROOT_IN; > + len = listxattr (src, NULL, 0); > + CHROOT_OUT; > + if (len == -1) { > + reply_with_perror ("listxattr: %s", src);...

https://bugzilla.samba.org/show_bug.cgi?id=13112 Bug ID: 13112 Summary: receive_xattr heap overread with non null terminated name and xattr filter Product: rsync Version: 3.1.3 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: core

...fined(HAVE_LISTXATTR) && defined(HAVE_LLISTXATTR) && \ + defined(HAVE_GETXATTR) && defined(HAVE_LGETXATTR) && \ + defined(HAVE_REMOVEXATTR) && defined(HAVE_LREMOVEXATTR) && \ + defined(HAVE_SETXATTR) && defined(HAVE_LSETXATTR) # define HAVE_LINUX_XATTRS #endif diff --git a/daemon/xfs.c b/daemon/xfs.c index c1a1854..f748902 100644 --- a/daemon/xfs.c +++ b/daemon/xfs.c @@ -316,7 +316,7 @@ parse_xfs_info (char **lines) return ret; -error: + error: free (ret->xfs_mntpoint); free (ret->xfs_logname); free (ret->xfs_rtname);...

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67