search for: have_libnbd

libnbd 0.1.7 was released today, which breaks compilation of nbdkit-nbd-plugin. We could work around it by using #ifdef LIBNBD_HAVE_XXX to learn about the renamed functions, but supporting older versions is not all that important when we don't yet have API stability. So patch 1 copes by just bumping the minimum version instead, except that we have yet another pending libnbd patch with an API

...heck@:>@])], [], [with_libnbd=check]) AS_IF([test "$with_libnbd" != "no"],[ @@ -852,14 +852,14 @@ AS_IF([test "$with_libnbd" != "no"],[ ], [AC_MSG_WARN([libnbd >= 0.9.8 not found, nbd plugin will be crippled])]) ]) -AM_CONDITIONAL([HAVE_LIBNBD], [test "x$LIBNBD_LIBS" != "x"]) -dnl Also you can disable the whole nbd plugin. +dnl For backwards compatibilty, we have a second way to disable the nbd plugin. AC_ARG_ENABLE([nbd-plugin], [AS_HELP_STRING([--disable-nbd-plugin], [disable nbd plugin])], [], [ena...

...nbd], [], [with_libnbd=check]) AS_IF([test "$with_libnbd" != "no"],[ - PKG_CHECK_MODULES([LIBNBD], [libnbd >= 0.1.7],[ + PKG_CHECK_MODULES([LIBNBD], [libnbd >= 0.1.8],[ AC_SUBST([LIBNBD_CFLAGS]) AC_SUBST([LIBNBD_LIBS]) AC_DEFINE([HAVE_LIBNBD],[1],[libnbd found at compile time.]) ], - [AC_MSG_WARN([libnbd >= 0.1.7 not found, nbd plugin will be crippled])]) + [AC_MSG_WARN([libnbd >= 0.1.8 not found, nbd plugin will be crippled])]) ]) AM_CONDITIONAL([HAVE_LIBNBD], [test "x$LIBNBD_LIBS" != "x"]) diff...

...nbd], [], [with_libnbd=check]) AS_IF([test "$with_libnbd" != "no"],[ - PKG_CHECK_MODULES([LIBNBD], [libnbd >= 0.1.9],[ + PKG_CHECK_MODULES([LIBNBD], [libnbd >= 0.9.6],[ AC_SUBST([LIBNBD_CFLAGS]) AC_SUBST([LIBNBD_LIBS]) AC_DEFINE([HAVE_LIBNBD],[1],[libnbd found at compile time.]) ], - [AC_MSG_WARN([libnbd >= 0.1.9 not found, nbd plugin will be crippled])]) + [AC_MSG_WARN([libnbd >= 0.9.6 not found, nbd plugin will be crippled])]) ]) AM_CONDITIONAL([HAVE_LIBNBD], [test "x$LIBNBD_LIBS" != "x"]) dif...

...nbd], [], [with_libnbd=check]) AS_IF([test "$with_libnbd" != "no"],[ - PKG_CHECK_MODULES([LIBNBD], [libnbd >= 0.9.6],[ + PKG_CHECK_MODULES([LIBNBD], [libnbd >= 0.9.8],[ AC_SUBST([LIBNBD_CFLAGS]) AC_SUBST([LIBNBD_LIBS]) AC_DEFINE([HAVE_LIBNBD],[1],[libnbd found at compile time.]) ], - [AC_MSG_WARN([libnbd >= 0.9.6 not found, nbd plugin will be crippled])]) + [AC_MSG_WARN([libnbd >= 0.9.8 not found, nbd plugin will be crippled])]) ]) AM_CONDITIONAL([HAVE_LIBNBD], [test "x$LIBNBD_LIBS" != "x"]) diff...

Patch 1 played with an early draft of Rich's Fedora 30 libnbd package: https://bugzilla.redhat.com/show_bug.cgi?id=1713767#c17 Note that comment 21 provides a newer package 0.1.1-1 with a different API; and that libnbd has more unreleased API changes in the pipeline (whether that will be called 0.2 or 0.1.2); so we'll have to tweak things based on what is actually available in distros.

libnbd-0.1.2-1 is now available in Fedora 29/30 updates-testing, although it was not compiled against libxml2 so it lacks uri support (I ended up testing patch 4 with a self-built libnbd). Diffs since v1 - rebase to master, bump from libnbd 0.1 to 0.1.2, add URI support, better timing results Still not done - patch 5 needs associated tests Eric Blake (5): nbd: Check for libnbd nbd:

libnbd-0.1.4-1 is now available in Fedora 29/30 updates testing. Diffs since v2 - rebase to master, bump from libnbd 0.1.2 to 0.1.3+, add tests to TLS usage which flushed out the need to turn relative pathnames into absolute, doc tweaks Now that the testsuite covers TLS and libnbd has been fixed to provide the things I found lacking when developing v2, I'm leaning towards pushing this on

...kit-exportname-filter(1)> to adjust what export names the client +sees or uses as a default. + =item B<tls=off> =item B<tls=on> diff --git a/tests/Makefile.am b/tests/Makefile.am index 14e9abdb..cbbc750a 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -763,6 +763,7 @@ if HAVE_LIBNBD LIBGUESTFS_TESTS += test-nbd TESTS += \ test-nbd-dynamic-content.sh \ + test-nbd-dynamic-list.sh \ test-nbd-extents.sh \ test-nbd-qcow2.sh \ test-nbd-tls.sh \ @@ -771,6 +772,7 @@ TESTS += \ $(NULL) EXTRA_DIST += \ test-nbd-dynamic-content.sh \ + test-nbd-dynamic-list.sh \ test-nbd-...

Another series on top of my exportname filter, marking off another todo bullet point. With this, you can now use the NBD plugin as a transparent passthrough of all export names served by the remote server in both directions (list advertisement server to client, and export name from client to server). Eric Blake (3): nbd: Implement .default_export, .export_description nbd: Add

...(top_builddir)/common/protocol/libprotocol.la \ $(top_builddir)/common/utils/libutils.la # TODO: drop standalone version, which is locked at nbdkit 1.13.4 behavior, @@ -62,9 +60,15 @@ nbdkit_nbd_plugin_la_CFLAGS += \ $(LIBNBD_CFLAGS) nbdkit_nbd_plugin_la_LIBADD += \ $(LIBNBD_LIBS) + else !HAVE_LIBNBD nbdkit_nbd_plugin_la_SOURCES += \ nbd-standalone.c +nbdkit_nbd_plugin_la_CPPFLAGS += \ + -I$(top_srcdir)/common/protocol \ +nbdkit_nbd_plugin_la_LIBADD += \ + $(top_builddir)/common/protocol/libprotocol.la + endif !HAVE_LIBNBD if HAVE_POD -- 2.20.1

...(top_builddir)/common/protocol/libprotocol.la \ $(top_builddir)/common/utils/libutils.la # TODO: drop standalone version, which is locked at nbdkit 1.13.4 behavior, @@ -62,9 +60,15 @@ nbdkit_nbd_plugin_la_CFLAGS += \ $(LIBNBD_CFLAGS) nbdkit_nbd_plugin_la_LIBADD += \ $(LIBNBD_LIBS) + else !HAVE_LIBNBD nbdkit_nbd_plugin_la_SOURCES += \ nbd-standalone.c +nbdkit_nbd_plugin_la_CPPFLAGS += \ + -I$(top_srcdir)/common/protocol \ +nbdkit_nbd_plugin_la_LIBADD += \ + $(top_builddir)/common/protocol/libprotocol.la + endif !HAVE_LIBNBD if HAVE_POD -- 2.20.1

The first four patches are fairly routine clean up and can be reviewed/applied on their own. The fifth patch is problematic as described below. At the moment if you want to proxy through to qemu-nbd (eg. for handling qcow2 files) it's rather complicated and you end up having to manage the sockets and clean up yourself. However the library we use for the proxying supports a perfectly good

I fixed the deadlock - turned out to be an actual bug in the nbd plugin (see patch 8). I changed the command syntax so it's now: nbdkit nbd command=qemu arg=-f arg=qcow2 arg=/path/to/disk.qcow2 Nir wrote: 18:08 < nsoffer> rwmjones: regarding the nbd proxy patches, did you have specific flow that help us? 18:08 < nsoffer> rwmjones: or this is just a way to support qcow2 in the

It's been several weeks since I posted v2 (I got distracted by improving libnbd to better test things, which in turn surfaced some major memory leak problems in nbdsh that are now fixed). Many of the patches are minor rebases from v2, with the biggest changes being fallout from: - patch 2: rename nbdkit_add_default_export to nbdkit_use_default_export - overall: this missed 1.22, so update