search for: have_gnutl

...own-freebsd4.8 [...] checking whether va_lists can be copied by value... yes checking for gnutls_global_init in -lgnutls... no ./configure.lineno: 25085: Syntax error: word unexpected (expecting ")") Looking at the script: cat >>confdefs.h <<\_ACEOF #define HAVE_GNUTLS _ACEOF SSL_LIBS="-lgnutls -lgcrypt" have_ssl="yes (GNUTLS)" have_gnutls=yes fi done <-- line 25085 fi fi if test "$want_openssl" = "yes&q...

...op-qemu-nbd-tls-certs \ interop-qemu-nbd-tls-psk TESTS += \ - interop-qemu-nbd \ - interop-qemu-nbd-tls-certs \ + interop-qemu-nbd + +# tls tests assume the pre-existence of files created in ../tests/Makefile.am, +# so we can only run them under the same conditions used there +if HAVE_NBDKIT +if HAVE_GNUTLS +if HAVE_CERTTOOL +TESTS += \ + interop-qemu-nbd-tls-certs +endif +if HAVE_PSKTOOL +TESTS += \ interop-qemu-nbd-tls-psk +endif +endif +endif interop_qemu_nbd_SOURCES = interop.c interop_qemu_nbd_CPPFLAGS = \ -- 2.20.1

I was a little surprised to find that LIBNBD_TLS_ALLOW worked out of the box, so I had to examine the logs whereupon I saw the magic message ... libnbd: debug: nbd1: nbd_connect_command: server refused TLS (policy), continuing with unencrypted connection I don't believe this path has ever been tested before. It's possible the tests could be improved if they actually checked for this

...lib/handle.c index cc311ba..e40b274 100644 --- a/lib/handle.c +++ b/lib/handle.c @@ -227,6 +227,18 @@ nbd_unlocked_get_version (struct nbd_handle *h) return PACKAGE_VERSION; } +/* NB: is_locked = false, may_set_error = false. */ +int +nbd_unlocked_supports_tls (struct nbd_handle *h) +{ +#ifdef HAVE_GNUTLS + return 1; +#else + return 0; +#endif +} + +/* NB: is_locked = false, may_set_error = false. */ int nbd_unlocked_supports_uri (struct nbd_handle *h) { -- 2.20.1

On 9/17/19 5:35 PM, Richard W.M. Jones wrote: > This neutral refactoring adds -DTLS_MODE. We can in future change the > requested TLS mode, but not in this commit. > > It also checks that nbd_get_tls_negotiated returns true after > connecting, when the requested mode was set to LIBNBD_TLS_REQUIRE. > --- > interop/Makefile.am | 4 ++++ > interop/interop.c | 26

Hello, I'd suggest a way to get to know the "capabilities" of a compiled Dovecot. The background is that I've run the sequence ./configure --with-ldap && make && make install twice, all three commands tell me that all is fine (ldap is listed in the modules), but still dovecot told me that ldap is no Usedb module. A "make clean" before solved the

...rno == EAGAIN || errno == EWOULDBLOCK) return 1; /* more data */ diff --git a/lib/crypto.c b/lib/crypto.c index c437788..aba2e27 100644 --- a/lib/crypto.c +++ b/lib/crypto.c @@ -145,7 +145,7 @@ nbd_unlocked_set_tls_psk_file (struct nbd_handle *h, const char *filename) #ifdef HAVE_GNUTLS static ssize_t -tls_recv (struct socket *sock, void *buf, size_t len) +tls_recv (struct nbd_handle *h, struct socket *sock, void *buf, size_t len) { ssize_t r; @@ -163,7 +163,8 @@ tls_recv (struct socket *sock, void *buf, size_t len) } static ssize_t -tls_send (struct socket *sock, co...

...s, -nbd_get_tls_negotiated is not tested. - Implement nbd_connect + systemd socket activation. Improve function trace output so that: diff --git a/interop/Makefile.am b/interop/Makefile.am index 8a5b787..43350a8 100644 --- a/interop/Makefile.am +++ b/interop/Makefile.am @@ -145,17 +145,25 @@ if HAVE_GNUTLS if HAVE_CERTTOOL check_PROGRAMS += \ interop-nbdkit-tls-certs \ + interop-nbdkit-tls-certs-allow-enabled \ + interop-nbdkit-tls-certs-allow-fallback \ $(NULL) TESTS += \ interop-nbdkit-tls-certs \ + interop-nbdkit-tls-certs-allow-enabled \ + interop-nbdkit-tls-certs-allow-fallback \ $(N...

...69..a0d7c60 100644 --- a/plugins/reflection/reflection.c +++ b/plugins/reflection/reflection.c @@ -35,6 +35,9 @@ #include <stdio.h> #include <stdlib.h> #include <string.h> +#include <sys/socket.h> +#include <netinet/in.h> +#include <arpa/inet.h> #if defined(HAVE_GNUTLS) && defined(HAVE_GNUTLS_BASE64_DECODE2) #include <gnutls/gnutls.h> @@ -49,6 +52,7 @@ enum mode { MODE_EXPORTNAME, MODE_BASE64EXPORTNAME, + MODE_ADDRESS, }; static enum mode mode = MODE_EXPORTNAME; @@ -67,6 +71,9 @@ reflection_config (const char *key, const char *value)...

...;sockout); + close_or_nullify_fd (conn->sockout); } diff --git a/server/crypto.c b/server/crypto.c index 9cd1bb0..6f97f2c 100644 --- a/server/crypto.c +++ b/server/crypto.c @@ -47,6 +47,7 @@ #include <assert.h> #include "internal.h" +#include "utils.h" #ifdef HAVE_GNUTLS @@ -404,9 +405,9 @@ crypto_close (struct connection *conn) gnutls_bye (session, GNUTLS_SHUT_RDWR); if (sockin >= 0) - close (sockin); + close_or_nullify_fd (sockin); if (sockout >= 0 && sockin != sockout) - close (sockout); + close_or_nullify_fd (sockout);...

...HAVE_DIRENT_H ?? HAVE_DLFCN_H ?? HAVE_ENDIAN_H ?? HAVE_ERRNO_H ?? HAVE_ERR_H ?? HAVE_EXECINFO_H ?? HAVE_FAM_H ?? HAVE_FCNTL_H ?? HAVE_FLOAT_H ?? HAVE_FNMATCH_H ?? HAVE_FORM_H ?? HAVE_FTW_H ?? HAVE_FUSE_FUSE_LOWLEVEL_H ?? HAVE_GCRYPT_H ?? HAVE_GETOPT_H ?? HAVE_GLOB_H ?? HAVE_GLUSTERFS_API_GLFS_H ?? HAVE_GNUTLS_GNUTLS_H ?? HAVE_GNUTLS_X509_H ?? HAVE_GPGME_H ?? HAVE_GRP_H ?? HAVE_GSSAPI_GSSAPI_H ?? HAVE_GSSAPI_GSSAPI_KRB5_H ?? HAVE_GSSAPI_GSSAPI_SPNEGO_H ?? HAVE_ICONV_H ?? HAVE_IFADDRS_H ?? HAVE_INTTYPES_H ?? HAVE_KRB5_H ?? HAVE_KRB5_LOCATE_PLUGIN_H ?? HAVE_LANGINFO_H ?? HAVE_LASTLOG_H ?? HAVE_LBER_H ?? H...

...$(NULL) TESTS += \ interop-qemu-nbd \ dirty-bitmap.sh \ - structured-read.sh + structured-read.sh \ + $(NULL) # tls tests assume the pre-existence of files created in ../tests/Makefile.am, # so we can only run them under the same conditions used there @@ -62,11 +65,13 @@ if HAVE_NBDKIT if HAVE_GNUTLS if HAVE_CERTTOOL TESTS += \ - interop-qemu-nbd-tls-certs + interop-qemu-nbd-tls-certs \ + $(NULL) endif if HAVE_PSKTOOL TESTS += \ - interop-qemu-nbd-tls-psk + interop-qemu-nbd-tls-psk \ + $(NULL) endif endif endif @@ -77,7 +82,8 @@ interop_qemu_nbd_CPPFLAGS = \ -DSERVE_OVER_TCP=1 \ -D...

...IABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT + * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +#include <config.h> + +#include <stdio.h> +#include <stdlib.h> +#include <string.h> + +#if defined(HAVE_GNUTLS) && defined(HAVE_GNUTLS_BASE64_DECODE2) +#include <gnutls/gnutls.h> +#define HAVE_BASE64 1 +#endif + +#define NBDKIT_API_VERSION 2 + +#include <nbdkit-plugin.h> + +/* The mode. */ +enum mode { + MODE_EXPORTNAME, + MODE_BASE64EXPORTNAME, +}; +static enum mode mode = MODE_EXPOR...

This series is based on my blog posting here: https://rwmj.wordpress.com/2019/09/13/nbdkit-supports-exportnames/ It depends on the fix for realloc: https://www.redhat.com/archives/libguestfs/2019-September/thread.html#00103 This series adds a fun plugin, and also an semi-related feature I've long thought to be desirable. You can consider patches 1 & 4, and patches 2 & 3 as forming

Samba 4.12.1, single server with AD+DC on Ubuntu 18.04. Filesystem: /dev/sdb1 on /home type ext4 (rw,relatime,stripe=32750,data=ordered) It all work as expected, but I occasionally get the error in subject which denies access to shares. Restarting Samba will restore functionality. What can be the cause of this problem? Thanks. [2020/05/27 18:24:35.795379, 8]

...== -1) - return -1; - if (conn_recv_full (conn, data, optlen, - "read: %s: %m", name_of_nbd_opt (option)) == -1) - return -1; - continue; - } - - if (tls == 0) { /* --tls=off (NOTLS mode). */ -#ifdef HAVE_GNUTLS -#define NO_TLS_REPLY NBD_REP_ERR_POLICY -#else -#define NO_TLS_REPLY NBD_REP_ERR_UNSUP -#endif - if (send_newstyle_option_reply (conn, option, NO_TLS_REPLY) == -1) - return -1; - } - else /* --tls=on or --tls=require */ { - /* We can't upgrade to TLS twice on...

...AGE_H HAVE_CURSES_H HAVE_DBUS_DBUS_H HAVE_DIRENT_H HAVE_DLFCN_H HAVE_ENDIAN_H HAVE_ERRNO_H HAVE_ERR_H HAVE_EXECINFO_H HAVE_FCNTL_H HAVE_FLOAT_H HAVE_FNMATCH_H HAVE_FORM_H HAVE_FTW_H HAVE_GETOPT_H HAVE_GLIB_H HAVE_GLOB_H HAVE_GLUSTERFS_API_GLFS_H HAVE_GNUTLS_GNUTLS_H HAVE_GPFS_H HAVE_GPGME_H HAVE_GRP_H HAVE_GSSAPI_GSSAPI_H HAVE_GSSAPI_GSSAPI_KRB5_H HAVE_GSSAPI_GSSAPI_SPNEGO_H HAVE_ICONV_H HAVE_IFADDRS_H HAVE_INTTYPES_H HAVE_KRB5_H HAVE_KRB5_LOCATE_PLUGIN_H HAVE_LANGINFO_H HAVE_LASTLOG_H HAVE_LBER_H HAVE_LDA...

These are a couple of patches in preparation for the Block Status implementation. While the patches (especially the second one) are very large they are really just elementary code motion. Rich.

...er/crypto.c @@ -41,12 +41,12 @@ #include <string.h> #include <unistd.h> #include <fcntl.h> -#include <limits.h> #include <errno.h> #include <sys/types.h> #include <assert.h> #include "internal.h" +#include "realpath.h" #ifdef HAVE_GNUTLS diff --git a/server/log-syslog.c b/server/log-syslog.c index fdac45f1..6e9a1bfd 100644 --- a/server/log-syslog.c +++ b/server/log-syslog.c @@ -37,9 +37,9 @@ #include <stdarg.h> #include <string.h> #include <errno.h> -#include <syslog.h> #include "internal.h&quo...

For existing commits, this is almost identical to v1, except that I updated some commit messages and reordered the commits in a somewhat more logical sequence. The main changes are the extra commits: [06/11] plugins: Return NBD_FLAG_CAN_MULTI_CONN from some readonly plugins. - Readonly plugins that can set the flag unconditionally. [09/11] partitioning: Return NBD_FLAG_CAN_MULTI_CONN. [10/11]