search for: have_fchmod

...= 0666; ! savemode = 0666; ! } if ((a->flags & SSH2_FILEXFER_ATTR_PERMISSIONS) && (a->perm & S_IFDIR)) { error("Cannot download a directory: %s", remote_path); *************** *** 931,939 **** /* Override umask and utimes if asked */ #ifdef HAVE_FCHMOD ! if (pflag && fchmod(local_fd, mode) == -1) #else ! if (pflag && chmod(local_path, mode) == -1) #endif /* HAVE_FCHMOD */ error("Couldn't set mode on \"%s\": %s", local_path, strerror(errno)); --- 984,992 ---- /* Override umask...

...h do not have a 64bits version into the AIX libc. A very simple workaround to the big files writing rsync pb. is to not use this routine that create files w/ mkstemp() by modifying the "syscall.c" source file at line 154 as following : #if defined(HAVE_SECURE_MKSTEMP) && defined(HAVE_FCHMOD) become #if defined(HAVE_SECURE_MKSTEMP) && defined(HAVE_FCHMOD) && ! defined(_AIX) Hope this will help poor AIX users ;-) Dean, a nostalgic Digital Unix veteran. Digital/Tru64 Unix don't care big files !

....6/syscall.c *** rsync-2.5.6.orig/syscall.c Sun Jan 26 21:09:02 2003 --- rsync-2.5.6/syscall.c Wed May 14 13:55:15 2003 *************** *** 151,157 **** if (dry_run) return -1; if (read_only) {errno = EROFS; return -1;} ! #if defined(HAVE_SECURE_MKSTEMP) && defined(HAVE_FCHMOD) { int fd = mkstemp(template); if (fd == -1) return -1; --- 151,157 ---- if (dry_run) return -1; if (read_only) {errno = EROFS; return -1;} ! #if defined(HAVE_SECURE_MKSTEMP) && defined(HAVE_FCHMOD) && !defined(_AIX)...

...tomicio(write, remout, "", 1); @@ -861,7 +885,7 @@ } #if 0 if (ftruncate(ofd, size)) { - run_err("%s: truncate: %s", np, strerror(errno)); + run_err("%s: truncate: %s", dest, strerror(errno)); wrerr = DISPLAYED; } #endif @@ -870,19 +894,19 @@ #ifdef HAVE_FCHMOD if (fchmod(ofd, omode)) #else /* HAVE_FCHMOD */ - if (chmod(np, omode)) + if (chmod(dest, omode)) #endif /* HAVE_FCHMOD */ run_err("%s: set mode: %s", - np, strerror(errno)); + dest, strerror(errno)); } else { if (!exists && omode != mode)...

...Olaf *** rsync-2.6.2/syscall.c.ORG_SC Fri Aug 13 13:17:27 2004 --- rsync-2.6.2/syscall.c Fri Aug 13 13:19:29 2004 *************** *** 152,158 **** RETURN_ERROR_IF(dry_run, 0); RETURN_ERROR_IF(read_only, EROFS); ! #if defined(HAVE_SECURE_MKSTEMP) && defined(HAVE_FCHMOD) { int fd = mkstemp(template); if (fd == -1) --- 152,160 ---- RETURN_ERROR_IF(dry_run, 0); RETURN_ERROR_IF(read_only, EROFS); ! ! /* AIX and hpux mkstemp is broken for LARGE_FILES */ ! #if defined(HAVE_SECURE_MKSTEMP) && de...

...ile is changed to a value which would deny access to that process. One situation where this could occur is on a stateless file system. This behavior will not occur in a conforming environment. I guess I have a non-conforming environment (I'm talking to a unfs3 server). If I remove HAVE_FCHMOD, it still doesn't work, because the call to open() includes the read-only permissions as well (a case I don't really see referenced in SUSv3 right off). The following patch makes sure that the user always has write permission to the temp file: diff -urN rsync-2.6.9-dist/syscall.c rsync-2....

...status = errno_to_portable(errno); } + #endif send_status(id, status); xfree(name); } *************** *** 591,600 **** status = SSH2_FX_FAILURE; } else { if (a->flags & SSH2_FILEXFER_ATTR_PERMISSIONS) { #ifdef HAVE_FCHMOD ! ret = fchmod(fd, a->perm & 0777); #else ! ret = chmod(name, a->perm & 0777); #endif if (ret == -1) status = errno_to_portable(errno); --- 615,629 ---- status = SSH...

...error("Couldn't write to \"%s\": %s", local_path, + strerror(write_errno)); + status = -1; + do_close(fd_in, fd_out, handle, handle_len); + } else { + status = do_close(fd_in, fd_out, handle, handle_len); + + /* Override umask and utimes if asked */ #ifdef HAVE_FCHMOD - if (pflag && fchmod(local_fd, mode) == -1) + if (pflag && fchmod(local_fd, mode) == -1) #else - if (pflag && chmod(local_path, mode) == -1) + if (pflag && chmod(local_path, mode) == -1) #endif /* HAVE_FCHMOD */ - error("Couldn't set mode on \"%s...

Known issues: 1) Linux 'sleep 20' -- Unfixable before 2.5.0 (known work around) 2) HP/UX signal issue -- Patched and HP/UX 11 works in v2 3) SCO 2/ Native Compiler -- Unfixable before 2.5.0 (known work around) 4) NeXTStep -- Resynced, MAX_GROUPS vs NGROUPS unresolved (not major) 5) DG/UX regcomp/regexec -- Fixed. 6) Cray signal issues -- ??? 7) Solaris '$PATH' issue -- ??

Folks, I've noticed poor performance using sftp. If anyone has any advice on how to improve performance, I'd like to hear it. Test simply involved transferring a single 143MB MP3 file using defaults for all the program configs. The opensshd 3.0.2p1 server is used in all tests. Software: openssh suite 3.0.2p1 psftp (putty sftp client) latest dev snapshot pscp (putty scp client) latest

...mp but forces permissions */ -int do_mkstemp(char *template, mode_t perms) +/* like mkstemp but force 0600 permissions */ +int do_mkstemp(char *template) { RETURN_ERROR_IF(dry_run, 0); RETURN_ERROR_IF(read_only, EROFS); @@ -155,21 +155,12 @@ #if defined(HAVE_SECURE_MKSTEMP) && defined(HAVE_FCHMOD) { int fd = mkstemp(template); - if (fd == -1) - return -1; - if (fchmod(fd, perms) != 0 && preserve_perms) { - int errno_save = errno; - close(fd); - unlink(template); - errno = errno_save; - return -1; - } return fd; } #else if (!mktemp(template)) return -1;...

...(fd < 0 || name == NULL) { status = SSH2_FX_FAILURE; } else { if (a->flags & SSH2_FILEXFER_ATTR_SIZE) { ret = ftruncate(fd, a->size); ! if (ret == -1) status = errno_to_portable(errno); } if (a->flags & SSH2_FILEXFER_ATTR_PERMISSIONS) { #ifdef HAVE_FCHMOD --- 725,744 ---- name = handle_to_name(handle); if (fd < 0 || name == NULL) { status = SSH2_FX_FAILURE; + #ifdef SFTP_LOGGING + log("(%d/%d/%s) Set file/dir stats failed - could not get name from handle: %d.", ppid, cuid, CUNAME, handle); + #endif } else { if (a->...

...HAVE_CHROOT HAVE_COMPILER_WILL_OPTIMIZE_OUT_FNS HAVE_CONNECT HAVE_CREAT64 HAVE_CRYPT HAVE_CUPS HAVE_DIRENT_D_OFF HAVE_DLCLOSE HAVE_DLERROR HAVE_DLOPEN HAVE_DLSYM HAVE_DUP2 HAVE_ENDNETGRENT HAVE_ERRNO_DECL HAVE_EXECL HAVE_EXPLICIT_LARGEFILE_SUPPORT HAVE_FCHMOD HAVE_FCHOWN HAVE_FCNTL_LOCK HAVE_FCVT HAVE_FOPEN64 HAVE_FSEEKO64 HAVE_FSTAT HAVE_FSTAT64 HAVE_FSYNC HAVE_FTELLO64 HAVE_FTRUNCATE HAVE_FTRUNCATE64 HAVE_FTRUNCATE_EXTEND HAVE_FUNCTION_MACRO HAVE_GETCWD HAVE_GETDENTS HAVE_GETGRENT HAVE_GETGRNAM HAV...

...HAVE_CHROOT HAVE_CLOSEDIR64 HAVE_COMPILER_WILL_OPTIMIZE_OUT_FNS HAVE_CONNECT HAVE_CREAT64 HAVE_CRYPT HAVE_DEV64_T HAVE_DLCLOSE HAVE_DLERROR HAVE_DLOPEN HAVE_DLSYM HAVE_DUP2 HAVE_ENDMNTENT HAVE_ENDNETGRENT HAVE_ERRNO_DECL HAVE_EXECL HAVE_EXPLICIT_LARGEFILE_SUPPORT HAVE_FCHMOD HAVE_FCHOWN HAVE_FCNTL_LOCK HAVE_FCVT HAVE_FOPEN64 HAVE_FSEEKO64 HAVE_FSTAT HAVE_FSTAT64 HAVE_FSYNC HAVE_FTELLO64 HAVE_FTRUNCATE HAVE_FTRUNCATE64 HAVE_FTRUNCATE_EXTEND HAVE_FUNCTION_MACRO HAVE_GETCWD HAVE_GETDIRENTRIES HAVE_GETGRENT HAVE_GETGRNAM HAVE_GETMNTENT...

...F HAVE_DECL_VASPRINTF HAVE_DECL_VSNPRINTF HAVE_DEVICE_MAJOR_FN HAVE_DEVICE_MINOR_FN HAVE_DIRENT_D_OFF HAVE_DLCLOSE HAVE_DLERROR HAVE_DLOPEN HAVE_DLSYM HAVE_DUP2 HAVE_ENDMNTENT HAVE_ENDNETGRENT HAVE_ERRNO_DECL HAVE_EXECL HAVE_EXPLICIT_LARGEFILE_SUPPORT HAVE_FCHMOD HAVE_FCHOWN HAVE_FCNTL_LOCK HAVE_FCVT HAVE_FGETXATTR HAVE_FLISTXATTR HAVE_FOPEN64 HAVE_FREMOVEXATTR HAVE_FSEEKO64 HAVE_FSETXATTR HAVE_FSID_INT HAVE_FSTAT HAVE_FSTAT64 HAVE_FSYNC HAVE_FTELLO64 HAVE_FTRUNCATE HAVE_FTRUNCATE64 HAVE_FTRUNCATE_EXTEND...

...HAVE_COPY_AUTHENTICATOR HAVE_CRYPT HAVE_DEVICE_MAJOR_FN HAVE_DEVICE_MINOR_FN HAVE_DLCLOSE HAVE_DLERROR HAVE_DLOPEN HAVE_DLSYM HAVE_DUP2 HAVE_ENCTYPE_ARCFOUR_HMAC_MD5 HAVE_ENDNETGRENT HAVE_ERRNO_DECL HAVE_EXECL HAVE_EXPLICIT_LARGEFILE_SUPPORT HAVE_FCHMOD HAVE_FCHOWN HAVE_FCNTL_LOCK HAVE_FSTAT HAVE_FSYNC HAVE_FTRUNCATE HAVE_FTRUNCATE_EXTEND HAVE_FUNCTION_MACRO HAVE_GETCWD HAVE_GETDENTS HAVE_GETDIRENTRIES HAVE_GETGRENT HAVE_GETGRNAM HAVE_GETGROUPLIST HAVE_GETNETGRENT HAVE_GETRLIMIT HAVE_...

...OUT_FNS HAVE_CONNECT HAVE_COPY_AUTHENTICATOR HAVE_CREAT64 HAVE_CRYPT HAVE_DIRENT_D_OFF HAVE_DLCLOSE HAVE_DLERROR HAVE_DLOPEN HAVE_DLSYM HAVE_DUP2 HAVE_ENCTYPE_ARCFOUR_HMAC_MD5 HAVE_ENDNETGRENT HAVE_ERRNO_DECL HAVE_EXECL HAVE_EXPLICIT_LARGEFILE_SUPPORT HAVE_FCHMOD HAVE_FCHOWN HAVE_FCNTL_LOCK HAVE_FCVT HAVE_FOPEN64 HAVE_FSEEKO64 HAVE_FSTAT HAVE_FSTAT64 HAVE_FSYNC HAVE_FTELLO64 HAVE_FTRUNCATE HAVE_FTRUNCATE64 HAVE_FTRUNCATE_EXTEND HAVE_FUNCTION_MACRO HAVE_GETCWD HAVE_GETDENTS HAVE_GETGRENT HAVE_GETGRNAM HAV...

...CT HAVE_CREAT64 HAVE_CRYPT HAVE_CUPS HAVE_DES_SET_KEY HAVE_DEVICE_MAJOR_FN HAVE_DEVICE_MINOR_FN HAVE_DIRENT_D_OFF HAVE_DLCLOSE HAVE_DLERROR HAVE_DLOPEN HAVE_DLSYM HAVE_DUP2 HAVE_ENDMNTENT HAVE_ENDNETGRENT HAVE_ERRNO_DECL HAVE_EXECL HAVE_EXPLICIT_LARGEFILE_SUPPORT HAVE_FCHMOD HAVE_FCHOWN HAVE_FCNTL_LOCK HAVE_FCVT HAVE_FGETXATTR HAVE_FLISTXATTR HAVE_FOPEN64 HAVE_FREMOVEXATTR HAVE_FSEEKO64 HAVE_FSETXATTR HAVE_FSTAT HAVE_FSTAT64 HAVE_FSYNC HAVE_FTELLO64 HAVE_FTRUNCATE HAVE_FTRUNCATE64 HAVE_FTRUNCATE_EXTEND HAVE_FUNCTION_MACRO HAVE_GETCWD...

...F HAVE_DECL_VSNPRINTF HAVE_DGETTEXT HAVE_DIRENT_D_OFF HAVE_DIRFD HAVE_DIRFD_DECL HAVE_DLCLOSE HAVE_DLERROR HAVE_DLOPEN HAVE_DLSYM HAVE_DUP2 HAVE_ENDMNTENT HAVE_ENDNETGRENT HAVE_ENVIRON_DECL HAVE_EPOLL HAVE_EPOLL_CREATE HAVE_ERRNO_DECL HAVE_EXECL HAVE_FCHMOD HAVE_FCHOWN HAVE_FCVT HAVE_FDATASYNC HAVE_FGETXATTR HAVE_FLISTXATTR HAVE_FOPEN64 HAVE_FREEADDRINFO HAVE_FREEIFADDRS HAVE_FREMOVEXATTR HAVE_FRSIZE HAVE_FSEEKO64 HAVE_FSETXATTR HAVE_FSID_INT HAVE_FSTAT64 HAVE_FSYNC HAVE_FTELLO64 HAVE_FTRUNCATE HAV...

..._TIME_H 1 #define HAVE_UTIME_H 1 #define HAVE_UTMP_H 1 #define HAVE_UTMPX_H 1 #define HAVE_LIBNSL 1 #define HAVE_LIBSOCKET 1 #define HAVE_LIBZ 1 #define HAVE_UPDWTMP 1 #define HAVE_STRFTIME 1 #define BROKEN_ONE_BYTE_DIRENT_D_NAME 1 #define LIBWRAP 1 #define HAVE_BCOPY 1 #define HAVE_CLOCK 1 #define HAVE_FCHMOD 1 #define HAVE_FCHOWN 1 #define HAVE_FREEADDRINFO 1 #define HAVE_GAI_STRERROR 1 #define HAVE_GETADDRINFO 1 #define HAVE_GETCWD 1 #define HAVE_GETNAMEINFO 1 #define HAVE_GETOPT 1 #define HAVE_GETRLIMIT 1 #define HAVE_GETRUSAGE 1 #define HAVE_GLOB 1 #define HAVE_INET_NTOA 1 #define HAVE_INET_NTOP 1 #...