search for: hasstoretostackslot

...turn false. + /// Unlike isLoadFromStackSlot, this returns true for any + /// instructions that loads from the stack. This comment is contradictory. It returns true if it is a "direct load" but "returns true for any instructions that loads". likewise with the comment on hasStoreToStackSlot. Would it make sense for the default impl of hasLoadFromStackSlot to be isLoadFromStackSlot? It might be worthwhile to say that this is a "best effort" method. It is not guaranteed to return true for all instructions of the form, it is just a hint. A couple of the methods you...

Attached is a patch to print asm comments for spill information. We've discussed the mechanisms before but I wanted to run the patch by everyone before I start to commit pieces. -Dave -------------- next part -------------- A non-text attachment was scrubbed... Name: spillcomments.patch Type: text/x-diff Size: 58930 bytes Desc: not available URL:

...is returns true for any > + /// instructions that loads from the stack. > > This comment is contradictory. It returns true if it is a "direct > load" but "returns true for any instructions that loads". likewise Cut & paste error. :) > with the comment on hasStoreToStackSlot. Would it make sense for the > default impl of hasLoadFromStackSlot to be isLoadFromStackSlot? Yeah, goo idea. > It might be worthwhile to say that this is a "best effort" method. It > is not guaranteed to return true for all instructions of the form, it > is just a hint....

Hi all, There's been a recent bootstrap failure that might be covered up because of another failure. I just wanted to point this out so that people can take a look: -bw Here's the failure from our buildbot: Assertion failed: (DestReg == VirtReg && "Unknown load situation!"), function RewriteMBB, file /Volumes/Sandbox/Buildbot/llvm/build.llvm-