search for: hasrawtextsupport

It may be moot because Reed is currently rewriting the patch to avoid using EmitInlineAsm and EmitRawText but I wanted to question something here. I'm thinking that hasRawTextSupport() shouldn't be the condition used inside EmitInlineAsm. I think it would be more correct to have a useRawTextSupport() predicate that can return hasRawTextSupport() for (sub)targets that haven't implemented their MC layer, and false for those that have. What do you think? > -----Origina...

I would like to make the following member of AsmPrinter be protected void EmitInlineAsm(StringRef Str, const MDNode *LocMDNode = 0, InlineAsm::AsmDialect AsmDialect = InlineAsm::AD_ATT) const; I have some stubs that I want to emit in MipsAsmParser . Are there any objections to doing this? Reed

...aking emitInlineAsm protected On 31 January 2014 05:26, Daniel Sanders <Daniel.Sanders at imgtec.com> wrote: > It may be moot because Reed is currently rewriting the patch to avoid using EmitInlineAsm and EmitRawText but I wanted to question something here. > > I'm thinking that hasRawTextSupport() shouldn't be the condition used inside EmitInlineAsm. I think it would be more correct to have a useRawTextSupport() predicate that can return hasRawTextSupport() for (sub)targets that haven't implemented their MC layer, and false for those that have. What do you think? I generally agree...

...inter::EmitInstruction() somehow bypassing these completely? and also on EmitStartOfAsmFile(), it emits a bunch of text assembly attributes - which is clearly wrong for MC (but is still being used in the asm emission). Can anyone suggest a better mechanism to switch on this than using OutStreamer.hasRawTextSupport()? Thanks, -Jason

> Then I could call that method when I'm processing compiler generated stubs > that have inline > assembly. Sorry, I just think this is a way too slippery slope to be in. People already misunderstand and misuse hasRawTextSupport. Adding the ability to for llvm to know if an inline assembly is human written or machine generated would be a massive foot gun. Cheers, Rafael

...rks without adding a mode to asm >> printer >> but in general is harder >> for people to use since they have to get a hook to MCAsm in order to >> change the inline_asm_start/end >> strings. (In AsmPrinter) on a per function basis. >> >> if (OutStreamer.hasRawTextSupport() && >> MAI->getInlineAsmStart()[0]) >> OutStreamer.EmitRawText(Twine("\t")+MAI->getCommentString()+ >> MAI->getInlineAsmStart()); >> >> So a simple method in AsmPrinter would be the easiest for people...

...is clearly wrong for MC (but is still being used in > the asm emission). Since this is by definition only for .s file emission, why is this clearly wrong? Perhaps it is, but it's not obvious to me why. > Can anyone suggest a better mechanism to switch on this than using > OutStreamer.hasRawTextSupport()? > > Thanks, > > -Jason

...asm >>> printer >>> but in general is harder >>> for people to use since they have to get a hook to MCAsm in order to >>> change the inline_asm_start/end >>> strings. (In AsmPrinter) on a per function basis. >>> >>> if (OutStreamer.hasRawTextSupport() && >>> MAI->getInlineAsmStart()[0]) >>> OutStreamer.EmitRawText(Twine("\t")+MAI->getCommentString()+ >>> MAI->getInlineAsmStart()); >>> >>> So a simple method in AsmPrinter would be the...

(Sorry about the duplicate, I got the mailing list address incorrect the first time around). While working on the IAS, I ran into a behavioural difference between GCC and clang. The Linux Kernel relies on GCC's acceptance of inline assembly as an opaque object which will not have any validation performed on the content. The current behaviour in LLVM is to perform validation of the contents

...ea of what is best practices. The following kind of patch works without adding a mode to asm printer but in general is harder for people to use since they have to get a hook to MCAsm in order to change the inline_asm_start/end strings. (In AsmPrinter) on a per function basis. if (OutStreamer.hasRawTextSupport() && MAI->getInlineAsmStart()[0]) OutStreamer.EmitRawText(Twine("\t")+MAI->getCommentString()+ MAI->getInlineAsmStart()); So a simple method in AsmPrinter would be the easiest for people to use. It just turns off the APP/NOAPP markers w...

...>>>> but in general is harder >>>> for people to use since they have to get a hook to MCAsm in order to >>>> change the inline_asm_start/end >>>> strings. (In AsmPrinter) on a per function basis. >>>> >>>> if (OutStreamer.hasRawTextSupport() && >>>> MAI->getInlineAsmStart()[0]) >>>> OutStreamer.EmitRawText(Twine("\t")+MAI->getCommentString()+ >>>> MAI->getInlineAsmStart()); >>>> >>>> So a simple method in...

...e following kind of patch works without adding a mode to asm > printer > but in general is harder > for people to use since they have to get a hook to MCAsm in order to > change the inline_asm_start/end > strings. (In AsmPrinter) on a per function basis. > > if (OutStreamer.hasRawTextSupport() && > MAI->getInlineAsmStart()[0]) > OutStreamer.EmitRawText(Twine("\t")+MAI->getCommentString()+ > MAI->getInlineAsmStart()); > > So a simple method in AsmPrinter would be the easiest for people to > use. > &gt...

...Printer(TM, Streamer) > +{ > + const AMDGPUSubtarget &STM = TM.getSubtarget<AMDGPUSubtarget>(); > + > + DisasmEnabled = STM.dumpCode() && > + STM.getGeneration() > AMDGPUSubtarget::NORTHERN_ISLANDS && > + ! Streamer.hasRawTextSupport(); > +} > + > /// We need to override this function so we can avoid > /// the call to EmitFunctionHeader(), which the MCPureStreamer can't handle. > bool AMDGPUAsmPrinter::runOnMachineFunction(MachineFunction &MF) { > - const AMDGPUSubtarget &STM = TM.getSubtarget&...

On 05/06/2013 08:51 AM, Rafael Espíndola wrote: >> It's working fine just that it's ugly to see those APP/NOAPP markers. > Inline assembly is inline assembly. It has the semantics defined in > the IL documentation and should all be treated uniformly. > > I guess I would be OK with unconditionally removing those comments (I > don't see a lot of value in them) or

Hi, This patch adds R600/SI disassembly text to compiled object files, when a code dump is requested, to assist debugging in Mesa clients. Here's an example of the output in a Mesa client with a corresponding patch and RADEON_DUMP_SHADERS set: Shader Disassembly: S_WQM_B64 EXEC, EXEC ; BEFE0A7E S_MOV_B32 M0, SGPR6 ; BEFC0306

...t in general is harder >>>>> for people to use since they have to get a hook to MCAsm in order to >>>>> change the inline_asm_start/end >>>>> strings. (In AsmPrinter) on a per function basis. >>>>> >>>>> if (OutStreamer.hasRawTextSupport() && >>>>> MAI->getInlineAsmStart()[0]) >>>>> OutStreamer.EmitRawText(Twine("\t")+MAI->getCommentString()+ >>>>> MAI->getInlineAsmStart()); >>>>> >>>>> So...

...ality as the attribute emitter in this patch. Yet another option is adding a method for writing over old data in the streamer API. *) I added support for multiple vendors, but that is not used. I can remove if you want. *) Using virtual methods might be too much. Let me know if you like OutStreamer.hasRawTextSupport better. Using the class has the advantage of having only one cast to MCObjectStreamer. Cheers, Rafael -------------- next part -------------- A non-text attachment was scrubbed... Name: attrs.patch Type: text/x-patch Size: 13434 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/ll...

...const; >> >> I have some stubs that I want to emit in MipsAsmParser . > You mean Printer? There is no such a thing as inline asm in a .s file. > >> Are there any objections to doing this? > Probably. EmitInilneAsm is the only case I know that has a reasonable > use of hasRawTextSupport in order for it to work on targets without an > asm parser. Exposing it exposes a way for targets avoid the MC layer. > > Cheers, > Rafael So how do I create stubs? I have specific function stubs that I want to create. There is no direct object emitter for mips16 at this time. Reed

On 6 May 2013 10:29, reed kotler <rkotler at mips.com> wrote: > I want to disable the #APP/#NOAPP for compiler generated inline asm. > > Unfortunately, you can change the string APP,NOAPP, but it still will put > the "#" there and create > a line. > > In the comments it said that the strings were #APP,#NOAPP but really it's > just the part after the >

I want to disable the #APP/#NOAPP for compiler generated inline asm. Unfortunately, you can change the string APP,NOAPP, but it still will put the "#" there and create a line. In the comments it said that the strings were #APP,#NOAPP but really it's just the part after the comment_string=='#' I'd like to just add a mode flag to AsmPrinter for this. Any objections?