search for: hasmodulebeenadded

...9;m not sure about FindFunctionNamed: In addition to searching finalized modules, should it search Added and Loaded modules? If it finds a Function in these, should it compile and finalize it before returning the Function* ? I modified the implementation assert to test for ownsModule. However, the hasModuleBeenAdded functionality is required to avoid duplicate search in getPointerToFunction. As you note the name is wrong, I renamed the function to hasModuleBeenAddedButNotLoaded and cleaned the logic at getPointerToFunction() to minimize searches for all cases. pop_back() vs. clear() - since I knew there is o...

...tions of the FindFunctionNamed and runStaticConstructorsDestructors methods from ExecutionEngine which use the old Modules vector, so you'll need to override these in MCJIT. (The implementations are fairly trivial.) Beyond that I just have a couple of questions. First, OwningModuleContainer::hasModuleBeenAdded seems wrong. It seems to me that it should be equivalent to OwningModuleContain::ownsModule. That is, everything that has been loaded or finalized has also been added. Your implementation checks "has been added but not loaded" but it doesn't seem like that's necessary anywhere....

Hi Andy, Here is the patch. it incorporates: 1) your latest patch to SVN. 2) mcjit-module-state-optimization.patch. 3) the PtrSet changes. Other than the OwnedModules implementation there were other differences between 1) and 2), especially in the Finalize* functions, so please review that I got the right code. I got bitten by subtle bugs arising from MCJIT inheriting from EE: First, MCJIT