search for: has_data_valid

Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, fixing this by adding a hint (has_data_valid) and set it only on the receiving path. Cc: Rolf Neugebauer <rolf.neugebauer at docker.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/macvtap.c | 2 +- drivers/net/tun.c | 2 +- drivers/net/virtio_net.c | 2 +- include/linux/virtio_net.h | 6 ++...

Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, fixing this by adding a hint (has_data_valid) and set it only on the receiving path. Cc: Rolf Neugebauer <rolf.neugebauer at docker.com> Signed-off-by: Jason Wang <jasowang at redhat.com> --- drivers/net/macvtap.c | 2 +- drivers/net/tun.c | 2 +- drivers/net/virtio_net.c | 2 +- include/linux/virtio_net.h | 6 ++...

...ael S. Tsirkin wrote: > On Fri, Jan 20, 2017 at 02:32:42PM +0800, Jason Wang wrote: >> Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on >> xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, >> fixing this by adding a hint (has_data_valid) and set it only on the >> receiving path. >> >> Cc: Rolf Neugebauer<rolf.neugebauer at docker.com> >> Signed-off-by: Jason Wang<jasowang at redhat.com> >> --- >> drivers/net/macvtap.c | 2 +- >> drivers/net/tun.c | 2 +- >&gt...

...ael S. Tsirkin wrote: > On Fri, Jan 20, 2017 at 02:32:42PM +0800, Jason Wang wrote: >> Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on >> xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, >> fixing this by adding a hint (has_data_valid) and set it only on the >> receiving path. >> >> Cc: Rolf Neugebauer<rolf.neugebauer at docker.com> >> Signed-off-by: Jason Wang<jasowang at redhat.com> >> --- >> drivers/net/macvtap.c | 2 +- >> drivers/net/tun.c | 2 +- >&gt...

On Fri, Jan 20, 2017 at 02:32:42PM +0800, Jason Wang wrote: > Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on > xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, > fixing this by adding a hint (has_data_valid) and set it only on the > receiving path. > > Cc: Rolf Neugebauer <rolf.neugebauer at docker.com> > Signed-off-by: Jason Wang <jasowang at redhat.com> > --- > drivers/net/macvtap.c | 2 +- > drivers/net/tun.c | 2 +- > drivers/net/virtio_net.c |...

...gt; > On Fri, Jan 20, 2017 at 02:32:42PM +0800, Jason Wang wrote: > > > Commit 501db511397f ("virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on > > > xmit") in fact disables VIRTIO_HDR_F_DATA_VALID on receiving path too, > > > fixing this by adding a hint (has_data_valid) and set it only on the > > > receiving path. > > > > > > Cc: Rolf Neugebauer<rolf.neugebauer at docker.com> > > > Signed-off-by: Jason Wang<jasowang at redhat.com> > > > --- > > > drivers/net/macvtap.c | 2 +- > > >...

...+94,9 @@ static inline int virtio_net_hdr_from_skb(const struct sk_buff *skb, skb_checksum_start_offset(skb)); hdr->csum_offset = __cpu_to_virtio16(little_endian, skb->csum_offset); + + if (skb->csum_not_inet) + hdr->flags |= VIRTIO_NET_HDR_F_CSUM_NOT_INET; } else if (has_data_valid && skb->ip_summed == CHECKSUM_UNNECESSARY) { hdr->flags = VIRTIO_NET_HDR_F_DATA_VALID; diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h index 5de6ed3..9dfca1a 100644 --- a/include/uapi/linux/virtio_net.h +++ b/include/uapi/linux/virtio_net.h @@ -...

Now that we have SCTP offload capabilities in the kernel, we can add them to virtio as well. First step is SCTP checksum. We need a new freature in virtio to negotiate this support since SCTP is excluded with the stardard checksum and requires a little bit extra. This series proposes VIRTIO_NET_F_SCTP_CSUM feature bit. As the "little bit extra", the kernel uses a new bit in the skb

Now that we have SCTP offload capabilities in the kernel, we can add them to virtio as well. First step is SCTP checksum. We need a new freature in virtio to negotiate this support since SCTP is excluded with the stardard checksum and requires a little bit extra. This series proposes VIRTIO_NET_F_SCTP_CSUM feature bit. As the "little bit extra", the kernel uses a new bit in the skb

...ecksum_start_offset(skb)); > > > hdr->csum_offset = __cpu_to_virtio16(little_endian, > > > skb->csum_offset); > > > + > > > + if (skb->csum_not_inet) > > > + hdr->flags |= VIRTIO_NET_HDR_F_CSUM_NOT_INET; > > > } else if (has_data_valid && > > > skb->ip_summed == CHECKSUM_UNNECESSARY) { > > > hdr->flags = VIRTIO_NET_HDR_F_DATA_VALID; > > > diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h > > > index 5de6ed3..9dfca1a 100644 > > > --- a...