search for: hang_limit

nouveau_sched_init() uses the function drm_sched_init(). The latter function has parameters called "hang_limit" and "timeout" in its API documentation. nouveau_sched_init(), however, defines a variable called "job_hang_limit" which is passed to drm_sched_init()'s "timeout" parameter. The actual "hang_limit" parameter is directly set to 0. Define a new varia...

...adev->reset_domain->wq, - ring->sched_score, ring->name, - adev->dev); + params.ops = &amdgpu_sched_ops; + params.submit_wq = NULL; /* Use the system_wq. */ + params.num_rqs = DRM_SCHED_PRIORITY_COUNT; + params.credit_limit = ring->num_hw_submission; + params.hang_limit = 0; + params.timeout = timeout; + params.timeout_wq = adev->reset_domain->wq; + params.score = ring->sched_score; + params.name = ring->name; + params.dev = adev->dev; + + r = drm_sched_init(&ring->sched, &params); if (r) { DRM_ERROR("Failed to create sc...

nouveau_sched_init() uses the function drm_sched_init(). The latter function has parameters called "hang_limit" and "timeout" in its API documentation. nouveau_sched_init(), however, defines a variable called "job_hang_limit" which is passed to drm_sched_init()'s "timeout" parameter. The actual "hang_limit" parameter is directly set to 0. Rename "job_h...

...tually, you can even make it const if it's not modified after the declaration. > > .ops = &panthor_queue_sched_ops, > > .submit_wq = group->ptdev->scheduler->wq, > > .num_rqs = 1, > > .credit_limit = args->ringbuf_size / sizeof(u64), > > .hang_limit = 0, > > .timeout = msecs_to_jiffies(JOB_TIMEOUT_MS), > > .timeout_wq = group->ptdev->reset.wq, > > .name = "panthor-queue", > > .dev = group->ptdev->base.dev, > > }; > > +1 on this as a general approach for the whole ser...

...if it's not modified after the > declaration. > > > > .ops = &panthor_queue_sched_ops, > > > .submit_wq = group->ptdev->scheduler->wq, > > > .num_rqs = 1, > > > .credit_limit = args->ringbuf_size / sizeof(u64), > > > .hang_limit = 0, > > > .timeout = msecs_to_jiffies(JOB_TIMEOUT_MS), > > > .timeout_wq = group->ptdev->reset.wq, > > > .name = "panthor-queue", > > > .dev = group->ptdev->base.dev, > > > }; > > +2 Matt > > +1 o...

...t;>>>> drm_sched_init_params)); >>>>> + >>>>> + params->submit_wq = NULL; /* Use the system_wq. */ >>>>> + params->num_rqs = DRM_SCHED_PRIORITY_COUNT; >>>>> + params->credit_limit = 1; >>>>> + params->hang_limit = 0; >>>>> + params->timeout = msecs_to_jiffies(500); >>>>> + params->timeout_wq = NULL; /* Use the system_wq. */ >>>>> + params->score = NULL; >>>>> + params->dev = dev; >>>>> +} >>>> >>>&gt...

...gt; device *dev) > > +{ > > + memset(params, 0, sizeof(struct drm_sched_init_params)); > > + > > + params->submit_wq = NULL; /* Use the system_wq. */ > > + params->num_rqs = DRM_SCHED_PRIORITY_COUNT; > > + params->credit_limit = 1; > > + params->hang_limit = 0; > > + params->timeout = msecs_to_jiffies(500); > > + params->timeout_wq = NULL; /* Use the system_wq. */ > > + params->score = NULL; > > + params->dev = dev; > > +} > > Could we use only one function that takes struct v3d_dev *v3d, enum > v3d...

...r <phasta at kernel.org> wrote: > > > > > ?int drm_sched_init(struct drm_gpu_scheduler *sched, > > > - ?? const struct drm_sched_backend_ops *ops, > > > - ?? struct workqueue_struct *submit_wq, > > > - ?? u32 num_rqs, u32 credit_limit, unsigned int hang_limit, > > > - ?? long timeout, struct workqueue_struct *timeout_wq, > > > - ?? atomic_t *score, const char *name, struct device *dev); > > > + const struct drm_sched_init_params *params); > > > > > > Another nit: indenting is messed up here. > >...

...ner <phasta at kernel.org> wrote: > > > > > ?int drm_sched_init(struct drm_gpu_scheduler *sched, > > > - ?? const struct drm_sched_backend_ops *ops, > > > - ?? struct workqueue_struct *submit_wq, > > > - ?? u32 num_rqs, u32 credit_limit, unsigned int hang_limit, > > > - ?? long timeout, struct workqueue_struct *timeout_wq, > > > - ?? atomic_t *score, const char *name, struct device *dev); > > > + const struct drm_sched_init_params *params); > > > > > > Another nit: indenting is messed up here. > > That...

...> > > > > > > ?int drm_sched_init(struct drm_gpu_scheduler *sched, > > > > > - ?? const struct drm_sched_backend_ops *ops, > > > > > - ?? struct workqueue_struct *submit_wq, > > > > > - ?? u32 num_rqs, u32 credit_limit, unsigned int hang_limit, > > > > > - ?? long timeout, struct workqueue_struct *timeout_wq, > > > > > - ?? atomic_t *score, const char *name, struct device *dev); > > > > > + const struct drm_sched_init_params *params); > > > > > > > > > > > &g...

...drm_sched_init_params *params, struct device *dev) > +{ > + memset(params, 0, sizeof(struct drm_sched_init_params)); > + > + params->submit_wq = NULL; /* Use the system_wq. */ > + params->num_rqs = DRM_SCHED_PRIORITY_COUNT; > + params->credit_limit = 1; > + params->hang_limit = 0; > + params->timeout = msecs_to_jiffies(500); > + params->timeout_wq = NULL; /* Use the system_wq. */ > + params->score = NULL; > + params->dev = dev; > +} Could we use only one function that takes struct v3d_dev *v3d, enum v3d_queue, and sched_ops as arguments (inst...