search for: handler_context

...+/* @UNSAFE: whole file */ + +#include "lib.h" +#include "ioloop-internal.h" + +#ifdef IOLOOP_KQUEUE + +#include <sys/types.h> +#include <sys/event.h> +#include <sys/time.h> + +#ifndef INITIAL_BUF_SIZE +# define INITIAL_BUF_SIZE 128 +#endif + + +struct ioloop_handler_context { + int kq; + size_t evbuf_size; + struct kevent *evbuf; + + size_t fds_size; + struct fdrecord *fds; +}; + +struct fdrecord { + /* IO_READ | IO_WRITE | IO_ERROR */ + unsigned char mode : 3; +}; + + +void io_loop_handler_init(struct ioloop *ioloop) +...

...op-select.c: --- dovecot-1.0.alpha4/src/lib/ioloop-select.c.orig 2005-11-06 22:06:53.000000000 -0800 +++ dovecot-1.0.alpha4/src/lib/ioloop-select.c 2005-11-06 22:07:13.000000000 -0 800 @@ -113,7 +113,7 @@ sizeof(fd_set)); memcpy(&tmp_write_fds, &ioloop->handler_context->write_fds, sizeof(fd_set)); - memcpy(&tmp_except_fds, &ioloop->handler_data->except_fds, + memcpy(&tmp_except_fds, &ioloop->handler_context->except_fds, sizeof(fd_set)); ret = select(ioloop->handler_context->...

....cvut.cz> * @@ -16,6 +16,7 @@ #ifdef IOLOOP_KQUEUE +#include <unistd.h> #include <sys/types.h> #include <sys/event.h> #include <sys/time.h> @@ -24,6 +25,8 @@ # define INITIAL_BUF_SIZE 128 #endif +#define MASK (IO_READ | IO_WRITE | IO_ERROR) + struct ioloop_handler_context { int kq; size_t evbuf_size; @@ -57,6 +60,7 @@ void io_loop_handler_init(struct ioloop void io_loop_handler_deinit(struct ioloop *ioloop) { + close(ioloop->handler_context->kq); p_free(ioloop->pool, ioloop->handler_context->evbuf); p_fr...

...argument of 'unary *' signal_x86_64.c: At top level: signal_x86_64.c:229: warning: return type defaults to 'int' signal_x86_64.c: In function 'HANDLER_DEF': signal_x86_64.c:233: warning: implicit declaration of function 'save_context' signal_x86_64.c:233: error: 'HANDLER_CONTEXT' undeclared (first use in this function) signal_x86_64.c:240: warning: implicit declaration of function 'TRAP_sig' signal_x86_64.c:257: warning: implicit declaration of function 'ERROR_sig' signal_x86_64.c:272: warning: format '%ld' expects type 'long int', but a...

The attached patch should fix the problem with dying imap on "Unrecognized event". The problem is that when we register a handle for IO_ERROR only, we still can get readable/writable event without EV_EOF being set. This case was not handled. -- Vaclav Haisman -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: io-kq.diff URL:

...= 22 > (gdb) p ret > $2 = -1 > (gdb) p *ioloop > $3 = {prev = 0x801c21080, cur_ctx = 0x0, io_files = 0x801c4f980, > next_io_file = 0x0, timeouts = 0x801c19e60, timeouts_new = {arr = {buffer = > 0x801c5ac80, element_size = 8}, v = 0x801c5ac80, > v_modifiable = 0x801c5ac80}, handler_context = 0x801c19e80, > notify_handler_context = 0x0, max_fd_count = 0, time_moved_callback = > 0x800d53bb0 <mail_storage_service_time_moved>, > next_max_time = 1477240784, ioloop_wait_usecs = 29863, io_pending_count = > 1, running = 1, iolooping = 1} > (gdb) p *ctx > $4 = {kq =...

grrr. /home/mrm $ gdb /usr/local/bin/doveadm GNU gdb 6.1.1 [FreeBSD] Copyright 2004 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for

...; (gdb) p ret > $3 = -1 > (gdb) p *ioloop > $4 = {prev = 0x801c21080, cur_ctx = 0x0, io_files = 0x801c4f980, > next_io_file = 0x0, timeouts = 0x801d17540, timeouts_new = {arr = { > buffer = 0x801cd9700, element_size = 8}, v = 0x801cd9700, > v_modifiable = 0x801cd9700}, handler_context = 0x801d17560, > notify_handler_context = 0x0, max_fd_count = 0, > time_moved_callback = 0x800d53bb0 <mail_storage_service_time_moved>, > next_max_time = 1477257580, ioloop_wait_usecs = 27148, io_pending_count = > 1, > running = 1, iolooping = 1} > (gdb) p* ctx >...

...74829380, sc_edx = 4583424, sc_ecx = 3117568, sc_eax = 14, sc_trapno = 14, sc_err = 4, sc_eip = 1074344288, sc_cs = 35, __csh = 0, sc_eflags = 66050, esp_at_signal = 1078935700, sc_ss = 43, __ssh = 0, i387 = 0, oldmask = 0, cr2 = 4583436}) at signal_i386.c:882 882 get_cr2_value(HANDLER_CONTEXT), get_error_code(HANDLER_CONTEXT) ); (gdb) up #3 <signal handler called> (gdb) up #4 find_entry_by_id (dir=0x45f000, id=14, root=0x45f000) at pe_resource.c:83 83 min = dir->NumberOfNamedEntries; (gdb) That's what I thought in the first place. I'll try to print out di...

..._context *) 0x0 (gdb) up #12 0x00079718 in io_loop_handler_run (ioloop=0xb1b40) at ioloop-poll.c:203 203 io->callback(io->context); (gdb) print *ioloop $10 = {prev = 0x0, pool = 0x1, ios = 0xaf4d8, notifys = 0xb1bd8, next_io = 0xb1d08, timeouts = 0xb1570, handler_context = 0x0, notify_handler_context = 0xb5dc0, running = 0} (gdb) up #13 0x00078f94 in io_loop_run (ioloop=0xaf440) at ioloop.c:274 274 io_loop_handler_run(ioloop); (gdb) print *ioloop $11 = {prev = 0x0, pool = 0xa62cc, ios = 0xaf4d8, notifys = 0x0, next_io = 0xaf4b8, timeouts = 0...

...45872000} (gdb) p errno $2 = 22 (gdb) p ret $3 = -1 (gdb) p *ioloop $4 = {prev = 0x801c21080, cur_ctx = 0x0, io_files = 0x801c4f980, next_io_file = 0x0, timeouts = 0x801d17540, timeouts_new = {arr = { buffer = 0x801cd9700, element_size = 8}, v = 0x801cd9700, v_modifiable = 0x801cd9700}, handler_context = 0x801d17560, notify_handler_context = 0x0, max_fd_count = 0, time_moved_callback = 0x800d53bb0 <mail_storage_service_time_moved>, next_max_time = 1477257580, ioloop_wait_usecs = 27148, io_pending_count = 1, running = 1, iolooping = 1} (gdb) p* ctx $5 = {kq = 21, deleted_count = 0, e...

...vent(): %m"); (gdb) p errno $1 = 22 (gdb) p ret $2 = -1 (gdb) p *ioloop $3 = {prev = 0x801c21080, cur_ctx = 0x0, io_files = 0x801c4f980, next_io_file = 0x0, timeouts = 0x801c19e60, timeouts_new = {arr = {buffer = 0x801c5ac80, element_size = 8}, v = 0x801c5ac80, v_modifiable = 0x801c5ac80}, handler_context = 0x801c19e80, notify_handler_context = 0x0, max_fd_count = 0, time_moved_callback = 0x800d53bb0 <mail_storage_service_time_moved>, next_max_time = 1477240784, ioloop_wait_usecs = 29863, io_pending_count = 1, running = 1, iolooping = 1} (gdb) p *ctx $4 = {kq = 22, deleted_count = 0, events...

...3 = -1 >> (gdb) p *ioloop >> $4 = {prev = 0x801c21080, cur_ctx = 0x0, io_files = 0x801c4f980, >> next_io_file = 0x0, timeouts = 0x801d17540, timeouts_new = {arr = { >> buffer = 0x801cd9700, element_size = 8}, v = 0x801cd9700, >> v_modifiable = 0x801cd9700}, handler_context = 0x801d17560, >> notify_handler_context = 0x0, max_fd_count = 0, >> time_moved_callback = 0x800d53bb0 <mail_storage_service_time_moved>, >> next_max_time = 1477257580, ioloop_wait_usecs = 27148, io_pending_count = >> 1, >> running = 1, iolooping = 1} &gt...

...(gdb) p *ioloop >>> $4 = {prev = 0x801c21080, cur_ctx = 0x0, io_files = 0x801c4f980, >>> next_io_file = 0x0, timeouts = 0x801d17540, timeouts_new = {arr = { >>> buffer = 0x801cd9700, element_size = 8}, v = 0x801cd9700, >>> v_modifiable = 0x801cd9700}, handler_context = 0x801d17560, >>> notify_handler_context = 0x0, max_fd_count = 0, >>> time_moved_callback = 0x800d53bb0 <mail_storage_service_time_moved>, >>> next_max_time = 1477257580, ioloop_wait_usecs = 27148, io_pending_count = >>> 1, >>> running = 1...

...client *) 0x334100 #7 0x0000000000116a04 in idle_client_input (ctx=0x3380b0) at cmd-idle.c:90 client = (struct client *) 0x334100 line = 0x33a075 "DONE" #8 0x00000000001ea2ac in io_loop_handler_run (ioloop=0x320080) at ioloop-kqueue.c:149 ctx = (struct ioloop_handler_context *) 0x32e080 events = (struct kevent *) 0x332000 event = (const struct kevent *) 0x332000 tv = {tv_sec = 0, tv_usec = 999441} ts = {tv_sec = 0, tv_nsec = 999441000} io = (struct io_file *) 0x320a80 events_count = 4 t_id = 2 msecs = 1000...

...>>> $4 = {prev = 0x801c21080, cur_ctx = 0x0, io_files = 0x801c4f980, > >>> next_io_file = 0x0, timeouts = 0x801d17540, timeouts_new = {arr = { > >>> buffer = 0x801cd9700, element_size = 8}, v = 0x801cd9700, > >>> v_modifiable = 0x801cd9700}, handler_context = 0x801d17560, > >>> notify_handler_context = 0x0, max_fd_count = 0, > >>> time_moved_callback = 0x800d53bb0 <mail_storage_service_time_moved>, > >>> next_max_time = 1477257580, ioloop_wait_usecs = 27148, > io_pending_count = > >>> 1, &...

>From the log: Jul 11 13:12:42 mproxy dovecot: imap-login: Login: user=<hildeb>, method=PLAIN, rip=141.42.206.36, lip=141.42.206.11, mpid=27254, TLS, session=<TGwoO1o3id+NKs4k> Jul 11 13:12:44 mproxy dovecot: imap(hildeb)<TGwoO1o3id+NKs4k>: Panic: file imap-client.c: line 854 (client_check_command_hangs): assertion failed: ((io_loop_find_fd_conditions(current_ioloop,