search for: handleaddedge

...☺ I continued to look into this with your viewpoint that a node that is conservatively allocatable should never be spilled. The first thing I did was therefore to add some extra code with an assert for this. I believe I then found three bugs and fixed the two: Bug 1: Incorrect transpositions in handleAddEdge() / hanldeRemoveEdge(). For the heuristic of DeniedOpts, if N runs along the columns (Transpose == true), the interesting dimension is along the rows, and vice versa. In other words, the question is what the neighbour could maximally deny N, and the answer is found in WorstRow, not WorstCol (as it...

...point that a node that is > conservatively allocatable should never be spilled. The first thing I did > was therefore to add some extra code with an assert for this. > > > > I believe I then found three bugs and fixed the two: > > > > Bug 1: Incorrect transpositions in handleAddEdge() / hanldeRemoveEdge(). > For the heuristic of DeniedOpts, if N runs along the columns (Transpose == > true), the interesting dimension is along the rows, and vice versa. In > other words, the question is what the neighbour could maximally deny N, and > the answer is found in WorstRow,...

> A node should never be put into the conservatively allocatable list if there is a chance of it spilling. I can understand why the logic of NodeMetadata::isConservativelyAllocatable is necessary for the node to be allocatable, but I have not been able to convince myself this is sufficient, especially when the node degree > available registers. Cheers, Arnaud From: