search for: handle_log_messag

...nn-socket.c > +++ b/src/conn-socket.c > @@ -33,6 +33,8 @@ > #include <assert.h> > #include <libintl.h> > > +#include "ignore-value.h" > + > #include "guestfs.h" > #include "guestfs-internal.h" > > @@ -314,6 +316,9 @@ handle_log_message (guestfs_h *g, > { > CLEANUP_FREE char *buf = safe_malloc (g, BUFSIZ); > ssize_t n; > + const char dsr_request[] = "\033[6n"; > + const char dsr_reply[] = "\033[24;80R"; > + const char dsr_reply_padding[] = "\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b&quot...

Hi, I attached the changes I made to a vanilla libguestfs-1.22.6 in order to make it work in mingw/win32. Added is also the patch required to make QEMU compatible (add a command to QMP that lists the supported devices (the regilat way you do it print it to stderr, which is difficult to redirect in win32)). This is done on behalf of Intel Corp. Thanks, Or (oberon in irc)

...onn-socket.c index 5b6b80e..14da260 100644 --- a/src/conn-socket.c +++ b/src/conn-socket.c @@ -33,6 +33,8 @@ #include <assert.h> #include <libintl.h> +#include "ignore-value.h" + #include "guestfs.h" #include "guestfs-internal.h" @@ -314,6 +316,9 @@ handle_log_message (guestfs_h *g, { CLEANUP_FREE char *buf = safe_malloc (g, BUFSIZ); ssize_t n; + const char dsr_request[] = "\033[6n"; + const char dsr_reply[] = "\033[24;80R"; + const char dsr_reply_padding[] = "\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b"; /* Carried over from a...

...onn-socket.c index 5b6b80e..13cb39b 100644 --- a/src/conn-socket.c +++ b/src/conn-socket.c @@ -33,6 +33,8 @@ #include <assert.h> #include <libintl.h> +#include "ignore-value.h" + #include "guestfs.h" #include "guestfs-internal.h" @@ -314,6 +316,9 @@ handle_log_message (guestfs_h *g, { CLEANUP_FREE char *buf = safe_malloc (g, BUFSIZ); ssize_t n; + const char dsr_request[] = "\033[6n"; + const char dsr_reply[] = "\033[24;80R"; + const char dsr_reply_padding[] = "\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b\b"; /* Carried over from a...

...quot;, > buf_len=47) > ? ? at events.c:117 > #6 ?0x00007ffff6e1702e in guestfs_int_log_message_callback > ? ? (g=g at entry=0xf31290, buf=0x113b8a0 "gs=0x0\r\ncommandrvf: udevadm --debug > settle -E \303by", len=len at entry=47) at proto.c:145 > #7 ?0x00007ffff6dfb759 in handle_log_message (g=g at entry=0xf31290, conn= > conn at entry=0x110e280) at conn-socket.c:395 > #8 ?0x00007ffff6dfbd63 in read_data (len=4, bufv=<optimized out>, connv= > <optimized out>, g=<optimized out>) at conn-socket.c:179 > #9 ?read_data (g=0xf31290, connv=0x110e280, bufv=<o...

...vadm --debug settle -E \303by", buf_len=47) at events.c:117 #6 0x00007ffff6e1702e in guestfs_int_log_message_callback (g=g at entry=0xf31290, buf=0x113b8a0 "gs=0x0\r\ncommandrvf: udevadm --debug settle -E \303by", len=len at entry=47) at proto.c:145 #7 0x00007ffff6dfb759 in handle_log_message (g=g at entry=0xf31290, conn=conn at entry=0x110e280) at conn-socket.c:395 #8 0x00007ffff6dfbd63 in read_data (len=4, bufv=<optimized out>, connv=<optimized out>, g=<optimized out>) at conn-socket.c:179 #9 read_data (g=0xf31290, connv=0x110e280, bufv=<optimized out>, len=...

...7f6dd168560e in guestfs_int_log_message_callback > ? ? (g=g at entry=0xae06f0, buf=0xd1dc90 "commandrvf: udevadm --debug settle -E /\ > 347\232\204\303 available\r\ned to rvf:e run ?in, ignor data av", len=len at entry > =43) > ? ? at proto.c:145 > #5 ?0x00007f6dd166ac29 in handle_log_message (g=g at entry=0xae06f0, conn= > conn at entry=0xd19570) at conn-socket.c:395 > #6 ?0x00007f6dd166b233 in read_data (len=4, bufv=<optimized out>, connv= > <optimized out>, g=<optimized out>) at conn-socket.c:179 > #7 ?read_data (g=0xae06f0, connv=0xd19570, bufv=<opt...

On Wed, Mar 23, 2016 at 10:39:43AM +0100, Pino Toscano wrote: > If I read this correctly, the newly added memmem would be executed for > every read data from the daemon socket: > read_data -> handle_log_message -> memmem I think only from the console socket (not the daemon socket, and hence not download APIs). However I will see if it's possible to limit this to the accept phase anyway, since that seems like a good idea. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redh...

I've been taking a long hard look at the protocol layer. It has evolved over a long time without any particular direction, and the result is, to say the least, not very organized. These patches take a first step at cleaning up the mess by abstracting out socket operations from the rest of the code. The purpose of this is to allow us to slot in a different connection layer under the

...s function is used internally when testing the appliance." }; { defaults with name = "copy_attributes"; added = (1, 25, 21); diff --git a/src/conn-socket.c b/src/conn-socket.c index 3ead48f..980d7df 100644 --- a/src/conn-socket.c +++ b/src/conn-socket.c @@ -343,26 +343,6 @@ handle_log_message (guestfs_h *g, /* It's an actual log message, send it upwards. */ guestfs_int_log_message_callback (g, buf, n); -#ifdef VALGRIND_DAEMON - /* Find the canary printed by appliance/init if valgrinding of the - * daemon fails, and exit abruptly. Note this is only used in - * develope...

Previously posted here: https://www.redhat.com/archives/libguestfs/2015-June/msg00266.html Rich.

Lots of changes since v2, too much to remember or summarize. Please ignore patch 11/11, it's just for my testing. Rich.

This set of patches fixes virt-rescue rather cleanly. In particular the problems with handling ^C are completely fixed. Work still to be done before this can go upstream: - Shutdown doesn't work properly if you exit the shell. At the moment to exit you must do 'reboot -f'. Future improvements: - An escape sequence and escape commands that could be handled by virt-rescue,

v4: - Lots more analysis of the /init script and other parts. - Display a list of the longest to shortest activities. - Rebase on top of current head. Rich.

This fixes the main issues in virt-rescue and is usable. There are some enhancements which could be made (in follow up work): - An escape sequence and escape commands that could be handled by virt-rescue, eg. to shut down the appliance, mount or unmount filesystems. - `virt-rescue -i' could be implemented cleanly by performing the right API calls before handing control to the

v1 was here: https://www.redhat.com/archives/libguestfs/2013-August/msg00005.html This now works, to some extent. The main problem now is that devices are named /dev/ubd[a-] which of course confuses everything. I'm thinking it may be easier to add a udev rule to rename them. Rich.

This is a User-Mode Linux backend for libguestfs. You can select it by doing: export LIBGUESTFS_BACKEND=uml export LIBGUESTFS_QEMU=/path/to/vmlinux Note we're reusing the 'qemu' variable in the handle for convenience. QEmu is not involved when using the UML backend. This almost works. UML itself crashes when the daemon tries to connect to the serial port. I suspect it's

Various changes/fixes to use smaller stack frames. Rich.

...md->outfd, buf, BUFSIZ); if (n > 0) { if (cmd->outbuf.add_data) cmd->outbuf.add_data (cmd, buf, n); diff --git a/src/conn-socket.c b/src/conn-socket.c index 05177ca..5b6b80e 100644 --- a/src/conn-socket.c +++ b/src/conn-socket.c @@ -312,7 +312,7 @@ static int handle_log_message (guestfs_h *g, struct connection_socket *conn) { - char buf[BUFSIZ]; + CLEANUP_FREE char *buf = safe_malloc (g, BUFSIZ); ssize_t n; /* Carried over from ancient proto.c code. The comment there was: @@ -329,7 +329,7 @@ handle_log_message (guestfs_h *g, */ usl...

This supersedes the two previous patch series: https://www.redhat.com/archives/libguestfs/2017-March/msg00017.html https://www.redhat.com/archives/libguestfs/2017-March/msg00046.html Rich.