search for: gzfile_close

...to do something, but > if packages are using it, things need to be changed carefully. I > can't just change it to raise an error instead. As you can see in the patch, no need to change close.connection() function but we have to add a test of con->status to all *_close() functions (gzfile_close() and co.) Serguei. >> >> Le 05/07/2017 ? 15:33, Serguei Sokol a ?crit : >>> Le 05/07/2017 ? 14:46, Serguei Sokol a ?crit : >>>> Le 05/07/2017 ? 13:09, Duncan Murdoch a ?crit : >>>>> On 05/07/2017 5:26 AM, January W. wrote: >>>>>>...

...ckages are using it, things need to be changed carefully. I >>> can't just change it to raise an error instead. >> As you can see in the patch, no need to change close.connection() function >> but we have to add a test of con->status to all *_close() functions >> (gzfile_close() and co.) > > You missed my point. Currently the R close() function may return -1 to signal that there was an error closing. We can't change that to an error if packages > are using it. May be I missed it but finally, me too, I was saying that we don't have to do so. Anyhow, th...

...alised value(s) ==13521== at 0x5D2740: longest_match (deflate.c:1121) ==13521== by 0x5D3BB6: deflate_slow (deflate.c:1595) ==13521== by 0x5D30EB: deflate (deflate.c:790) ==13521== by 0x5D4D21: do_flush (gzio.c:757) ==13521== by 0x5D4F39: gzclose (gzio.c:991) ==13521== by 0x44AC22: gzfile_close (connections.c:1035) ==13521== by 0x44A703: con_close1 (connections.c:2256) ==13521== by 0x44A742: con_close (connections.c:2283) ==13521== by 0x44D3A3: do_close (connections.c:2303) ==13521== by 0x4C43BB: do_internal (names.c:1089) ==13521== by 0x4978F5: Rf_eval (eval.c:398) ==13521...

...to be changed carefully. I >>>>> can't just change it to raise an error instead. >>>> As you can see in the patch, no need to change close.connection() function >>>> but we have to add a test of con->status to all *_close() functions >>>> (gzfile_close() and co.) >>> >>> You missed my point. Currently the R close() function may return -1 to signal that there was an error closing. We can't change that to an error if packages >>> are using it. >> May be I missed it but finally, me too, I was saying that we don...

...t >> if packages are using it, things need to be changed carefully. I >> can't just change it to raise an error instead. > As you can see in the patch, no need to change close.connection() function > but we have to add a test of con->status to all *_close() functions > (gzfile_close() and co.) You missed my point. Currently the R close() function may return -1 to signal that there was an error closing. We can't change that to an error if packages are using it. Duncan Murdoch > > Serguei. > >>> >>> Le 05/07/2017 ? 15:33, Serguei Sokol a ?cr...

...it, things need to be changed carefully. I >>>> can't just change it to raise an error instead. >>> As you can see in the patch, no need to change close.connection() function >>> but we have to add a test of con->status to all *_close() functions >>> (gzfile_close() and co.) >> >> You missed my point. Currently the R close() function may return -1 to signal that there was an error closing. We can't change that to an error if packages >> are using it. > May be I missed it but finally, me too, I was saying that we don't have to d...

I propose the following patch against the current R-devel/src/main/connection.c (cf. attached file). It gives (on my linux box): > fc=file("/dev/full", "w") > write.csv("a", file=fc) Error in writeLines(paste(col.names, collapse = sep), file, sep = eol) : system call failure on writing > close(fc) Serguei. Le 05/07/2017 ? 15:33, Serguei Sokol a ?crit