search for: gyf304

Eric: Yifan Gu has posted a few patches for mingw support. My comments below. https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca * I think the SHARED_LDFLAGS idea is good. I pushed a slightly different take on the idea here: https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6312400525cc8 It's slightly different from what Yifan posted abov...

On Tue, Mar 24, 2020 at 01:43:52PM -0500, Eric Blake wrote: > On 3/21/20 7:06 AM, Richard W.M. Jones wrote: > >Eric: > > > >Yifan Gu has posted a few patches for mingw support. My comments > >below. > > > >https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca > > > >* I think the SHARED_LDFLAGS idea is good. I pushed a slightly > > different take on the idea here: > > https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6312400525cc8 > > It'...

I pushed a few of the msys2 patches upstream. I changed the way that $(SHARED_LDFLAGS) works so it's more to my liking, and the others were pushed unchanged. Three patches remain which I'm posting on the mailing list for proper review. Rich.

...headers if Windows is detected, so it will cause a compile time error if someone attempts to use it. On Sat, Mar 21, 2020 at 1:20 PM Richard W.M. Jones <rjones@redhat.com> wrote: > On Sat, Mar 21, 2020 at 12:06:15PM +0000, Richard W.M. Jones wrote: > > > https://github.com/gyf304/nbdkit/commit/20d888fbb8ccf33f0975a070df0d8e3d929b71f8 > > > > * Is there no way to get the socket peer on Windows? > > And assuming there's no way to get the socket peer, then the function > shouldn't be NULL (which will cause a segfault), but instead you > should m...

On Mon, Mar 23, 2020 at 12:28:12PM +0000, Richard W.M. Jones wrote: > From: Yifan Gu <gyf304@gmail.com> > > The create_nbdkit_module function is intended to be exported, therefore > the static keyword is not needed and prevents building on MSYS2. > --- > plugins/python/python.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/plugins/py...

On Sat, Mar 21, 2020 at 12:06:15PM +0000, Richard W.M. Jones wrote: > https://github.com/gyf304/nbdkit/commit/20d888fbb8ccf33f0975a070df0d8e3d929b71f8 > > * Is there no way to get the socket peer on Windows? And assuming there's no way to get the socket peer, then the function shouldn't be NULL (which will cause a segfault), but instead you should make the function return an e...

From: Yifan Gu <gyf304@gmail.com> The create_nbdkit_module function is intended to be exported, therefore the static keyword is not needed and prevents building on MSYS2. --- plugins/python/python.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/python/python.c b/plugins/python/python.c...

On 3/21/20 7:06 AM, Richard W.M. Jones wrote: > Eric: > > Yifan Gu has posted a few patches for mingw support. My comments > below. > > https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca > > * I think the SHARED_LDFLAGS idea is good. I pushed a slightly > different take on the idea here: > https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6312400525cc8 > It's slightly different...

...te: > On Tue, Mar 24, 2020 at 01:43:52PM -0500, Eric Blake wrote: >> On 3/21/20 7:06 AM, Richard W.M. Jones wrote: >>> Eric: >>> >>> Yifan Gu has posted a few patches for mingw support. My comments >>> below. >>> >>> https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca >>> >>> * I think the SHARED_LDFLAGS idea is good. I pushed a slightly >>> different take on the idea here: >>> https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6312400525cc8 >...

...2PM -0500, Eric Blake wrote: > >> On 3/21/20 7:06 AM, Richard W.M. Jones wrote: > >>> Eric: > >>> > >>> Yifan Gu has posted a few patches for mingw support. My comments > >>> below. > >>> > >>> > https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca > >>> > >>> * I think the SHARED_LDFLAGS idea is good. I pushed a slightly > >>> different take on the idea here: > >>> > https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec4...

From: Yifan Gu <gyf304@gmail.com> Windows PE DLL needs function indirection, this patch injects API functions for plugins / filters if on Windows. Note that nbdkit_peer_name is explicitly disabled due to potential ABI incompatibilities. --- server/main.c | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 f...

...1]: Leaving directory '/c/Users/yifangu/Documents/devel/nbdkit' make: *** [Makefile:562: all] Error 2 On Mon, Mar 23, 2020 at 8:49 AM Richard W.M. Jones <rjones@redhat.com> wrote: > On Mon, Mar 23, 2020 at 12:28:12PM +0000, Richard W.M. Jones wrote: > > From: Yifan Gu <gyf304@gmail.com> > > > > The create_nbdkit_module function is intended to be exported, therefore > > the static keyword is not needed and prevents building on MSYS2. > > --- > > plugins/python/python.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >...

...at 01:43:52PM -0500, Eric Blake wrote: > >>On 3/21/20 7:06 AM, Richard W.M. Jones wrote: > >>>Eric: > >>> > >>>Yifan Gu has posted a few patches for mingw support. My comments > >>>below. > >>> > >>>https://github.com/gyf304/nbdkit/commit/a37c4ca6546dfc4e96e305af97b62e5a9d6174ca > >>> > >>>* I think the SHARED_LDFLAGS idea is good. I pushed a slightly > >>> different take on the idea here: > >>> https://github.com/libguestfs/nbdkit/commit/1d634009ab8e43592065ec469df6...

From: Yifan Gu <gyf304@gmail.com> This patch adds in indirection for API functions, as PE DLL loader does not resolve undefined symbols. This patch only includes header changes. --- include/nbdkit-common.h | 133 +++++++++++++++++++++++++++++++++++++++- include/nbdkit-compat.h | 97 +++++++++++++++++++++++++++++ i...

The patches following do indeed allow you to compile nbdkit.exe, but it does not actually work yet. I'm posting this experimental series more as a work in progress and to get feedback. Note this does not require Windows itself to build or test. You can cross-compile it using mingw64-* packages on Fedora or Debian, and test it [spoiler alert: it fails] using Wine. Rich.