search for: guestunmount

Hello everyone! I'm playing with guestunmount and got the following issues: 1) guestunmount never returns 3 (not mounted) - i guess it's a bug at guestunmount.c:223 2) I don't know whether it's a bug in guestunmount or fusermount, but on my machine while executing > guestmount > guestunmount > guestunmount on second...

Exit with 3 as return value when fusermount fails, because the specified mount point is not considered mounted for the user. This is in line with what the guestunmount documentation says. Adapt the test-guestunmount-fd test to the updated return value. Thanks to: Maxim Perevedentsev. --- fuse/guestunmount.c | 2 +- fuse/test-guestunmount-fd.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fuse/guestunmount.c b/fuse/guestun...

On 11/23/2015 07:59 PM, Pino Toscano wrote: > Hi, > > On Monday 23 November 2015 18:29:50 Maxim Perevedentsev wrote: >> 1) guestunmount never returns 3 (not mounted) - i guess it's a bug at >> guestunmount.c:223 > Indeed, thanks for the notice -- just send a patch for it. > >> 2) I don't know whether it's a bug in guestunmount or fusermount, but on >> my machine while executing >> > gu...

Since the first patch: - The program is now called 'guestunmount'. - I tested the --fd option and it appears to work. - You can now control retries / quiet. - Revised man pages. - Includes tests. I'm just running through the automated tests now. Rich.

On Tuesday 24 November 2015 12:57:17 Maxim Perevedentsev wrote: > On 11/23/2015 07:59 PM, Pino Toscano wrote: > > Hi, > > > > On Monday 23 November 2015 18:29:50 Maxim Perevedentsev wrote: > >> 1) guestunmount never returns 3 (not mounted) - i guess it's a bug at > >> guestunmount.c:223 > > Indeed, thanks for the notice -- just send a patch for it. > > > >> 2) I don't know whether it's a bug in guestunmount or fusermount, but on > >> my machine while exe...

...y are available via $PATH already. Followup of commit e85a976c5a474d751c6e8352370047a3177a7c45. --- cat/Makefile.am | 2 +- df/Makefile.am | 2 +- fuse/test-fuse-umount-race.sh | 4 ++-- fuse/test-guestmount-fd.c | 4 ++-- fuse/test-guestunmount-fd.c | 2 +- fuse/test-guestunmount-not-mounted.sh | 2 +- inspector/Makefile.am | 2 +- rescue/test-virt-rescue.pl | 2 +- sysprep/Makefile.am | 6 +++--- 9 files changed, 13 insertions(+), 13 deletions(-) diff --git a/cat/Makefile.am b/cat/M...

Hi, On Monday 23 November 2015 18:29:50 Maxim Perevedentsev wrote: > 1) guestunmount never returns 3 (not mounted) - i guess it's a bug at > guestunmount.c:223 Indeed, thanks for the notice -- just send a patch for it. > 2) I don't know whether it's a bug in guestunmount or fusermount, but on > my machine while executing > > guestmount > > gue...

On Thursday, 25 August 2016 13:15:29 CEST Richard W.M. Jones wrote: > Add new scripts for: > > - guestunmount > - virt-copy-in > - virt-copy-out > - virt-customize > - virt-dib > - virt-diff > - virt-get-kernel > - virt-p2v-make-disk > - virt-p2v-make-kickstart > - virt-p2v-make-kiwi > - virt-tar-in > - virt-tar-out > > Also combine the separate virt-resize script in...

...guestfish -a disk.qcow2 " >> run : >> mkmountpoint /hdd0 : >> mkmountpoint /hdd0/volume1 : >> ... : >> mount /dev/sda1 /hdd0/volume1 : >> ... : >> mount-local mnt/ : >> mount-local-run" >> >> kill -TERM `pidof guestfish` >> guestunmount mnt/ >> >> >> Is any of these options safe enough/preferred? Or, maybe, other options? >> I'd like to avoid guestfs API, threading and so on, and confine >> myself to command-line. > The mount-local APIs don't require threads, although they can use > them...

.../dev/sda1 mnt/hdd0/volume1 .... (Is it safe to use the same disk from multiple guestmounts?) 2) guestfish -a disk.qcow2 " run : mkmountpoint /hdd0 : mkmountpoint /hdd0/volume1 : ... : mount /dev/sda1 /hdd0/volume1 : ... : mount-local mnt/ : mount-local-run" kill -TERM `pidof guestfish` guestunmount mnt/ Is any of these options safe enough/preferred? Or, maybe, other options? I'd like to avoid guestfs API, threading and so on, and confine myself to command-line. Thanks in advance! -- Your sincerely, Maxim Perevedentsev

Add new scripts for: - guestunmount - virt-copy-in - virt-copy-out - virt-customize - virt-dib - virt-diff - virt-get-kernel - virt-p2v-make-disk - virt-p2v-make-kickstart - virt-p2v-make-kiwi - virt-tar-in - virt-tar-out Also combine the separate virt-resize script into the general script virt-alignment-scan. There wasn't real...

This implements most of RHBZ#1367738. I didn't bother with virt-v2v-copy-to-local and virt-win-reg, but all the other tools now have full bash completion. Rich.

I don't believe this has any use or meaning. Currently the tools don't process -?, eg: $ guestfish -\? Try `guestfish --help' for more information. Therefore I believe this is erroneous. --- fish/fish.c | 2 +- fuse/guestmount.c | 2 +- fuse/guestunmount.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fish/fish.c b/fish/fish.c index 49e1aaa..e639d3d 100644 --- a/fish/fish.c +++ b/fish/fish.c @@ -182,7 +182,7 @@ main (int argc, char *argv[]) enum { HELP_OPTION = CHAR_MAX + 1 }; - static const char *options = "a:...

* Workaround for linux-specific fuser -v * Workaround for linux-specific fusermount --- fuse/guestunmount.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/fuse/guestunmount.c b/fuse/guestunmount.c index 3df481b..2190ba0 100644 --- a/fuse/guestunmount.c +++ b/fuse/guestunmount.c @@ -257,7 +257,12 @@ do_fusermount (const char *mountpoint, char **error_rtn) /* We have to parse...

* fusermount is Linux-only; on BSD and OS X umount should be used * fuser has no -v flag on BSD/OSX, and -c is the POSIX-compatible equivalent of -m * Does not solve the lack of pretty output of fuser -v, but does make it work on Mac OS X. --- fuse/guestunmount.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/fuse/guestunmount.c b/fuse/guestunmount.c index 3df481b..94c3ec7 100644 --- a/fuse/guestunmount.c +++ b/fuse/guestunmount.c @@ -257,7 +257,12 @@ do_fusermount (const char *mountpoint, char **error_rtn) /* We have to parse error mes...

>From Apple's xdr.h: "If your code invokes an xdrproc_t callback, it must be modified to pass a third parameter, which may simply be zero." --- src/proto.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/proto.c b/src/proto.c index 92ae84d..57f4882 100644 --- a/src/proto.c +++ b/src/proto.c @@ -252,7 +252,12 @@ guestfs___send (guestfs_h *g, int proc_nr, *

The previous code: fcntl (fd, F_SETFL, O_NONBLOCK) was technically incorrect, because it would have reset any other flags on the file descriptor. Thanks: Eric Blake --- bootstrap | 1 + daemon/inotify.c | 6 ++++-- lib/conn-socket.c | 21 +++++++++++---------- m4/.gitignore | 9 +++++++++ 4 files changed, 25 insertions(+), 12 deletions(-) diff --git a/bootstrap b/bootstrap

...LOEXEC and SOCK_NONBLOCK which don't exist on Darwin. * src/launch-libvirt.c needs to #include <sys/un.h> for sockaddr_un. The rest of the issues have been mentioned in https://www.redhat.com/archives/libguestfs/2013-October/msg00042.html, and I've reused RWMJ's patches. * fuse/guestunmount.c uses Linux-specific fusermount and '-v' option for fuser. * src/proto.c -- From Apple's xdr.h: "If your code invokes an xdrproc_t callback, it must be modified to pass a third parameter, which may simply be zero." * OS X does not provide open_memstream(). * src/guestfs-in...

...sh/test-prep.sh | 35 ------------------------------- fish/test-run.sh | 2 +- format/test-virt-format.sh | 4 ++-- fuse/test-fuse-umount-race.sh | 6 +++--- fuse/test-guestmount-fd.c | 4 ++-- fuse/test-guestunmount-fd.c | 2 +- fuse/test-guestunmount-not-mounted.sh | 2 +- generator/fish.ml | 33 +++++++++++++++++++++++++++++ generator/fish.mli | 1 + generator/main.ml | 1 + inspector/Makefile.am...

...sit.h common/windows/windows.c common/windows/windows.h customize/crypt-c.c -customize/dummy.c customize/perl_edit-c.c daemon/9p.c daemon/acl.c @@ -202,7 +194,6 @@ df/df.c df/main.c df/output.c df/virt-df.h -dib/dummy.c diff/diff.c edit/edit.c erlang/actions-0.c @@ -270,7 +261,6 @@ fuse/guestunmount.c fuse/test-fuse.c fuse/test-guestmount-fd.c fuse/test-guestunmount-fd.c -get-kernel/dummy.c inspector/inspector.c java/actions-0.c java/actions-1.c @@ -370,7 +360,6 @@ rescue/escape.c rescue/rescue.c rescue/rescue.h rescue/suggest.c -resize/dummy.c ruby/ext/guestfs/actions-0.c ruby/ext/...