search for: guestsdir

On Mon, Oct 05, 2015 at 03:40:01PM +0300, Roman Kagan wrote: > -guestsdir="$(cd ../tests/guests && pwd)" > -f="$guestsdir/windows.img" > +abs_top_builddir="$(cd ..; pwd)" You don't need to define abs_top_builddir, as it should already be defined. However it won't be exported to the test scripts unless you change v2v/M...

...+print ("disk label = %s" % after) if before != after: raise "disk label was changed unexpectedly" diff --git a/python/t/910-libvirt.py b/python/t/910-libvirt.py index 1f70f36..f6c99c9 100644 --- a/python/t/910-libvirt.py +++ b/python/t/910-libvirt.py @@ -28,14 +28,14 @@ guestsdir = os.environ['guestsdir'] try: import libvirt except: - print "could not import python-libvirt" + print ("could not import python-libvirt") exit (77) conn = libvirt.open ("test:///%s/guests.xml" % guestsdir) # Check we're using the v...

On Mon, Oct 05, 2015 at 02:17:52PM +0100, Richard W.M. Jones wrote: > On Mon, Oct 05, 2015 at 03:40:01PM +0300, Roman Kagan wrote: > > -guestsdir="$(cd ../tests/guests && pwd)" > > -f="$guestsdir/windows.img" > > +abs_top_builddir="$(cd ..; pwd)" > > You don't need to define abs_top_builddir, as it should already be > defined. However it won't be exported to the test script...

...s(+), 113 deletions(-) create mode 100644 tests/fake-virt-tools/rhsrvany.exe diff --git a/p2v/test-virt-p2v-pxe.sh b/p2v/test-virt-p2v-pxe.sh index f05cb96..4a42d10 100755 --- a/p2v/test-virt-p2v-pxe.sh +++ b/p2v/test-virt-p2v-pxe.sh @@ -55,18 +55,14 @@ if ! test -f $img; then exit 77 fi -guestsdir="$(cd ../tests/guests && pwd)" -f="$guestsdir/windows.img" +abs_top_builddir="$(cd ..; pwd)" +f="$abs_top_builddir/tests/guests/windows.img" if ! test -f $f; then echo "$0: test skipped because phony Windows image was not created"...

This completes the implementation on the libguestfs side, allowing python-libvirt dom pointers to be passed to guestfs_add_libvirt_dom. For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1138203#c40 https://bugzilla.redhat.com/show_bug.cgi?id=1075143 https://bugzilla.redhat.com/show_bug.cgi?id=1075164 Rich.

A hopefully cleaner implementation this time. It doesn't require any special insights into how libvirt-python is implemented. Instead, it requires a change to libvirt-python to add a .c_pointer() method: https://www.redhat.com/archives/libvir-list/2014-December/msg00615.html Rich.

...tests b/python/run-python-tests index 1def36b..a374430 100755 --- a/python/run-python-tests +++ b/python/run-python-tests @@ -16,26 +16,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -errors=0 - guestsdir="$(cd ../test-data/phony-guests && pwd)" export guestsdir -for f in $srcdir/t/*.py; do - $PYTHON $f - r=$? - case $r in - 0) ;; - 77) - echo "$f: test skipped" - ;; - *) - echo "FAIL: $f" - ((errors++)) -...

Since v3: - Fix labelling over overlays (see 6/6) - Tested it with a test program which simulates what virt-manager will do. See the attachment here: https://bugzilla.redhat.com/show_bug.cgi?id=1075164#c7 Rich.

On Mon, Oct 05, 2015 at 06:12:03PM +0300, Roman Kagan wrote: > On Mon, Oct 05, 2015 at 02:17:52PM +0100, Richard W.M. Jones wrote: > > On Mon, Oct 05, 2015 at 03:40:01PM +0300, Roman Kagan wrote: > > > -guestsdir="$(cd ../tests/guests && pwd)" > > > -f="$guestsdir/windows.img" > > > +abs_top_builddir="$(cd ..; pwd)" > > > > You don't need to define abs_top_builddir, as it should already be > > defined. However it won't be ex...

Hi, this series cleans up the Python sources, either static or generated, including also tests, to make them PEP 8 compliant; see https://www.python.org/dev/peps/pep-0008/ and tools like pep8. Almost all the issues reported by pep8 are fixed, reducing the issues from 3818 to 7. The changes should have no effect on the actual code, while it will help Python users with consistency with other

qemu-nbd is a fine NBD server. However it's not easy to compile a reliably working version on RHEL 5. This patch series allows nbdkit to be used as an alternative (qemu-nbd is still the default). Rich.

This series makes several enhancements to tests for v2v conversion of Windows guests. Specifically, it - adds a number of files which imitate the stuff that is supposed to be present on the host when the actual conversion is performed, but may not be there when the tests are run. This includes certain tools and virtio drivers - fixes the test for windows conversion to actually

Previously I posted a work-in-progress preview of this patch series: https://www.redhat.com/archives/libguestfs/2017-February/msg00224.html This is the finished version that updates all of the shell-script based tests. It passes 'make check', 'make check-direct' and 'make check-slow'. Rich.

A mixed bag, but all the patches make sense together! Patch 1: Fix a bug that Tingting found: https://bugzilla.redhat.com/show_bug.cgi?id=1256222 Patch 2: Revert a patch that makes no sense now that we've added virt-v2v into base RHEL. This is just included because it's a cleanup needed before applying patch 3. Patch 3: Add the ability to use SSH identities (private keys) for virt-p2v

Fixes https://bugzilla.redhat.com/1256222

These are my thoughts on adding a test harness to run tests instead of using automake. The aim of this exercise is to allow us to run the full test suite on an installed copy of libguestfs. Another aim is to allow us to work around all the limitations and problems of automake. The first patch makes an observation that since the ./run script sets up $PATH to contain all the directories

This is a more complete patch to add the test harness. The only parts missing now are the language bindings (except OCaml). The language bindings need a bit more thought. At the moment most language binding tests are done through some sort of shell script like perl/run-perl-tests which either runs each test itself or uses some language-specific machinary to run each test. The problem with that

Since v2: - Add perl tests. - Reworked and fixed the tests for virt-builder. - Some further minor bug fixes.

Since v3: - A large number of fixes, especially for running the tests on installed libguestfs. - Fixed EXTRA_DIST rules throughout. - Extra patch 17/17 which is a tidy-up of the generated XML listing guests. Rich.