search for: guestfs_statns

...that would break the ABI of guestfs_lstatlist as it returns an array containing consecutive stat structs (not pointers). Changing the return type of guestfs_stat would break API. Changing the generator to support symbol versioning is judged to be too intrusive. Therefore this adds a new struct (guestfs_statns) and new APIs: guestfs_statns guestfs_lstatns guestfs_lstatnslist which return the new struct (or array of structs in the last case). The old APIs may of course still be used, forever, but are deprecated and shouldn't be used in new programs. Because virt tools are compiled with -DGUE...

Hi, we needed these changes when we had to build a guest image compatible with a starting guest image but not backed by it in any way? We needed some tool to check our progress, comparing original and? rebuilt (from scratch) images, and virt-diff seemed the best option, but? we had to soften the comparison to reduce the noise in the output. I added some options to ignore certain informations when

...mething. Now about failing test case with virt-tail. Jumping ahead, adding extra 'guestfish --remote sync' after 'guestfish --remote rm /tail' in 'cat/test-virt-tail.sh' fixes the test case. virt-tail re-creates overlay image each time it trying to access the file and calls guestfs_statns for the file(s) it watching. guestfs_statns in turn returns NULL indicating an error with exit code EIO instead of ENOENT: 'EXT2-fs (sda1): error: ext2_lookup: deleted inode referenced: 12'. (see pastebin posted in discussion above). So I suspect that changes on original disk made through...

...-compare-extra-stats")) { + no_compare_extra_stats = 1; } else { fprintf (stderr, _("%s: unknown long option: %s (%d)\n"), program_name, long_options[option_index].name, option_index); @@ -404,6 +429,8 @@ struct file { char *path; struct guestfs_statns *stat; struct guestfs_xattr_list *xattrs; + struct guestfs_statns *stat_orig; + struct guestfs_xattr_list *xattrs_orig; char *csum; /* Checksum. If NULL, use file times and size. */ }; @@ -466,6 +493,8 @@ visit_entry (const char *dir, const char *name, char *path = NU...

...if (STREQ (optarg, "no")) + compare_xattrs = 0; } else { fprintf (stderr, _("%s: unknown long option: %s (%d)\n"), program_name, long_options[option_index].name, option_index); @@ -404,6 +434,8 @@ struct file { char *path; struct guestfs_statns *stat; struct guestfs_xattr_list *xattrs; + struct guestfs_statns *stat_orig; + struct guestfs_xattr_list *xattrs_orig; char *csum; /* Checksum. If NULL, use file times and size. */ }; @@ -416,6 +448,8 @@ free_tree (struct tree *t) free (t->files[i].path); g...

...of guestfs_lstatlist as it returns an array > containing consecutive stat structs (not pointers). Changing the > return type of guestfs_stat would break API. Changing the generator > to support symbol versioning is judged to be too intrusive. > > Therefore this adds a new struct (guestfs_statns) and new APIs: > > guestfs_statns > guestfs_lstatns > guestfs_lstatnslist > > which return the new struct (or array of structs in the last case). > > The old APIs may of course still be used, forever, but are deprecated > and shouldn't be used in new programs...

...failing test case with virt-tail. > Jumping ahead, adding extra 'guestfish --remote sync' after 'guestfish > --remote rm /tail' in 'cat/test-virt-tail.sh' fixes the test case. > virt-tail re-creates overlay image each time it trying to access the file > and calls guestfs_statns for the file(s) it watching. > guestfs_statns in turn returns NULL indicating an error with exit code EIO > instead of ENOENT: 'EXT2-fs (sda1): error: ext2_lookup: deleted inode > referenced: 12'. (see pastebin posted in discussion above). > > So I suspect that changes on or...

...+ no_compare_extra_stats = 1; > } else { > fprintf (stderr, _("%s: unknown long option: %s (%d)\n"), > program_name, long_options[option_index].name, option_index); > @@ -404,6 +429,8 @@ struct file { > char *path; > struct guestfs_statns *stat; > struct guestfs_xattr_list *xattrs; > + struct guestfs_statns *stat_orig; > + struct guestfs_xattr_list *xattrs_orig; > char *csum; /* Checksum. If NULL, use file times and size. */ > }; > > @@ -466,6 +493,8 @@ visit_entry (const char *dir, c...

...es wrote: > This follows (tails) a log file within a guest, rather like > the regular 'tail -f' command. For example: > > virt-tail -d guest /var/log/messages > --- Mostly LGTM, just a few notes. > + guestfs_push_error_handler (g, NULL, NULL); > + stat = guestfs_statns (g, filename); > + guestfs_pop_error_handler (g); > + if (stat == NULL) { > + /* There's an error. Treat ENOENT as if the file was empty size. */ > + if (guestfs_last_errno (g) == ENOENT) { > + time (&t); > + file[i].mtime = t; &g...

...c = "\ Returns file information for the given C<path>. -This is the same as the C<stat(2)> system call." }; +This is the same as the L<stat(2)> system call." }; { defaults with name = "lstatns"; @@ -12070,7 +12070,7 @@ This is the same as C<guestfs_statns> except that if C<path> is a symbolic link, then the link is stat-ed, not the file it refers to. -This is the same as the C<lstat(2)> system call." }; +This is the same as the L<lstat(2)> system call." }; { defaults with name = "internal_lstatnslist...

...solved. --- cat/tail.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cat/tail.c b/cat/tail.c index 8785d45..51da5fc 100644 --- a/cat/tail.c +++ b/cat/tail.c @@ -309,7 +309,7 @@ do_tail (int argc, char *argv[], /* list of files in the guest */ CLEANUP_FREE_STATNS struct guestfs_statns *stat = NULL; if (windows) { - filename = windows_path (g, root, filename, 1 /* readonly */); + filename = windows_path (g, root, argv[i], 1 /* readonly */); if (filename == NULL) return -1; /* windows_path printed an error */ } -- 2.9.3

https://bugzilla.redhat.com/show_bug.cgi?id=1401320 This series contains two new operations. The second -- and least controversial -- is "passwd-backups" which removes files such as /etc/passwd-, /etc/shadow- and so on. The first one ("backup-files") searches the whole guest filesystem for any regular file which looks like an editor backup file, such as "*~" and

v3: - Split out test for "unix-like" guest OSes into separate commit. - Add guestfish --format=qcow2 to the test (x2). Rich.

In v2: - The backup-files operation now operates on a conservative whitelist of filesystems, so it won't touch anything in /usr. Consequently it also runs much more quickly, about 4 seconds on the barebones virt-builder fedora-25 image. - Call Gc.compact () in visit_tests. - Added documentation to fnmatch.mli.

Hi, this patch series fixes some issues discovered by Coverity. Most of them are memory leaks, usually on error; there are also invalid memory access issues. Thanks, Pino Toscano (11): java: link libguestfs_jni against libutils java: fix invalid memory access for FBuffer in struct lists daemon: tsk: properly use GUESTFS_MAX_CHUNK_SIZE edit: fix small memory leak on error java: fix

...nd = "/boot/vmlinuz-3.17.8-300.fc21.x86_64\n" > libguestfs: trace: v2v: statns "/boot/vmlinuz-3.17.8-300.fc21.x86_64" > guestfsd: main_loop: new request, len 0x50 > guestfsd: main_loop: proc 421 (statns) took 0.00 seconds > libguestfs: trace: v2v: statns = <struct guestfs_statns = st_dev: 2049, > st_ino: 340, st_mode: 33261, st_nlink: 1, st_uid: 0, st_gid: 0, st_rdev: > 0, st_size: 5757864, st_blksize: 4096, st_blocks: 11248, st_atime_sec: > 1420760440, st_atime_nsec: 0, st_mtime_sec: 1420760440, st_mtime_nsec: 0, > st_ctime_sec: 1421863850, st_ctime_nsec: 6000...

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

Since v2: - Fix the things that Pino mentioned, except the recursion. - Implement Windows support. For Windows support to be sane, I had to inline the add_and_mount code. Rich.

Miscellaneous refactoring, but the main one is to rename mllib/ as common/mltools/ Rich.

Nothing new in the virt-tail command itself, but the second commit includes a simple test. Rich.