search for: guestfs_pvcreate

...) == -1) goto error; + if (!guestfs_feature_available (g, (char **) feature)) { + printf ("skipping test because btrfs is not available\n"); + guestfs_close (g); + exit (77); + } + if (guestfs_part_disk (g, "/dev/sda", "mbr") == -1) goto error; if (guestfs_pvcreate (g, "/dev/sda1") == -1) goto error; -- 1.8.3.1

...; + } + + if (!guestfs_filesystem_available (g, "btrfs")) { + printf ("skipping test because btrfs filesystem is not available\n"); + guestfs_close (g); + exit (77); + } + if (guestfs_part_disk (g, "/dev/sda", "mbr") == -1) goto error; if (guestfs_pvcreate (g, "/dev/sda1") == -1) goto error; -- 1.8.3.1

So far the failure of some test would have not reported a non-zero return value by run-tests.php. Since now all the PHP tests pass, we can ask for failures to be fatal, by exporting REPORT_EXIT_STATUS=1 for run-tests.php. --- php/run-php-tests.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/php/run-php-tests.sh b/php/run-php-tests.sh index 6f9ae10..e498987 100755 ---

...mode 100644 index 0000000..cd4661a --- /dev/null +++ b/php/extension/tests/guestfs_100_launch.phpt @@ -0,0 +1,82 @@ +--TEST-- +Launch, create partitions and LVs and filesystems. +--FILE-- +<?php +$g = guestfs_create (); +guestfs_add_drive_scratch ($g, 500 * 1024 * 1024); +guestfs_launch ($g); + +guestfs_pvcreate ($g, "/dev/sda"); +guestfs_vgcreate ($g, "VG", array ("/dev/sda")); +guestfs_lvcreate ($g, "LV1", "VG", 200); +guestfs_lvcreate ($g, "LV2", "VG", 200); + +$lvs = guestfs_lvs ($g); +var_dump ($lvs); + +guestfs_mkfs ($g, "ext2...

...eature_available (g, (char **) feature)) { > + printf ("skipping test because btrfs is not available\n"); > + guestfs_close (g); > + exit (77); > + } > + > if (guestfs_part_disk (g, "/dev/sda", "mbr") == -1) goto error; > > if (guestfs_pvcreate (g, "/dev/sda1") == -1) goto error; > -- > 1.8.3.1 ACK. You might want to test for btrfs *filesystem*_available too ... The two are different things (userspace tools vs kernel module). Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-...

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

do a code cleanup by removing the tailing spaces Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- examples/create_disk.c | 2 +- examples/inspect_vm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/create_disk.c b/examples/create_disk.c index f4b9044..bcad6d8 100644 --- a/examples/create_disk.c +++ b/examples/create_disk.c @@ -7,7 +7,7

[PATCH 1/7] mount: Add mount_vfs_nochroot This is significantly reworked from before. umount is gone as discussed, and variable motion is minimised. [PATCH 2/7] btrfs: Update btrfs_subvolume_list to take Already provisionally ACKed. Previous comment was that cleanup could be tidier. I looked into creating a new cleanup function for fs_buf, but it isn't possible (or simple, anyway) in this

This is the same as the previous patch, but the partition type is now chosen automatically from mbr or gpt, unless the user expresses a preference. https://gb.redhat.com/archives/libguestfs/2012-January/msg00136.html Rich.

Rather than me explaining over again what it does, I've included the man page below. Rich. ---------------------------------------------------------------------- virt-format(1) Virtualization Support virt-format(1) NAME virt-format - Erase and make a blank disk SYNOPSIS virt-format [--options] -a disk.img [-a disk.img ...] DESCRIPTION

...st_error (g)); CLEANUP_FREE char *part2; - if (asprintf (&part2, "%s2", device) == -1) { - perror ("asprintf"); - exit (EXIT_FAILURE); - } + if (asprintf (&part2, "%s2", device) == -1) + error (EXIT_FAILURE, errno, "asprintf"); if (guestfs_pvcreate (g, part2) == -1) prep_error (data, filename, _("failed to create PV: %s: %s"), part2, guestfs_last_error (g)); diff --git a/fish/prep-fs.c b/fish/prep-fs.c index 55193ff..6670aa6 100644 --- a/fish/prep-fs.c +++ b/fish/prep-fs.c @@ -23,6 +23,8 @@ #include <stdarg...

This type is initially identical to Device. --- generator/bindtests.ml | 2 +- generator/c.ml | 7 +++++-- generator/csharp.ml | 6 ++++-- generator/daemon.ml | 4 ++-- generator/erlang.ml | 6 +++--- generator/fish.ml | 8 ++++---- generator/gobject.ml | 11 ++++++----- generator/haskell.ml | 11 +++++++---- generator/java.ml | 10 +++++-----