search for: guestfs_ocaml

...-cryptic error about the lack of a directory in the OCaml install prefix. As fix, check for the presence of the hivex module at build time, failing earlier if not present. The check is performed only when the daemon is enabled, as ocaml-hivex is not used for anything else than the daemon. --- m4/guestfs_ocaml.m4 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/m4/guestfs_ocaml.m4 b/m4/guestfs_ocaml.m4 index d0f3349..e577b31 100644 --- a/m4/guestfs_ocaml.m4 +++ b/m4/guestfs_ocaml.m4 @@ -56,6 +56,14 @@ AM_CONDITIONAL([HAVE_OCAMLOPT], AM_CONDITIONAL([HAVE_OCAMLDOC], [test "...

Place the Bytes fallback module in the right place (mlstdutils), with no need to make it available directly also for generation, since it uses mlstdutils now. Fixes commit 61d4891ef48df171a27873efe90aab51a9b711ef. --- .gitignore | 3 +-- generator/Makefile.am | 2 +- m4/guestfs_ocaml.m4 | 14 +++++--------- mllib/Makefile.am | 1 - 4 files changed, 7 insertions(+), 13 deletions(-) diff --git a/.gitignore b/.gitignore index 23cefcb..bbd9284 100644 --- a/.gitignore +++ b/.gitignore @@ -125,6 +125,7 @@ Makefile.in /common/miniexpect/miniexpect.3 /common/mlprogress/.depen...

Followup/fix of commit 61d4891ef48df171a27873efe90aab51a9b711ef. --- builder/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/Makefile.am b/builder/Makefile.am index 09ae4ae..e64c899 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -311,7 +311,7 @@ depend: .depend .depend: $(wildcard $(abs_srcdir)/*.mli) $(wildcard $(abs_srcdir)/*.ml) rm -f

OCaml 4.02 introduced the 'bytes' type, a mutable string intended to replace the existing 'string' type for those cases where the byte array can be mutated. In future the 'string' type will become immutable. This is not the default now, but it can be forced using the '-safe-string' compile option. I tested this on Fedora 24 (OCaml 4.02) & RHEL 7 (OCaml 4.01).

...on [in a future commit], and some utility libraries needed by the generator or daemon do not test for this macro because we can assume OCaml compiler availability. --- common/mlstdutils/Makefile.am | 4 --- docs/guestfs-building.pod | 11 +++--- generator/Makefile.am | 15 -------- m4/guestfs_ocaml.m4 | 83 +++++++++++++++++++++---------------------- 4 files changed, 47 insertions(+), 66 deletions(-) diff --git a/common/mlstdutils/Makefile.am b/common/mlstdutils/Makefile.am index 9e0b34d42..303c87c93 100644 --- a/common/mlstdutils/Makefile.am +++ b/common/mlstdutils/Makefile.am @@...

...m | 60 ++++++++++++++++++++++++++++++++++++++ configure.ac | 2 ++ daemon/Makefile.am | 53 +++++++--------------------------- docs/guestfs-hacking.pod | 20 +++++++++++++ docs/guestfs-internals.pod | 2 +- generator/main.ml | 9 +++--- m4/guestfs_ocaml.m4 | 2 +- po/POTFILES | 6 ++-- src/Makefile.am | 65 ++++++------------------------------------ tests/protocol/Makefile.am | 4 ++- 13 files changed, 166 insertions(+), 123 deletions(-) create mode 100644 common/errnostring/Makefile.am create...

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

This commit starts to split our massive, monolithic configure.ac file into smaller files, using the m4_include mechanism to combine them. I don't know if we should really do this, so I'm open to comments about it. However: - Our configure.ac script is 1800+ lines long, and that's pretty long. - configure.ac lacks structure; splitting it up might improve that. - From what I read,

...d.c | 31 + docs/guestfs-building.pod | 6 +- generator/actions_core.ml | 22 + generator/proc_nr.ml | 1 + gobject/run-live-tests | 2 +- gobject/run-tests | 2 +- gobject/run-tests-retvalues | 2 +- lib/MAX_PROC_NR | 2 +- m4/guestfs_ocaml.m4 | 8 + po-docs/cs.po | 2570 ++++++++++++++++++++-------------------- po-docs/de.po | 2570 ++++++++++++++++++++-------------------- po-docs/en_GB.po | 2707 ++++++++++++++++++++++--------------------- po-docs/es.po | 2570 +++++++++...

This can be used to enlarge or shrink an existing partition. --- daemon/parted.c | 31 +++++++++++++++++++++++++++++++ generator/actions_core.ml | 22 ++++++++++++++++++++++ generator/proc_nr.ml | 1 + lib/MAX_PROC_NR | 2 +- 4 files changed, 55 insertions(+), 1 deletion(-) diff --git a/daemon/parted.c b/daemon/parted.c index 72e1b8420..f1205cadf 100644 ---

...m4_include([m4/guestfs_qemu.m4]) dnl Miscellaneous libraries used by other programs. +AS_ECHO +AS_ECHO(["Checking for other libraries:"]) m4_include([m4/guestfs_misc_libraries.m4]) dnl Check for language bindings. +AS_ECHO +AS_ECHO(["Checking for OCaml:"]) m4_include([m4/guestfs_ocaml.m4]) +AS_ECHO +AS_ECHO(["Checking for Perl:"]) m4_include([m4/guestfs_perl.m4]) +AS_ECHO +AS_ECHO(["Checking for Python:"]) m4_include([m4/guestfs_python.m4]) +AS_ECHO +AS_ECHO(["Checking for Ruby:"]) m4_include([m4/guestfs_ruby.m4]) +AS_ECHO +AS_ECHO(["Checkin...

...is that the ocamldep file mentions ‘bytes.cmo’ whereas the ‘$(OCAML_BYTES_COMPAT_ML)’ macro expands to ‘../../common/mlstdutils/bytes.ml’. Make doesn't recognize these as the same file. Use an alternate way to specify this file to fix this. --- common/mlstdutils/Makefile.am | 9 +++++++-- m4/guestfs_ocaml.m4 | 2 ++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/common/mlstdutils/Makefile.am b/common/mlstdutils/Makefile.am index 968a03d..e569154 100644 --- a/common/mlstdutils/Makefile.am +++ b/common/mlstdutils/Makefile.am @@ -27,9 +27,14 @@ SOURCES_MLI = \ stringMap.mli...

https://bugzilla.redhat.com/show_bug.cgi?id=1441197

v1 -> v2: - Fixed everything mentioned in patch review. - Libdir module is removed as a separate commit. Rich.

This is something I've been working on: Reworking inspection so it's not a big mess of ad hoc C code, but instead uses a well-defined domain-specific language to describe how we inspect guests. The best introduction to this is the manual page, which I include below (it's also included in patch 2/3). Rich. ---------------------------------------------------------------------- NAME

Miscellaneous refactoring, but the main one is to rename mllib/ as common/mltools/ Rich.

...| 325 ++------------- generator/types.mli | 440 +++++++++++++++++++++ get-kernel/Makefile.am | 7 +- get-kernel/get_kernel.mli | 19 + m4/guestfs-ocaml-gettext.m4 | 83 ++-- m4/guestfs_ocaml.m4 | 4 +- mllib/Makefile.am | 1 + resize/Makefile.am | 5 +- resize/resize.mli | 19 + sparsify/Makefile.am | 6 +- sparsify/copy...

Two (not related to each other) refactorings: Patches 1-12 split configure.ac into smaller files using the m4_include mechanism. Patches 13-15 split out parts of guestfs.pod (ie. guestfs(3)) into three new manual pages: guestfs-hacking(3) - how to extend and contribute to libguestfs guestfs-internals(3) - architecture and internals guestfs-security(3) - security and CVEs Patch 16 is a

This works reliably for me ... Rich.

Previously posted: https://www.redhat.com/archives/libguestfs/2015-December/msg00038.html Inspection now really succeeds on a small number of simple guests. To test it out: $ ./run guestfish -v -x -a /tmp/centos-6.img ><fs> run ><fs> debug sh "guestfs-inspection --verbose" Rich.