search for: guestfs_lvm_pv

This happens with GCC 7.0.1. The errors were all of the form: qemu-speed-test.c: In function 'main': qemu-speed-test.c:153:7: error: this statement may fall through [-Werror=implicit-fallthrough=] usage (EXIT_SUCCESS); ^~~~~~~~~~~~~~~~~~~~ qemu-speed-test.c:155:5: note: here default: ^~~~~~~ --- builder/index-validate.c | 2 +-

...continue; + } /* Ignore the root device. */ if (is_root_device (dev_path)) diff --git a/generator/bindtests.ml b/generator/bindtests.ml index 22d0c37..2fde425 100644 --- a/generator/bindtests.ml +++ b/generator/bindtests.ml @@ -258,8 +258,8 @@ fill_lvm_pv (guestfs_h *g, struct guestfs_lvm_pv *pv, size_t i) pr " }\n"; pr " strs = safe_malloc (g, (n+1) * sizeof (char *));\n"; pr " for (i = 0; i < n; ++i) {\n"; - pr " strs[i] = safe_malloc (g, 16);\n"; - pr " snprintf...

...rec generate_bindtests () = #include \"guestfs-internal-actions.h\" #include \"guestfs_protocol.h\" +#include \"intprops.h\" + int guestfs_impl_internal_test_set_output (guestfs_h *g, const char *filename) { @@ -258,8 +260,8 @@ fill_lvm_pv (guestfs_h *g, struct guestfs_lvm_pv *pv, size_t i) pr " }\n"; pr " strs = safe_malloc (g, (n+1) * sizeof (char *));\n"; pr " for (i = 0; i < n; ++i) {\n"; - pr " strs[i] = safe_malloc (g, 16);\n"; - pr " snprintf...

v1 -> v2: - Use intprops macro suggested by danpb. Rich.

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

...for function\n"; pr " * "; generate_ocaml_prototype name style; diff --git a/generator/bindtests.ml b/generator/bindtests.ml index d225146c0..4bdff8092 100644 --- a/generator/bindtests.ml +++ b/generator/bindtests.ml @@ -139,8 +139,7 @@ fill_lvm_pv (guestfs_h *g, struct guestfs_lvm_pv *pv, size_t i) | _ -> assert false in List.iter ( - fun { name = name; style = (ret, args, optargs as style); - c_optarg_prefix = c_optarg_prefix } -> + fun { name; style = (ret, args, optargs as style); c_optarg_prefix } -> pr "/* The %s function print...

..., (uintmax_t) pid); addr->sun_family = AF_UNIX; strcpy (addr->sun_path, sockpath); diff --git a/generator/bindtests.ml b/generator/bindtests.ml index 9558a74..5358ff1 100644 --- a/generator/bindtests.ml +++ b/generator/bindtests.ml @@ -159,7 +159,7 @@ fill_lvm_pv (guestfs_h *g, struct guestfs_lvm_pv *pv, size_t i) pr " {\n"; pr " size_t i;\n"; pr " for (i = 0; i < %s_size; ++i)\n" n; - pr " fprintf (fp, \"<%%02x>\", %s[i]);\n" n; + pr " fprintf (fp, \"<%%0...

..., (uintmax_t) pid); addr->sun_family = AF_UNIX; strcpy (addr->sun_path, sockpath); diff --git a/generator/bindtests.ml b/generator/bindtests.ml index 9558a74..5358ff1 100644 --- a/generator/bindtests.ml +++ b/generator/bindtests.ml @@ -159,7 +159,7 @@ fill_lvm_pv (guestfs_h *g, struct guestfs_lvm_pv *pv, size_t i) pr " {\n"; pr " size_t i;\n"; pr " for (i = 0; i < %s_size; ++i)\n" n; - pr " fprintf (fp, \"<%%02x>\", %s[i]);\n" n; + pr " fprintf (fp, \"<%%0...

...2 +- generator/xdr.ml | 3 ++- 20 files changed, 115 insertions(+), 56 deletions(-) diff --git a/generator/bindtests.ml b/generator/bindtests.ml index 0959704..1d9ea3e 100644 --- a/generator/bindtests.ml +++ b/generator/bindtests.ml @@ -163,7 +163,8 @@ fill_lvm_pv (guestfs_h *g, struct guestfs_lvm_pv *pv, size_t i) pr " fprintf (fp, \"\\n\");\n"; pr " }\n"; | OptString n -> pr " fprintf (fp, \"%%s\\n\", %s ? %s : \"null\");\n" n n - | StringList n | DeviceList n -> pr " print_strin...

...2 +- generator/xdr.ml | 3 ++- 20 files changed, 116 insertions(+), 56 deletions(-) diff --git a/generator/bindtests.ml b/generator/bindtests.ml index 0959704..020d059 100644 --- a/generator/bindtests.ml +++ b/generator/bindtests.ml @@ -163,7 +163,8 @@ fill_lvm_pv (guestfs_h *g, struct guestfs_lvm_pv *pv, size_t i) pr " fprintf (fp, \"\\n\");\n"; pr " }\n"; | OptString n -> pr " fprintf (fp, \"%%s\\n\", %s ? %s : \"null\");\n" n n - | StringList n | DeviceList n -> pr " print_strin...

...version.2 diff --git a/generator/bindtests.ml b/generator/bindtests.ml index 742cb1b..ffb3ee7 100644 --- a/generator/bindtests.ml +++ b/generator/bindtests.ml @@ -20,6 +20,7 @@ open Printf +open Common_utils open Types open Utils open Pr @@ -176,7 +177,7 @@ fill_lvm_pv (guestfs_h *g, struct guestfs_lvm_pv *pv, size_t i) let check_optarg n printf_args = pr " fprintf (fp, \"%s: \");\n" n; pr " if (optargs->bitmask & %s_%s_BITMASK) {\n" c_optarg_prefix - (String.uppercase n); + (String.uppercase_ascii n); pr &quo...

Per my previous email: https://www.redhat.com/archives/libguestfs/2017-September/msg00203.html I'd like to talk about requiring a more modern version of the OCaml compiler. These commits show some of the code changes which would be possible with OCaml >= 3.12 [which it turns out we already require by accident] and also with OCaml >= 4.02. The latter is my favoured option. Rich.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

...ibtsk"; shortdesc = "search the entries associated to the given inode"; diff --git a/generator/bindtests.ml b/generator/bindtests.ml index 8ac503181..c3caebfce 100644 --- a/generator/bindtests.ml +++ b/generator/bindtests.ml @@ -153,13 +153,7 @@ fill_lvm_pv (guestfs_h *g, struct guestfs_lvm_pv *pv, size_t i) List.iter ( function - | Pathname n - | Device n | Mountable n | Dev_or_Path n | Mountable_or_Path n - | String n - | FileIn n - | FileOut n - | Key n - | GUID n -> pr " fprintf (fp, \"%%s\\n\", %s)...

Very large but mechanical change to the generator. Rich.