Displaying 12 results from an estimated 12 matches for "guestfs_luks_uuid".
2020 Oct 06
2
Re: [PATCH common v2 4/4] options: Ignore errors from guestfs_luks_uuid.
...ypto_LUKS") || STREQ (type, "BitLocker"))) {
>+ bool is_bitlocker = STREQ (type, "BitLocker");
> char mapname[32];
> make_mapname (partitions[i], mapname, sizeof mapname);
>
> #ifdef GUESTFS_HAVE_LUKS_UUID
>- CLEANUP_FREE char *uuid = guestfs_luks_uuid (g, partitions[i]);
>+ CLEANUP_FREE char *uuid;
>+ if (!is_bitlocker)
>+ uuid = guestfs_luks_uuid (g, partitions[i]);
>+ else {
>+ /* This may fail for Windows BitLocker disks because
>+ * cryptsetup luksUUID cannot read a UUID (unclear if
>...
2020 Oct 07
2
Re: [PATCH common v2 4/4] options: Ignore errors from guestfs_luks_uuid.
...ot;))) {
>> >+ bool is_bitlocker = STREQ (type, "BitLocker");
>> > char mapname[32];
>> > make_mapname (partitions[i], mapname, sizeof mapname);
>> >
>> >#ifdef GUESTFS_HAVE_LUKS_UUID
>> >- CLEANUP_FREE char *uuid = guestfs_luks_uuid (g, partitions[i]);
>> >+ CLEANUP_FREE char *uuid;
>> >+ if (!is_bitlocker)
>> >+ uuid = guestfs_luks_uuid (g, partitions[i]);
>> >+ else {
>> >+ /* This may fail for Windows BitLocker disks because
>> >+ * c...
2020 Oct 06
0
Re: [PATCH common v2 4/4] options: Ignore errors from guestfs_luks_uuid.
...type, "BitLocker"))) {
> >+ bool is_bitlocker = STREQ (type, "BitLocker");
> > char mapname[32];
> > make_mapname (partitions[i], mapname, sizeof mapname);
> >
> >#ifdef GUESTFS_HAVE_LUKS_UUID
> >- CLEANUP_FREE char *uuid = guestfs_luks_uuid (g, partitions[i]);
> >+ CLEANUP_FREE char *uuid;
> >+ if (!is_bitlocker)
> >+ uuid = guestfs_luks_uuid (g, partitions[i]);
> >+ else {
> >+ /* This may fail for Windows BitLocker disks because
> >+ * cryptsetup luksUUID canno...
2020 Oct 09
0
Re: [PATCH common v2 4/4] options: Ignore errors from guestfs_luks_uuid.
...t;+ bool is_bitlocker = STREQ (type, "BitLocker");
>>> > char mapname[32];
>>> > make_mapname (partitions[i], mapname, sizeof mapname);
>>> >
>>> >#ifdef GUESTFS_HAVE_LUKS_UUID
>>> >- CLEANUP_FREE char *uuid = guestfs_luks_uuid (g, partitions[i]);
>>> >+ CLEANUP_FREE char *uuid;
>>> >+ if (!is_bitlocker)
>>> >+ uuid = guestfs_luks_uuid (g, partitions[i]);
>>> >+ else {
>>> >+ /* This may fail for Windows BitLocker disks because
>&g...
2020 Sep 07
0
[PATCH common v2 4/4] options: Ignore errors from guestfs_luks_uuid.
...(STREQ (type, "crypto_LUKS") || STREQ (type, "BitLocker"))) {
+ bool is_bitlocker = STREQ (type, "BitLocker");
char mapname[32];
make_mapname (partitions[i], mapname, sizeof mapname);
#ifdef GUESTFS_HAVE_LUKS_UUID
- CLEANUP_FREE char *uuid = guestfs_luks_uuid (g, partitions[i]);
+ CLEANUP_FREE char *uuid;
+ if (!is_bitlocker)
+ uuid = guestfs_luks_uuid (g, partitions[i]);
+ else {
+ /* This may fail for Windows BitLocker disks because
+ * cryptsetup luksUUID cannot read a UUID (unclear if
+ * this is a limita...
2020 Mar 30
0
[PATCH common 3/4] options: Ignore errors from guestfs_luks_uuid.
...ions/decrypt.c
index 58f8df9..069a83f 100644
--- a/options/decrypt.c
+++ b/options/decrypt.c
@@ -83,7 +83,11 @@ inspect_do_decrypt (guestfs_h *g, struct key_store *ks)
CLEANUP_FREE char *mapname = make_mapname (partitions[i]);
#ifdef GUESTFS_HAVE_LUKS_UUID
- CLEANUP_FREE char *uuid = guestfs_luks_uuid (g, partitions[i]);
+ /* This may fail for Windows BitLocker disks, so hide errors. */
+ CLEANUP_FREE char *uuid;
+ guestfs_push_error_handler (g, NULL, NULL);
+ uuid = guestfs_luks_uuid (g, partitions[i]);
+ guestfs_pop_error_handler (g);
#else
const char *uuid = N...
2020 Sep 07
5
[PATCH common v2 0/4] Windows BitLocker support.
For links to the original patch series, see:
https://bugzilla.redhat.com/show_bug.cgi?id=1808977#c8
The original feedback was that ignoring errors from guestfs_luks_uuid
would ignore legitimate errors from non-BitLocker disks, so I have
modified this series so that errors are only ignored in the BitLocker
case. As noted in the 4th patch there is no actual error in the
BitLocker case, cryptsetup luksUUID simply exits without printing
anything.
Rich.
2020 Mar 30
6
[PATCH common 0/4] options: Support Windows BitLocker (RHBZ#1808977).
Support transparent decryption/inspection of Windows guests encrypted
with BitLocker encryption.
This won't make much sense without the associated libguestfs
patches which I will post momentarily. (Submodules, ho hum)
Rich.
2020 Mar 30
0
[PATCH common 2/4] options: Generate cryptsetup mapnames beginning with "crypt..." not "luks..."
...artitions[i]);
if (type && STREQ (type, "crypto_LUKS")) {
- char mapname[32];
- make_mapname (partitions[i], mapname, sizeof mapname);
+ CLEANUP_FREE char *mapname = make_mapname (partitions[i]);
#ifdef GUESTFS_HAVE_LUKS_UUID
CLEANUP_FREE char *uuid = guestfs_luks_uuid (g, partitions[i]);
--
2.25.0
2019 Nov 29
0
[common PATCH 2/2] options: allow a UUID as identifier for --key
...86,7 +86,13 @@ inspect_do_decrypt (guestfs_h *g, struct key_store *ks)
char mapname[32];
make_mapname (partitions[i], mapname, sizeof mapname);
- CLEANUP_FREE_STRING_LIST char **keys = get_keys (ks, partitions[i]);
+#ifdef GUESTFS_HAVE_LUKS_UUID
+ CLEANUP_FREE char *uuid = guestfs_luks_uuid (g, partitions[i]);
+#else
+ const char *uuid = NULL;
+#endif
+
+ CLEANUP_FREE_STRING_LIST char **keys = get_keys (ks, partitions[i], uuid);
assert (guestfs_int_count_strings (keys) > 0);
/* Try each key in turn. */
diff --git a/options/key-option.pod b/options/key-opti...
2020 Mar 10
2
[PATCH common] options: Require libguestfs >= 1.42.
...ypt.c
@@ -85,12 +85,7 @@ inspect_do_decrypt (guestfs_h *g, struct key_store *ks)
if (type && STREQ (type, "crypto_LUKS")) {
char mapname[32];
make_mapname (partitions[i], mapname, sizeof mapname);
-
-#ifdef GUESTFS_HAVE_LUKS_UUID
CLEANUP_FREE char *uuid = guestfs_luks_uuid (g, partitions[i]);
-#else
- const char *uuid = NULL;
-#endif
CLEANUP_FREE_STRING_LIST char **keys = get_keys (ks, partitions[i], uuid);
assert (guestfs_int_count_strings (keys) > 0);
diff --git a/options/options.c b/options/options.c
index abdcbae5b..63221ea32 100644
--- a/...
2019 Nov 29
8
[PATCH 0/1] Allow UUIDs for --key identifiers.
This combined patch series enables to decrypt LUKS devices on inspection
by allowing the UUID of the LUKS device with the --key syntax.
I opted for reusing the option instead of adding another one, as I think
that device names and UUIDs are different enough that can be properly
distinguished.
A test for this (patch #4) can be applied only when the patches for
common are applied, and the