search for: guestfs_list_filesystem

On Tue, Jan 23, 2018 at 12:44:10AM +0200, Mykola Ivanets wrote: > Before I rush to change something I request your comments on the subject. > Let me know what do you think and if it does make sense. > > The issue: guesfs_list_filesystems is inconsistent in its output. The concept of guestfs_list_filesystem is that it returns a list something like the list that running ‘df’ inside a traditional Unix would return, ie. a list of mounted filesystems backed by real devices, plus swap. That's not an exact definition. A better way to understand it might be to look at how it is is used (ie. ‘git grep l...

...t 12:44:10AM +0200, Mykola Ivanets wrote: >> Before I rush to change something I request your comments on the subject. >> Let me know what do you think and if it does make sense. >> >> The issue: guesfs_list_filesystems is inconsistent in its output. > > The concept of guestfs_list_filesystem is that it returns a list > something like the list that running ‘df’ inside a traditional Unix > would return, ie. a list of mounted filesystems backed by real > devices, plus swap. > > That's not an exact definition. A better way to understand it might > be to look at how i...

guestfs_list_filesystems uses mount/umount to discover btrfs sub-volumes and since 1.37 it generates random mountpoint so it will longer affect already mounted filesystems if either. --- generator/actions_core.ml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/generator/actions_core.ml b/generator/a...

This is a fix for: https://bugzilla.redhat.com/show_bug.cgi?id=642933 We had a lot of code before which used ad-hoc ways to list out all mountable filesystems in a guest. We now have a core inspection API (guestfs_list_filesystems) which does the same thing. These patches remove the last remaining use of the old way, in favour of using the core API. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the...

...s on the subject. Let me know what do you think and if it does make sense. The issue: guesfs_list_filesystems is inconsistent in its output. For, example, it filters out partitioned physical devices but doesn't do the same for MD devices. More over, according to its name and API documentation guestfs_list_filesystem should return something which potentially can be mounted (SWAP is an exclusion and it is stated in API doc). It is the reason partitioned physical devices are filtered out: they are not mountable even in theory (they don't contain filesystem if they contain partition(s)). Another example of no...

Rebased. The only thing left unclear is: "Would you like to document behavior for non-MBR partitions more clearly or keep previous implementation despite MBR partition type doesn't make sense for non-MBR partitions at all?"

..."DMIO:ID:" prefix followed by the GPT parition GUID. > > + */ > > +static char * > > +map_registry_disk_blob_gpt (guestfs_h *g, const void *blob) > > +{ > > +  CLEANUP_FREE_STRING_LIST char **fses = NULL; > > +  size_t i; > > + > > +  fses = guestfs_list_filesystems (g); > > +  if (fses == NULL) > > +    return NULL; > > Did you really mean to call guestfs_list_filesystems here?  If you're > trying to get the list of partitions, then guestfs_list_partitions is > what you should be calling. > First, thank you for a prompt revi...

...the strings btrfsvol:... are the internal "mountable" format, and shouldn't be displayed to end users for a couple of reasons: (1) It's not intended that people would "know about" these strings. You're only compliant with the API if you get a string from an API like guestfs_list_filesystems and pass it to another API like guestfs_mount. (2) These strings aren't actually useful, because you cannot pass them back to the guestfish/guestmount `-m' option. Instead you have to use the non-obvious form: -m /dev/sda1:/:subvol=/@/tmp How do we solve this? Trickier than it seems...

If calling guestfs_list_filesystems with a disk image containing a corrupt btrfs volume, the library would segfault. There was a missing check for a NULL return from guestfs_btrfs_subvolume_list. This adds a check, returning the real error up through the stack and out of guestfs_list_filesystems. This is potentially a denial of s...

...+ * to libguestfs GPT partition device. For GPT disks, the blob is made of + * "DMIO:ID:" prefix followed by the GPT parition GUID. + */ +static char * +map_registry_disk_blob_gpt (guestfs_h *g, const void *blob) +{ + CLEANUP_FREE_STRING_LIST char **fses = NULL; + size_t i; + + fses = guestfs_list_filesystems (g); + if (fses == NULL) + return NULL; + + for (i = 0; fses[i] != NULL; i += 2) { + CLEANUP_FREE char *fs_guid = NULL; + CLEANUP_FREE char *blob_guid = NULL; + CLEANUP_FREE char *fs_dev = NULL; + + fs_dev = guestfs_canonical_device_name (g, fses[i]); + + if (fs_dev == NULL) +...

This patch series: 1. Addresses comments from last review: part_get_mbr_part_type doesn't break original implementation in C. 2. Rebased on top of master and little bit refactored for readability. Mykola Ivanets (1): tests: md: Test guestfish list-filesystems command skips partitioned md devices. Nikolay Ivanets (2): daemon: Reimplement 'part_get_mbr_part_type' API in

On Tuesday 11 February 2014 20:16:56 Richard W.M. Jones wrote: > If calling guestfs_list_filesystems with a disk image containing a > corrupt btrfs volume, the library would segfault. There was a missing > check for a NULL return from guestfs_btrfs_subvolume_list. > > This adds a check, returning the real error up through the stack and > out of guestfs_list_filesystems. > &gt...

...GPT disks, the blob is made of > + * "DMIO:ID:" prefix followed by the GPT parition GUID. > + */ > +static char * > +map_registry_disk_blob_gpt (guestfs_h *g, const void *blob) > +{ > + CLEANUP_FREE_STRING_LIST char **fses = NULL; > + size_t i; > + > + fses = guestfs_list_filesystems (g); > + if (fses == NULL) > + return NULL; Did you really mean to call guestfs_list_filesystems here? If you're trying to get the list of partitions, then guestfs_list_partitions is what you should be calling. > + for (i = 0; fses[i] != NULL; i += 2) { > + CLEANUP_FREE...

...by 0x4ED05FF: find_or_cache_feature (available.c:48) ==25905== by 0x4ED073C: guestfs_impl_feature_available (available.c:89) ==25905== by 0x4EA4B21: guestfs_feature_available (actions-5.c:1131) ==25905== by 0x4EF9FDF: guestfs_impl_list_filesystems (listfs.c:49) ==25905== by 0x4E7EDF2: guestfs_list_filesystems (actions-3.c:419) ==25905== by 0x4EE0FD2: guestfs_impl_inspect_os (inspect.c:62) ==25905== by 0x4E50E12: guestfs_inspect_os (actions-0.c:500) ==25905== by 0x4E3292: ocaml_guestfs_inspect_os (guestfs-c-actions.c:9385) ==25905== by 0x4696C8: camlGuestfs__fun_16039 (guestfs.ml:1242) ==259...

Initial discussion is here: https://www.redhat.com/archives/libguestfs/2018-January/msg00188.html. v2 was posted here: https://www.redhat.com/archives/libguestfs/2018-January/msg00246.html. v3 comparing to v2 is just a rebase with slightly changed commits comments.

...anges since v1: * applied style changes from review * use guestfs_list_partitions instead of guestfs_list_filesystems * do the GUID endianness conversion correctly * check all API calls for errors * do not call guestfs_canonical_device_name to prevent from changing * block device names, i.e /dev/vda1 as it comes from list_partitions * to...

...h LVs. We don't want to return LVs here because we prefer to use the "/dev/VG/LV" notation for these throughout the rest of the API. The second patch extends guestfish so that tab completion includes /dev/mapper paths. Future work: Returning filesystems on opened LUKS devices from guestfs_list_filesystems. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

Hi, I have tried to extract *.vhd* file using guestfs library. I am able to list all files inside my archive using *guestfs_ls* also * guestfs_list_filesystems()* retruns right File system information. I am trying to extract files from inside archive using *guestfs_copy_device_to_file() * but it returns following error (error: copy_device_to_file: unknown option 689330304 (this can happen if a program is compiled against a newer version of libguestfs, th...

...646821 virt-df should have --uuid option - 646432 /dev/mapper paths should not be returned from guestfs_mountpoints - 643624 libguestfs tools documentation should describe how to quote guest domain names from shell - 642934 No way to specify disk format when adding a disk to libguestfs - 642933 guestfs_list_filesystems should be used in all possible places - 642932 guestmount options should match guestfish options - 642930 virt-inspector (Sys::Guestfs::Lib) should use C inspection APIs - 642929 C inspection code should ignore /dev/fd* in /etc/fstab - 642826 virt-resize converts any other image format to raw...