search for: guestfs_internal_write_append

Cosmetic change as suggested in this previous patch: https://www.redhat.com/archives/libguestfs/2016-November/msg00111.html Matteo Cafasso (2): lib: generic function for temporary path generation lib: use guestfs_int_make_temp_path to generate temporary files src/drives.c | 5 ++--- src/file.c | 22 +++++++++------------- src/guestfs-internal.h | 1 + src/journal.c

...pfile == NULL) goto err; - tmpfile = safe_asprintf (g, "%s/find%d", g->tmpdir, ++g->unique); - if (guestfs_find0 (g, directory, tmpfile) == -1) goto err; @@ -317,11 +315,10 @@ write_or_append (guestfs_h *g, const char *path, (!append ? guestfs_internal_write : guestfs_internal_write_append) (g, path, content, size); - if (guestfs_int_lazy_make_tmpdir (g) == -1) - goto err; - /* Write the content out to a temporary file. */ - tmpfile = safe_asprintf (g, "%s/write%d", g->tmpdir, ++g->unique); + tmpfile = guestfs_int_make_temp_path (g, "write")...

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

Tested with 'make check-release'. tests/parallel (in check-slow) failed, although it does regularly and that seems to be because of libvirt. Rich.

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.