search for: guestfs_internal_mountable

...ce: is_file = 0 libguestfs: trace: umount_all libguestfs: trace: umount_all = 0 libguestfs: trace: vfs_type "/dev/sda2" libguestfs: trace: vfs_type = "ntfs" libguestfs: trace: internal_parse_mountable "/dev/sda2" libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable *> libguestfs: trace: is_whole_device "/dev/sda2" libguestfs: trace: is_whole_device = 0 libguestfs: trace: mount_ro "/dev/sda2" "/" libguestfs: trace: mount_ro = -1 (error) libguestfs: trace: vfs_type "/dev/sda3" libguestfs: trace: vfs_type = ""...

...s: trace: umount_all > libguestfs: trace: umount_all = 0 > libguestfs: trace: vfs_type "/dev/sda2" > libguestfs: trace: vfs_type = "ntfs" > libguestfs: trace: internal_parse_mountable "/dev/sda2" > libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable *> > libguestfs: trace: is_whole_device "/dev/sda2" > libguestfs: trace: is_whole_device = 0 > libguestfs: trace: mount_ro "/dev/sda2" "/" > libguestfs: trace: mount_ro = -1 (error) > libguestfs: trace: vfs_type "/dev/sda3" > libguestfs:...

...able/test-internal-parse-mountable.c b/tests/mountable/test-internal-parse-mountable.c index ed3264e..bf03743 100644 --- a/tests/mountable/test-internal-parse-mountable.c +++ b/tests/mountable/test-internal-parse-mountable.c @@ -33,6 +33,7 @@ main (int argc, char *argv[]) guestfs_h *g; struct guestfs_internal_mountable *mountable; const char *devices[] = { "/dev/VG/LV", NULL }; + const char *feature[] = { "btrfs", NULL }; g = guestfs_create (); if (g == NULL) { @@ -48,6 +49,12 @@ main (int argc, char *argv[]) if (guestfs_launch (g) == -1) goto error; + if (!guestfs_feature_...

...ace: umount_all > libguestfs: trace: umount_all = 0 > libguestfs: trace: vfs_type "/dev/sda2" > libguestfs: trace: vfs_type = "ntfs" > libguestfs: trace: internal_parse_mountable "/dev/sda2" > libguestfs: trace: internal_parse_mountable = <struct > guestfs_internal_mountable *> > libguestfs: trace: is_whole_device "/dev/sda2" > libguestfs: trace: is_whole_device = 0 > libguestfs: trace: mount_ro "/dev/sda2" "/" > libguestfs: trace: mount_ro = -1 (error) > libguestfs: trace: vfs_type "/dev/sda3" > libguestfs:...

Hi, Thank you Richard for your work, but I have also like Jeff Forbes a new issue : libguestfs: trace: hivex_node_set_value = 0 libguestfs: trace: upload "/usr/share/virtio-win/drivers/amd64/Win2008/viostor.sys" "/Windows/Drivers/VirtIO" libguestfs: trace: upload = -1 (error) libguestfs: trace: hivex_close libguestfs: trace: hivex_close = 0 virt-v2v: error: libguestfs error:

...able/test-internal-parse-mountable.c b/tests/mountable/test-internal-parse-mountable.c index ed3264e..0638fc0 100644 --- a/tests/mountable/test-internal-parse-mountable.c +++ b/tests/mountable/test-internal-parse-mountable.c @@ -33,6 +33,7 @@ main (int argc, char *argv[]) guestfs_h *g; struct guestfs_internal_mountable *mountable; const char *devices[] = { "/dev/VG/LV", NULL }; + const char *feature[] = { "btrfs", NULL }; g = guestfs_create (); if (g == NULL) { @@ -48,6 +49,18 @@ main (int argc, char *argv[]) if (guestfs_launch (g) == -1) goto error; + if (!guestfs_feature_...

...h Floor, Boston, MA 02110-1301 USA + */ + +#include <config.h> + +#include <errno.h> + +#include "guestfs.h" +#include "guestfs-internal.h" + + +char * +guestfs_impl_mountable_device (guestfs_h *g, const char *mountable) +{ + CLEANUP_FREE_INTERNAL_MOUNTABLE struct guestfs_internal_mountable *mnt = NULL; + + if ((mnt = guestfs_internal_parse_mountable (g, mountable))) + return safe_strdup(g, mnt->im_device); + + return NULL; +} + +char * +guestfs_impl_mountable_subvolume (guestfs_h *g, const char *mountable) +{ + CLEANUP_FREE_INTERNAL_MOUNTABLE struct guestfs_interna...

Hey there! Here are a few patches to fix unrelated things: one fixes the configure for older ncurses releases having no pkg-config files. The other two are fixing what Richard mentioned about guestfs subvolumes display Cédric Bosdonnat (3): configure: handle older version of ncurses api: add mountable_device and mountable_subvolume fish: fix btrfs subvolumes display in error case

...-1301 USA + */ + +#include <config.h> +#include <string.h> +#include <errno.h> + +#include "guestfs.h" +#include "guestfs-internal.h" + + +char * +guestfs_impl_mountable_device (guestfs_h *g, const char *mountable) +{ + CLEANUP_FREE_INTERNAL_MOUNTABLE struct guestfs_internal_mountable *mnt = NULL; + + mnt = guestfs_internal_parse_mountable (g, mountable); + if (mnt == NULL) + return NULL; + + return safe_strdup(g, mnt->im_device); +} + +char * +guestfs_impl_mountable_subvolume (guestfs_h *g, const char *mountable) +{ + CLEANUP_FREE_INTERNAL_MOUNTABLE struct...

...10-1301 USA + */ + +#include <config.h> +#include <string.h> +#include <errno.h> + +#include "guestfs.h" +#include "guestfs-internal.h" + + +char * +guestfs_impl_mountable_device (guestfs_h *g, const char *mountable) +{ + CLEANUP_FREE_INTERNAL_MOUNTABLE struct guestfs_internal_mountable *mnt = NULL; + + mnt = guestfs_internal_parse_mountable (g, mountable); + if (mnt == NULL) + return NULL; + + return safe_strdup (g, mnt->im_device); +} + +char * +guestfs_impl_mountable_subvolume (guestfs_h *g, const char *mountable) +{ + CLEANUP_FREE_INTERNAL_MOUNTABLE struct guestfs_in...

Hi all, Here is version 2 of the patch series, including the changes for Pino's remarks. Cédric Bosdonnat (3): configure: handle older version of ncurses api: add mountable_device and mountable_subvolume fish: fix btrfs subvolumes display in error case fish/options.c | 28 ++++++++++++++++++++++++++- generator/actions.ml | 26 +++++++++++++++++++++++++

...uestfs_pop_error_handler (g); - - return 1; -} diff --git a/src/inspect-fs.c b/src/inspect-fs.c index e9cc2e9..7b116db 100644 --- a/src/inspect-fs.c +++ b/src/inspect-fs.c @@ -48,6 +48,7 @@ static int check_filesystem (guestfs_h *g, const char *mountable, const struct guestfs_internal_mountable *m, int whole_device); static int extend_fses (guestfs_h *g); +static int get_partition_context (guestfs_h *g, const char *partition, int *partnum_ret, int *nr_partitions_ret); /* Find out if 'device' contains a filesystem. If it does, add * another entr...

Hi there, Latest and greatest version including all new remarks from both Pino and Rich. Cédric Bosdonnat (3): configure: handle older version of ncurses api: add mountable_device and mountable_subvolume fish: fix btrfs subvolumes display in error case fish/options.c | 28 ++++++++++++++++++++++++++- generator/actions.ml | 26 +++++++++++++++++++++++++ m4/guestfs_libraries.m4

...able.c b/tests/mountable/test-internal-parse-mountable.c > index ed3264e..bf03743 100644 > --- a/tests/mountable/test-internal-parse-mountable.c > +++ b/tests/mountable/test-internal-parse-mountable.c > @@ -33,6 +33,7 @@ main (int argc, char *argv[]) > guestfs_h *g; > struct guestfs_internal_mountable *mountable; > const char *devices[] = { "/dev/VG/LV", NULL }; > + const char *feature[] = { "btrfs", NULL }; > > g = guestfs_create (); > if (g == NULL) { > @@ -48,6 +49,12 @@ main (int argc, char *argv[]) > > if (guestfs_launch (g) == -1...

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

...inspect-fs.c b/src/inspect-fs.c index 09a7005..073ae57 100644 --- a/src/inspect-fs.c +++ b/src/inspect-fs.c @@ -47,7 +47,7 @@ COMPILE_REGEXP (re_major_minor, "(\\d+)\\.(\\d+)", 0) static int check_filesystem (guestfs_h *g, const char *mountable, const struct guestfs_internal_mountable *m, int whole_device); -static int extend_fses (guestfs_h *g); +static void extend_fses (guestfs_h *g); static int get_partition_context (guestfs_h *g, const char *partition, int *partnum_ret, int *nr_partitions_ret); /* Find out if 'device' contains a file...

.../dev/sda1", "ext4", "/dev/sda2", "ext4"] libguestfs: trace: vfs_type "/dev/sda1" libguestfs: trace: vfs_type = "ext4" libguestfs: trace: internal_parse_mountable "/dev/sda1" libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable = im_type: 0, im_device: /dev/sda1, im_volume: , > libguestfs: trace: is_whole_device "/dev/sda1" libguestfs: trace: is_whole_device = 0 libguestfs: trace: mount_ro "/dev/sda1" "/" libguestfs: trace: mount_ro = 0 libguestfs: trace: part_to_dev "/dev/sda1&q...

...ot;ext4", "/dev/sda2", "ext4"] > libguestfs: trace: vfs_type "/dev/sda1" > libguestfs: trace: vfs_type = "ext4" > libguestfs: trace: internal_parse_mountable "/dev/sda1" > libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable = im_type: 0, im_device: /dev/sda1, im_volume: , > > libguestfs: trace: is_whole_device "/dev/sda1" > libguestfs: trace: is_whole_device = 0 > libguestfs: trace: mount_ro "/dev/sda1" "/" > libguestfs: trace: mount_ro = 0 > libguestfs: trace: part...

..._sensitive_path (g, cmd_exe); if (!cmd_exe_path) return -1; diff --git a/src/inspect-fs.c b/src/inspect-fs.c index d220634..0473e92 100644 --- a/src/inspect-fs.c +++ b/src/inspect-fs.c @@ -175,6 +175,9 @@ check_filesystem (guestfs_h *g, const char *mountable, const struct guestfs_internal_mountable *m, int whole_device) { + /* Not CLEANUP_FREE, as it will be cleaned up with inspection info */ + char *windows_systemroot = NULL; + if (extend_fses (g) == -1) return -1; @@ -274,10 +277,11 @@ check_filesystem (guestfs_h *g, const char *mountable, guestfs...

...;, "/dev/sda2", "ext4"] >> libguestfs: trace: vfs_type "/dev/sda1" >> libguestfs: trace: vfs_type = "ext4" >> libguestfs: trace: internal_parse_mountable "/dev/sda1" >> libguestfs: trace: internal_parse_mountable = <struct guestfs_internal_mountable = im_type: 0, im_device: /dev/sda1, im_volume: , > >> libguestfs: trace: is_whole_device "/dev/sda1" >> libguestfs: trace: is_whole_device = 0 >> libguestfs: trace: mount_ro "/dev/sda1" "/" >> libguestfs: trace: mount_ro = 0 >> libguest...