Displaying 5 results from an estimated 5 matches for "guestfs_int_version_is".
Did you mean:
guestfs_int_version_ge
2016 May 17
2
Re: [PATCH 1/2] src: start unifying version handling
On Tue, May 17, 2016 at 03:41:10PM +0200, Pino Toscano wrote:
> +extern bool guestfs_int_version_is (const struct version *v, int maj, int min, int mic);
I think calling this function "is" is a bit misleading. I think
we should have _ge and _le functions (cf my patch).
This comparison for example is wrong:
> /* qemu 1.1 claims to support virtio-scsi but in reality it's bro...
2016 May 17
0
[PATCH 1/2] src: start unifying version handling
...9,12 @@ struct guestfs_message_header;
struct guestfs_message_error;
struct guestfs_progress;
+/* version.c */
+extern void guestfs_int_version_from_libvirt (struct version *v, int vernum);
+extern void guestfs_int_version_from_values (struct version *v, int maj, int min, int mic);
+extern bool guestfs_int_version_is (const struct version *v, int maj, int min, int mic);
+#define version_init_null(v) guestfs_int_version_from_values (v, 0, 0, 0)
+
/* handle.c */
extern int guestfs_int_get_backend_setting_bool (guestfs_h *g, const char *name);
@@ -903,7 +915,7 @@ extern void guestfs_int_cleanup_cmd_close (stru...
2016 May 17
3
[PATCH 0/2] src: introduce an helper version struct
Hi,
this adds an helper version struct, and uses it in the backends (for the
libvirt and qemu versions) and inspection code. This also moves common
code to that, so it is not repeated in many places.
This should help with the small refactoring proposed with
https://www.redhat.com/archives/libguestfs/2016-May/msg00070.html
Thanks,
Pino Toscano (2):
src: start unifying version handling
2016 May 18
0
Re: [PATCH 1/2] src: start unifying version handling
On Tuesday 17 May 2016 15:45:42 Richard W.M. Jones wrote:
> On Tue, May 17, 2016 at 03:41:10PM +0200, Pino Toscano wrote:
> > +extern bool guestfs_int_version_is (const struct version *v, int maj, int min, int mic);
>
> I think calling this function "is" is a bit misleading. I think
> we should have _ge and _le functions (cf my patch).
Makes sense, renamed to _ge.
> This comparison for example is wrong:
>
> > /* qemu 1...
2016 May 18
3
[PATCH v2 0/2] src: introduce an helper version struct
Hi,
this adds an helper version struct, and uses it in the backends (for the
libvirt and qemu versions) and inspection code. This also moves common
code to that, so it is not repeated in many places.
This should help with the small refactoring proposed with
https://www.redhat.com/archives/libguestfs/2016-May/msg00070.html
Thanks,
Pino Toscano (2):
src: start unifying version handling