search for: guestfs_int_tsk_dir

...(-) > > diff --git a/daemon/tsk.c b/daemon/tsk.c > index dd368d7..6e6df6d 100644 > --- a/daemon/tsk.c > +++ b/daemon/tsk.c > @@ -48,6 +48,7 @@ static char file_type (TSK_FS_FILE *); > static int file_flags (TSK_FS_FILE *fsfile); > static void file_metadata (TSK_FS_META *, guestfs_int_tsk_dirent *); > static int send_dirent_info (guestfs_int_tsk_dirent *); > +static int entry_is_dot(TSK_FS_FILE *); > static void reply_with_tsk_error (const char *); Since in patch #2 this forward declaration is moved, put it at the right place already in this patch. > int > @@ -113,9...

...IMG_INFO **, TSK_FS_INFO **); static TSK_WALK_RET_ENUM fswalk_callback (TSK_FS_FILE *, const char *, void *); +static int send_dirent_info (TSK_FS_FILE *, const char *); static char file_type (TSK_FS_FILE *); static int file_flags (TSK_FS_FILE *fsfile); static void file_metadata (TSK_FS_META *, guestfs_int_tsk_dirent *); -static int send_dirent_info (guestfs_int_tsk_dirent *); -static int entry_is_dot(TSK_FS_FILE *); static void reply_with_tsk_error (const char *); +static int entry_is_dot(TSK_FS_FILE *); int do_internal_filesystem_walk (const mountable_t *mountable) @@ -104,29 +104,44 @@ open_filesyste...

v2: - refactor logic to reduce code duplication - better functions naming Matteo Cafasso (6): filesystem_walk: fixed root inode listing daemon: refactor tsk code lib: rename tsk internal function New API: internal_find_inode New API: find_inode find_inode: added API tests daemon/tsk.c | 156 ++++++++++++++++++++++++++++++------------- generator/actions.ml

v5: - small doc fix: filesystem_walk claimed '.' and '..' entries were not reported but Root is now reported as '.' - bump to 1.35.6 Matteo Cafasso (6): filesystem_walk: fixed root inode listing daemon: refactor tsk code lib: rename tsk internal function New API: internal_find_inode New API: find_inode find_inode: added API tests daemon/tsk.c

...> >> index dd368d7..6e6df6d 100644 > >> --- a/daemon/tsk.c > >> +++ b/daemon/tsk.c > >> @@ -48,6 +48,7 @@ static char file_type (TSK_FS_FILE *); > >> static int file_flags (TSK_FS_FILE *fsfile); > >> static void file_metadata (TSK_FS_META *, guestfs_int_tsk_dirent *); > >> static int send_dirent_info (guestfs_int_tsk_dirent *); > >> +static int entry_is_dot(TSK_FS_FILE *); > >> static void reply_with_tsk_error (const char *); > > Since in patch #2 this forward declaration is moved, put it at the > > right place a...

v4: - refactor entry_is_dot My apologies for the duplicated submission but I did not read the next e-mail. The tsk_fs_dir_walk API will list all the entries including '.' and '..' in a similar manner as for 'ls -a'. This means our callback will be called for the following entries: . <-- the Root entry etc/. etc/.. <-- again the Root entry etc/systemd/.

This series should be ready for merge v6: - rebase on master - changes according to last comments Matteo Cafasso (6): filesystem_walk: fixed root inode listing daemon: refactor tsk code lib: rename tsk internal function New API: internal_find_inode New API: find_inode find_inode: added API tests daemon/tsk.c | 155 ++++++++++++++++++++++++++++++-------------

v3: - coding style fixes - comment entry_is_dot logic Matteo Cafasso (6): filesystem_walk: fixed root inode listing daemon: refactor tsk code lib: rename tsk internal function New API: internal_find_inode New API: find_inode find_inode: added API tests daemon/tsk.c | 157 ++++++++++++++++++++++++++++++------------- generator/actions.ml | 21 ++++++

...e changed, 14 insertions(+), 3 deletions(-) diff --git a/daemon/tsk.c b/daemon/tsk.c index dd368d7..6e6df6d 100644 --- a/daemon/tsk.c +++ b/daemon/tsk.c @@ -48,6 +48,7 @@ static char file_type (TSK_FS_FILE *); static int file_flags (TSK_FS_FILE *fsfile); static void file_metadata (TSK_FS_META *, guestfs_int_tsk_dirent *); static int send_dirent_info (guestfs_int_tsk_dirent *); +static int entry_is_dot(TSK_FS_FILE *); static void reply_with_tsk_error (const char *); int @@ -113,9 +114,7 @@ fswalk_callback (TSK_FS_FILE *fsfile, const char *path, void *data) CLEANUP_FREE char *fname = NULL; struct gue...

...generator/actions.ml | 5 ++--- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/daemon/tsk.c b/daemon/tsk.c index dd368d7..9884472 100644 --- a/daemon/tsk.c +++ b/daemon/tsk.c @@ -49,6 +49,7 @@ static int file_flags (TSK_FS_FILE *fsfile); static void file_metadata (TSK_FS_META *, guestfs_int_tsk_dirent *); static int send_dirent_info (guestfs_int_tsk_dirent *); static void reply_with_tsk_error (const char *); +static int entry_is_dot(TSK_FS_FILE *); int do_internal_filesystem_walk (const mountable_t *mountable) @@ -113,9 +114,7 @@ fswalk_callback (TSK_FS_FILE *fsfile, const char *path, v...

...D = 0x04 }; static int open_filesystem (const char *, TSK_IMG_INFO **, TSK_FS_INFO **); static TSK_WALK_RET_ENUM fswalk_callback (TSK_FS_FILE *, const char *, void *); static char file_type (TSK_FS_FILE *); static int file_flags (TSK_FS_FILE *fsfile); +static int file_metadata (TSK_FS_META *, guestfs_int_tsk_dirent *); static int send_dirent_info (guestfs_int_tsk_dirent *); static void reply_with_tsk_error (const char *); @@ -122,19 +124,24 @@ fswalk_callback (TSK_FS_FILE *fsfile, const char *path, void *data) return TSK_WALK_ERROR; } + /* Set dirent fields */ + memset (&dirent, 0, sizeof...

...a/daemon/tsk.c b/daemon/tsk.c >> index dd368d7..6e6df6d 100644 >> --- a/daemon/tsk.c >> +++ b/daemon/tsk.c >> @@ -48,6 +48,7 @@ static char file_type (TSK_FS_FILE *); >> static int file_flags (TSK_FS_FILE *fsfile); >> static void file_metadata (TSK_FS_META *, guestfs_int_tsk_dirent *); >> static int send_dirent_info (guestfs_int_tsk_dirent *); >> +static int entry_is_dot(TSK_FS_FILE *); >> static void reply_with_tsk_error (const char *); > Since in patch #2 this forward declaration is moved, put it at the > right place already in this patch. &gt...

...const char *path, void *data); > > > > Single line for forward declarations. > > > > Even if they are longer than 80 chars? Yep. > > > +static char file_type (TSK_FS_FILE *fsfile); > > > +static int send_dirent_info (guestfs_int_tsk_dirent *dirent); > > > +static void reply_with_tsk_error (const char *funcname); > > > + > > > +int > > > +do_internal_filesystem_walk (const mountable_t *mountable) > > > +{ > > > + int ret = -1; > > > + TSK_FS_INFO *fs = NULL; > >...

...**img, TSK_FS_INFO **fs); > +static TSK_WALK_RET_ENUM fswalk_callback (TSK_FS_FILE *fsfile, > + const char *path, void *data); Single line for forward declarations. > +static char file_type (TSK_FS_FILE *fsfile); > +static int send_dirent_info (guestfs_int_tsk_dirent *dirent); > +static void reply_with_tsk_error (const char *funcname); > + > +int > +do_internal_filesystem_walk (const mountable_t *mountable) > +{ > + int ret = -1; > + TSK_FS_INFO *fs = NULL; > + TSK_IMG_INFO *img = NULL; /* Used internally by tsk_fs_dir_walk */ &gt...

...rents->len * > + sizeof (*dirents->val)); > + } > + > + memset(&dirents->val[index], 0, sizeof (*dirents->val)); I think this should not be needed at all, the XDR decoding should set every field in the struct. > + ret = xdr_guestfs_int_tsk_dirent(&xdr, (guestfs_int_tsk_dirent *) Why is "(guestfs_int_tsk_dirent *)" needed? (Also, missing space.) Thanks, -- Pino Toscano

...= 0x04 }; static int open_filesystem (const char *, TSK_IMG_INFO **, TSK_FS_INFO **); static TSK_WALK_RET_ENUM fswalk_callback (TSK_FS_FILE *, const char *, void *); static char file_type (TSK_FS_FILE *); static int file_flags (TSK_FS_FILE *fsfile); +static void file_metadata (TSK_FS_META *, guestfs_int_tsk_dirent *); static int send_dirent_info (guestfs_int_tsk_dirent *); static void reply_with_tsk_error (const char *); @@ -122,15 +124,15 @@ fswalk_callback (TSK_FS_FILE *fsfile, const char *path, void *data) return TSK_WALK_ERROR; } + /* Set dirent fields */ + memset (&dirent, 0, sizeof...

...l.com> --- daemon/tsk.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/daemon/tsk.c b/daemon/tsk.c index dd368d7..4a0517b 100644 --- a/daemon/tsk.c +++ b/daemon/tsk.c @@ -114,9 +114,12 @@ fswalk_callback (TSK_FS_FILE *fsfile, const char *path, void *data) struct guestfs_int_tsk_dirent dirent; /* Ignore ./ and ../ */ - ret = TSK_FS_ISDOT (fsfile->name->name); - if (ret != 0) - return TSK_WALK_CONT; + if (TSK_FS_ISDOT (fsfile->name->name)) { + /* Root is represented as . */ + if (fsfile->fs_info->root_inum != fsfile->name->meta_addr || +...

...groups.h" + +#ifdef HAVE_LIBTSK + +#include <tsk/libtsk.h> + +static int open_filesystem (const char *, TSK_IMG_INFO **, TSK_FS_INFO **); +static TSK_WALK_RET_ENUM fswalk_callback (TSK_FS_FILE *, const char *, void *); +static char file_type (TSK_FS_FILE *); +static int send_dirent_info (guestfs_int_tsk_dirent *); +static void reply_with_tsk_error (const char *); + +int +do_internal_filesystem_walk (const mountable_t *mountable) +{ + int ret = -1; + TSK_FS_INFO *fs = NULL; + TSK_IMG_INFO *img = NULL; /* Used internally by tsk_fs_dir_walk */ + int flags = TSK_FS_DIR_WALK_FLAG_ALLOC | TSK_FS_DIR_WA...

...nst char *device, + TSK_IMG_INFO **img, TSK_FS_INFO **fs); +static TSK_WALK_RET_ENUM fswalk_callback (TSK_FS_FILE *fsfile, + const char *path, void *data); +static char file_type (TSK_FS_FILE *fsfile); +static int send_dirent_info (guestfs_int_tsk_dirent *dirent); +static void reply_with_tsk_error (const char *funcname); + +int +do_internal_filesystem_walk (const mountable_t *mountable) +{ + int ret = -1; + TSK_FS_INFO *fs = NULL; + TSK_IMG_INFO *img = NULL; /* Used internally by tsk_fs_dir_walk */ + int flags = TSK_FS_DIR_WALK_FLAG_ALLOC |...

v3: - File size will be reported as - 1 if it cannot be retrieved. - Code improvements based on comments. Matteo Cafasso (5): generator: Added tsk_dirent struct configure: Added libtsk compile-time check daemon: Added internal_filesystem_walk command appliance: Added filesystem_walk command appliance: Added filesystem_walk command tests daemon/Makefile.am | 4 +-