search for: guestfs_int_free_inspect_info

On 02/06/15 17:10, Richard W.M. Jones wrote: Hello, > On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote: >> + if (collect_coreos_inspection_info (g)) { >> + guestfs_int_free_inspect_info (g); >> + return NULL; >> + } > Although this is stylistic, I think it's easier to understand if > you change the if condition to: > > if (collect_coreos_inspection_info (g) == -1) { > ... > Since we 'll be using safe_realloc, I don't think there...

Sorry, I don't get it. In inspect.c line 67 you have this: for (fs = fses; *fs; fs += 2) { if (guestfs_int_check_for_filesystem_on (g, *fs)) { guestfs_int_free_inspect_info (g); return NULL; } } I don't see the bug. On 02/06/15 18:30, Richard W.M. Jones wrote: > On Tue, Jun 02, 2015 at 06:18:38PM +0300, Nikos Skalkotos wrote: >> On 02/06/15 17:10, Richard W.M. Jones wrote: >> Hello, >> >>> On Fri, May 29, 2015 at 12:24:5...

...tfs_impl_inspect_os (guestfs_h *g) } } + /* The OS inspection information for CoreOS are gathered by inspecting + * multiple filesystems. Gather all the inspected information in the + * inspect_fs struct of the root filesystem. + */ + if (collect_coreos_inspection_info (g)) { + guestfs_int_free_inspect_info (g); + return NULL; + } + /* Check if the same filesystem was listed twice as root in g->fses. * This may happen for the *BSD root partition where an MBR partition * is a shadow of the real root partition probably /dev/sda5 @@ -87,6 +97,57 @@ guestfs_impl_inspect_os (guestfs_h *g)...

On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote: > + if (collect_coreos_inspection_info (g)) { > + guestfs_int_free_inspect_info (g); > + return NULL; > + } Although this is stylistic, I think it's easier to understand if you change the if condition to: if (collect_coreos_inspection_info (g) == -1) { ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my pr...

On Tue, Jun 02, 2015 at 06:18:38PM +0300, Nikos Skalkotos wrote: > On 02/06/15 17:10, Richard W.M. Jones wrote: > Hello, > > > On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote: > >> + if (collect_coreos_inspection_info (g)) { > >> + guestfs_int_free_inspect_info (g); > >> + return NULL; > >> + } > > Although this is stylistic, I think it's easier to understand if > > you change the if condition to: > > > > if (collect_coreos_inspection_info (g) == -1) { > > ... > > > Since we 'll be...

On Tue, Jun 02, 2015 at 06:37:06PM +0300, Nikos Skalkotos wrote: > Sorry, I don't get it. In inspect.c line 67 you have this: > > for (fs = fses; *fs; fs += 2) { > if (guestfs_int_check_for_filesystem_on (g, *fs)) { > guestfs_int_free_inspect_info (g); > return NULL; > } > } Oh I see, yes that's a bug too. > I don't see the bug. I was looking at this other bug in src/inspect-fs.c: static int extend_fses (guestfs_h *g) { size_t n = g->nr_fses + 1; struct inspect_fs *p; p = realloc (g-&...

...Richard W.M. Jones wrote: > On Tue, Jun 02, 2015 at 06:37:06PM +0300, Nikos Skalkotos wrote: >> Sorry, I don't get it. In inspect.c line 67 you have this: >> >> for (fs = fses; *fs; fs += 2) { >> if (guestfs_int_check_for_filesystem_on (g, *fs)) { >> guestfs_int_free_inspect_info (g); >> return NULL; >> } >> } > Oh I see, yes that's a bug too. > >> I don't see the bug. > I was looking at this other bug in src/inspect-fs.c: > > static int > extend_fses (guestfs_h *g) > { > size_t n = g->nr_fses...

This depends on the patch series "[PATCH 00/27] Reimplement many daemon APIs in OCaml." (https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html) v8 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00274.html v9: - I split up the mega-patch into a more reviewable series of smaller, incremental patches. There are some other changes vs v8, but

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.

v9 was here: https://www.redhat.com/archives/libguestfs/2017-July/msg00139.html This depends on these three series (the first two being single minor patches): https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html https://www.redhat.com/archives/libguestfs/2017-July/msg00215.html There is no substantive change. I

This fixes almost everything. Note that it adds an extra commit which fixes the whole utf8/iconv business. It's probably better to list what isn't fixed: (1) I didn't leave the osinfo code around because I'm still haven't looked too closely at virt-builder-repository. Can't we just fetch this code from the git history when we need it? (2) I didn't change the way

v10: https://www.redhat.com/archives/libguestfs/2017-July/msg00245.html No actual change here, but I rebased and retested. Also this series now does not depend on any other patch series since everything else needed is upstream. Rich.

This is the (incomplete) patch which reimplements inspection APIs in the daemon. All ‘XXX’s in this patch indicate areas which are not yet implemented or need further work. Rich.

v6 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html and this requires the utilities refactoring posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html Inspection is now complete[*], although not very well tested. I'm intending to compare the output of many guests using old & new virt-inspector to see if I can find any

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid

..., const char *root) char * guestfs_impl_inspect_get_windows_current_control_set (guestfs_h *g, - const char *root) + const char *root) { struct inspect_fs *fs = guestfs_int_search_for_root (g, root); if (!fs) @@ -623,8 +623,8 @@ guestfs_int_free_inspect_info (guestfs_h *g) */ char * guestfs_int_download_to_tmp (guestfs_h *g, struct inspect_fs *fs, - const char *filename, - const char *basename, uint64_t max_size) + const char *filename, + const char *basename, uint64_t max_size) {...

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67