search for: guestfs_inspect_list_applications

John, This was my attempt to add symbol versioning to the library, letting us break ABI without breaking any existing callers. Unfortunately it doesn't work: - the new versioned symbols are marked local in libguestfs.so - the existing symbols should now have @GUESTFS_0.0 versions, but don't The documentation for this stuff is extremely thin, and I've got a bad case of

This is a simpler patch series to add symbol versioning. I have pushed patches 1-3 upstream. Rich.

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

This rather more complex patch series adds symbol versioning (7/7 shows it in action). This works for me, tested by running old and new virt-inspector binaries against the new library. Rich.

..., int32_t epoch, const char *version, const char *release, const char *arch, const char *install_path, const char *publisher, const char *url, const char *source, const char *summary, const char *description); static void sort_applications (struct guestfs_application2_list *); /* The deprecated guestfs_inspect_list_applications call, which is now @@ -369,7 +369,7 @@ read_package (guestfs_h *g, /* Add the application and what we know. */ if (version && release) add_application (g, data->apps, entry->name, "", epoch, version, release, - arch ? arch : "", &quot...

..., int32_t epoch, const char *version, const char *release, const char *arch, const char *install_path, const char *publisher, const char *url, const char *source, const char *summary, const char *description); static void sort_applications (struct guestfs_application2_list *); /* The deprecated guestfs_inspect_list_applications call, which is now @@ -369,7 +369,7 @@ read_package (guestfs_h *g, /* Add the application and what we know. */ if (version && release) add_application (g, data->apps, entry->name, "", epoch, version, release, - arch ? arch : "", &quot...

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings.

Here's the new API method and update to virt-inspector. I still need to implement app_arch for debian and windows (if applicable), for now they just return empty strings. New in v2: incorporated feedback from v1, also added patch #3 which updates the documentation where it references the deprecated API. Take it or leave it.

This change is part of an ongoing effort to remove use of $desc and inspect the OS directly as required during conversion. --- lib/Sys/VirtConvert/Connection/LibVirtTarget.pm | 4 +- lib/Sys/VirtConvert/Connection/RHEVTarget.pm | 41 +++++++++--------- lib/Sys/VirtConvert/Converter.pm | 35 ++++++++++++---- lib/Sys/VirtConvert/Converter/RedHat.pm | 45

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....

...tor.1 \ --html ../html/virt-inspector.1.html \ virt-inspector.pod /usr/bin/pod2html: -: unknown pod directive 'encoding' in paragraph 1. ignoring. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/INSPECTION> in paragraph 64. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_inspect_list_applications> in paragraph 81. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 92. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 94. /usr/bin/pod2html: -: cannot resolve L<mbooth at redhat....