search for: guestfs_inspect_get_format

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

...)/INSPECTION> for more details." }; - - { defaults with - name = "inspect_is_live"; added = (1, 9, 4); - style = RBool "live", [String (Mountable, "root")], []; - shortdesc = "get live flag for install disk"; - longdesc = "\ -If C<guestfs_inspect_get_format> returns C<installer> (this -is an install disk), then this returns true if a live image -was detected on the disk. - -Please read L<guestfs(3)/INSPECTION> for more details." }; - - { defaults with - name = "inspect_is_netinst"; added = (1, 9, 4); - style = RBoo...

These 3 patches implement support for APIs which must accept a mountable, but don't update apis which must return mountables. Matt

This is the (incomplete) patch which reimplements inspection APIs in the daemon. All ‘XXX’s in this patch indicate areas which are not yet implemented or need further work. Rich.

This type is initially identical to Device. --- generator/bindtests.ml | 2 +- generator/c.ml | 7 +++++-- generator/csharp.ml | 6 ++++-- generator/daemon.ml | 4 ++-- generator/erlang.ml | 6 +++--- generator/fish.ml | 8 ++++---- generator/gobject.ml | 11 ++++++----- generator/haskell.ml | 11 +++++++---- generator/java.ml | 10 +++++-----

...ame = "inspect_is_live"; added = (1, 9, 4); - style = RBool "live", [Mountable "root"], []; + style = RBool "live", [String (Mountable, "root")], []; shortdesc = "get live flag for install disk"; longdesc = "\ If C<guestfs_inspect_get_format> returns C<installer> (this @@ -610,7 +610,7 @@ Please read L<guestfs(3)/INSPECTION> for more details." }; { defaults with name = "inspect_is_netinst"; added = (1, 9, 4); - style = RBool "netinst", [Mountable "root"], []; + style = R...

Very large but mechanical change to the generator. Rich.

v9 was here: https://www.redhat.com/archives/libguestfs/2017-July/msg00139.html This depends on these three series (the first two being single minor patches): https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html https://www.redhat.com/archives/libguestfs/2017-July/msg00215.html There is no substantive change. I

This depends on the patch series "[PATCH 00/27] Reimplement many daemon APIs in OCaml." (https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html) v8 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00274.html v9: - I split up the mega-patch into a more reviewable series of smaller, incremental patches. There are some other changes vs v8, but

This fixes almost everything. Note that it adds an extra commit which fixes the whole utf8/iconv business. It's probably better to list what isn't fixed: (1) I didn't leave the osinfo code around because I'm still haven't looked too closely at virt-builder-repository. Can't we just fetch this code from the git history when we need it? (2) I didn't change the way

v10: https://www.redhat.com/archives/libguestfs/2017-July/msg00245.html No actual change here, but I rebased and retested. Also this series now does not depend on any other patch series since everything else needed is upstream. Rich.

...if (STRNEQ (str, "unknown")) XMLERROR (-1, - xmlTextWriterWriteElement (xo, BAD_CAST "hostname", - BAD_CAST str)); + xmlTextWriterWriteElement (xo, BAD_CAST "hostname", + BAD_CAST str)); free (str); str = guestfs_inspect_get_format (g, root); if (!str) exit (EXIT_FAILURE); if (STRNEQ (str, "unknown")) XMLERROR (-1, - xmlTextWriterWriteElement (xo, BAD_CAST "format", - BAD_CAST str)); + xmlTextWriterWriteElement (xo, BAD_CAST "format", + B...

v6 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html and this requires the utilities refactoring posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html Inspection is now complete[*], although not very well tested. I'm intending to compare the output of many guests using old & new virt-inspector to see if I can find any

Result of earlier copy and paste. --- align/scan.c | 35 ++++++++++--------- cat/cat.c | 39 +++++++++++---------- cat/filesystems.c | 69 +++++++++++++++++++------------------- cat/log.c | 35 ++++++++++--------- cat/ls.c | 61 +++++++++++++++++---------------- df/main.c | 43 ++++++++++++------------ diff/diff.c | 67

Split up the huge generator/actions.ml into several smaller files. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

...as no tests warning: "guestfs_inspect_get_package_format" has no tests warning: "guestfs_inspect_get_package_management" has no tests warning: "guestfs_inspect_list_applications" has no tests warning: "guestfs_inspect_get_hostname" has no tests warning: "guestfs_inspect_get_format" has no tests warning: "guestfs_inspect_is_live" has no tests warning: "guestfs_inspect_is_netinst" has no tests warning: "guestfs_inspect_is_multipart" has no tests warning: "guestfs_ll" has no tests warning: "guestfs_pvs_full" has no tests wa...

...as no tests warning: "guestfs_inspect_get_package_format" has no tests warning: "guestfs_inspect_get_package_management" has no tests warning: "guestfs_inspect_list_applications" has no tests warning: "guestfs_inspect_get_hostname" has no tests warning: "guestfs_inspect_get_format" has no tests warning: "guestfs_inspect_is_live" has no tests warning: "guestfs_inspect_is_netinst" has no tests warning: "guestfs_inspect_is_multipart" has no tests warning: "guestfs_ll" has no tests warning: "guestfs_pvs_full" has no tests wa...

...as no tests warning: "guestfs_inspect_get_package_format" has no tests warning: "guestfs_inspect_get_package_management" has no tests warning: "guestfs_inspect_list_applications" has no tests warning: "guestfs_inspect_get_hostname" has no tests warning: "guestfs_inspect_get_format" has no tests warning: "guestfs_inspect_is_live" has no tests warning: "guestfs_inspect_is_netinst" has no tests warning: "guestfs_inspect_is_multipart" has no tests warning: "guestfs_ll" has no tests warning: "guestfs_pvs_full" has no tests wa...