Displaying 4 results from an estimated 4 matches for "guestfs_have_add_drive_opts".
2018 Apr 06
2
Re: [nbdkit PATCH] tests: Skip guestfs tests on CentOS 6
...sts that fail to
>> compile so that 'make check' can at least complete.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>
>
>> +#ifndef GUESTFS_ADD_DRIVE_OPTS_PROTOCOL
>
> There's a symbol defined for this kind of test:
>
> #ifndef GUESTFS_HAVE_ADD_DRIVE_OPTS
> ...
>
> (from <guestfs.h>).
The libguestfs on CentOS 6 does define GUESTFS_HAVE_ADD_DRIVE_OPTS (and
the function family guestfs_add_drive_opts*), however, it only supports
up through option 5 GUESTFS_ADD_DRIVE_OPTS_CACHEMODE. The compile
failure was that GUESTFS_ADD_DRIVE_OPTS...
2018 Apr 06
0
Re: [nbdkit PATCH] tests: Skip guestfs tests on CentOS 6
...9;make check' can at least complete.
> >>
> >> Signed-off-by: Eric Blake <eblake@redhat.com>
> >
> >
> >> +#ifndef GUESTFS_ADD_DRIVE_OPTS_PROTOCOL
> >
> > There's a symbol defined for this kind of test:
> >
> > #ifndef GUESTFS_HAVE_ADD_DRIVE_OPTS
> > ...
> >
> > (from <guestfs.h>).
>
> The libguestfs on CentOS 6 does define GUESTFS_HAVE_ADD_DRIVE_OPTS (and
> the function family guestfs_add_drive_opts*), however, it only supports
> up through option 5 GUESTFS_ADD_DRIVE_OPTS_CACHEMODE. The compile
>...
2018 Apr 05
2
[nbdkit PATCH] tests: Skip guestfs tests on CentOS 6
CentOS 6 has libguestfs-devel 1.20.11, which predates the support
in guestfs_add_drive_opts() for requesting an nbd drive instead
of a local file. The guestfs plugin can still be built, so no
configure changes are needed; but skip the tests that fail to
compile so that 'make check' can at least complete.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
Even with this patch,
2018 Apr 06
0
Re: [nbdkit PATCH] tests: Skip guestfs tests on CentOS 6
...configure changes are needed; but skip the tests that fail to
> compile so that 'make check' can at least complete.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> +#ifndef GUESTFS_ADD_DRIVE_OPTS_PROTOCOL
There's a symbol defined for this kind of test:
#ifndef GUESTFS_HAVE_ADD_DRIVE_OPTS
...
(from <guestfs.h>).
However in this case I wonder if it would be better to test for this
in the ./configure script and disable the HAVE_LIBGUESTFS automake
conditional (but probably not error out -- we want to still compile on
RHEL 6). What do you think?
Rich.
--
Richard Jones, Vi...