search for: guestfs_find0

The current guestfs_find API call contains an undocumented limit: It needs to marshall the whole list of filenames into a single protocol message. Unfortunately just about any Linux guest breaks this limit if you try 'guestfs_find ("/")' so this isn't much use. These patches add a new API call (find0) which breaks this limit by using a FileOut parameter. It's slightly

Cosmetic change as suggested in this previous patch: https://www.redhat.com/archives/libguestfs/2016-November/msg00111.html Matteo Cafasso (2): lib: generic function for temporary path generation lib: use guestfs_int_make_temp_path to generate temporary files src/drives.c | 5 ++--- src/file.c | 22 +++++++++------------- src/guestfs-internal.h | 1 + src/journal.c

https://bugzilla.redhat.com/show_bug.cgi?id=755729 This bug reports that the error message printed by the resize2fs API calls (which comes directly from the resize2fs command) says: Please run 'e2fsck -f /dev/vda1' first. That command is not possible from guestfish (where it would be 'e2fsck-f' or 'e2fsck ... forceall:true'). Fixing that bug caused this bug:

...ctory) char **ret = NULL; size_t i, count, size; - if (guestfs_int_lazy_make_tmpdir (g) == -1) + tmpfile = guestfs_int_make_temp_path (g, "find"); + if (tmpfile == NULL) goto err; - tmpfile = safe_asprintf (g, "%s/find%d", g->tmpdir, ++g->unique); - if (guestfs_find0 (g, directory, tmpfile) == -1) goto err; @@ -317,11 +315,10 @@ write_or_append (guestfs_h *g, const char *path, (!append ? guestfs_internal_write : guestfs_internal_write_append) (g, path, content, size); - if (guestfs_int_lazy_make_tmpdir (g) == -1) - goto err; - /* Wri...

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.

Tested with 'make check-release'. tests/parallel (in check-slow) failed, although it does regularly and that seems to be because of libvirt. Rich.

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

In the kernel and qemu communities it is routine for patches that will be backported to stable branches to be posted for review. I'm proposing we do the same for libguestfs stable branches. All of the attached have been tested with 'make check-release'. Rich.

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...

...s(3)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 13. /usr/bin/pod2html: -: cannot resolve L<ls(1)> in paragraph 15. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 21. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)/guestfs_find0> in paragraph 54. /usr/bin/pod2html: -: cannot resolve L<sh(1)> in paragraph 73. /usr/bin/pod2html: -: cannot resolve L<guestfs(3)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<guestfish(1)> in paragraph 75. /usr/bin/pod2html: -: cannot resolve L<virt-cat(1)> i...