Displaying 20 results from an estimated 22 matches for "guestfs_disk_create_argv".
2018 Aug 17
2
buffer overflow detected error
...so.6(__fortify_fail+0x37)[ox7f7932b4ed87]
/lib64/libc.so.6(+0x10df40)[0x7f7932b4cf40]
/lib64/libc.so.6(+0x10df40)[0x7f7932b4ecf7]
/lib64/libguestfs.so.0(+0xa6508)[0x7f78755bd508]
/lib64/libguestfs.so.0(+0xa6e3c)[0x7f78755bde3c]
/lib64/libguestfs.so.0(+0xa8e12)[0x7f78755bfe12]
/lib64/libguestfs.so.0(guestfs_disk_create_argv+0xbf)[0x7f7875567c6f]
/lib64/libguestfs.so.0(+0xc48f2)[0x7f78755db8f2]
/lib64/libguestfs.so.0(+0xc54b1[0x7f78755dc4b1]
/lib64/libguestfs.so.0(+0xbfc75)[0x7f78755d6c75]
/usr/lib64/libguestfs_jni.so.1.36.3(Java_com_redhat_et_libguestfs_Gues
tFs__1launch+0x14[0x7f7875875de4]
[0x7f791ee77570]
Any idea...
2020 Feb 06
3
[PATCH] lib: Autodetect backing format and specify it explicitly.
...b/create.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/lib/create.c b/lib/create.c
index e2a59b88d..e30286c39 100644
--- a/lib/create.c
+++ b/lib/create.c
@@ -255,6 +255,7 @@ disk_create_qcow2 (guestfs_h *g, const char *filename, int64_t size,
const struct guestfs_disk_create_argv *optargs)
{
const char *backingformat = NULL;
+ CLEANUP_FREE char *backingformat_free = NULL;
const char *preallocation = NULL;
const char *compat = NULL;
int clustersize = -1;
@@ -302,6 +303,18 @@ disk_create_qcow2 (guestfs_h *g, const char *filename, int64_t size,
}
}
+ /...
2018 Aug 22
1
[PATCH] lib: create: avoid one extra string allocation
...VALID_FLAG_ALPHA|VALID_FLAG_DIGIT, "")
static int
-disk_create_qcow2 (guestfs_h *g, const char *orig_filename, int64_t size,
+disk_create_qcow2 (guestfs_h *g, const char *filename, int64_t size,
const char *backingfile,
const struct guestfs_disk_create_argv *optargs)
{
- CLEANUP_FREE char *filename = NULL;
const char *backingformat = NULL;
const char *preallocation = NULL;
const char *compat = NULL;
@@ -263,16 +262,6 @@ disk_create_qcow2 (guestfs_h *g, const char *orig_filename, int64_t size,
CLEANUP_CMD_CLOSE struct command *cmd = guest...
2016 Aug 02
0
[PATCH] launch: libvirt: Autodetect backing format for drive overlays (RHBZ#1354335).
...rmat' argument to 'add-drive'."));
+ return NULL;
+}
+
static char *
make_qcow2_overlay (guestfs_h *g, const char *backing_drive,
const char *format)
@@ -169,6 +213,8 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive,
char *overlay;
struct guestfs_disk_create_argv optargs;
+ assert (format != NULL);
+
if (guestfs_int_lazy_make_tmpdir (g) == -1)
return NULL;
@@ -176,10 +222,8 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive,
optargs.bitmask = GUESTFS_DISK_CREATE_BACKINGFILE_BITMASK;
optargs.backingfile = backing_drive;
- if...
2020 Mar 09
3
Re: [PATCH] lib: Autodetect backing format and specify it explicitly.
...gt;
> > diff --git a/lib/create.c b/lib/create.c
> > index e2a59b88d..e30286c39 100644
> > --- a/lib/create.c
> > +++ b/lib/create.c
> > @@ -255,6 +255,7 @@ disk_create_qcow2 (guestfs_h *g, const char *filename, int64_t size,
> > const struct guestfs_disk_create_argv *optargs)
> > {
> > const char *backingformat = NULL;
> > + CLEANUP_FREE char *backingformat_free = NULL;
> > const char *preallocation = NULL;
> > const char *compat = NULL;
> > int clustersize = -1;
> > @@ -302,6 +303,18 @@ disk_create_qcow2...
2020 Feb 06
1
Re: [PATCH v2] launch: add support for autodetection of appliance image format
...used to create
> + * the appliance overlay, and also for read-only drives.
> */
> static char *
> make_qcow2_overlay (guestfs_h *g, const char *backing_drive,
> @@ -223,8 +224,6 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive,
> char *overlay;
> struct guestfs_disk_create_argv optargs;
>
> - assert (format != NULL);
> -
> if (guestfs_int_lazy_make_tmpdir (g) == -1)
> return NULL;
>
> @@ -232,8 +231,10 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive,
>
> optargs.bitmask = GUESTFS_DISK_CREATE_BACKINGFILE_BITMASK;...
2014 Jan 28
11
[PATCH 00/10] New API: disk-create for creating blank disks.
A lot of code runs 'qemu-img create' or 'truncate' to create blank
disk images.
In the past I resisted adding an API to do this, since it essentially
duplicates what you can already do using other tools (ie. qemu-img).
However this does simplify calling code quite a lot since qemu-img is
somewhat error-prone to use (eg: don't try to create a disk called
"foo:bar")
2020 Mar 09
2
Re: [PATCH] lib: Autodetect backing format and specify it explicitly.
...ate.c
> > > > index e2a59b88d..e30286c39 100644
> > > > --- a/lib/create.c
> > > > +++ b/lib/create.c
> > > > @@ -255,6 +255,7 @@ disk_create_qcow2 (guestfs_h *g, const char *filename, int64_t size,
> > > > const struct guestfs_disk_create_argv *optargs)
> > > > {
> > > > const char *backingformat = NULL;
> > > > + CLEANUP_FREE char *backingformat_free = NULL;
> > > > const char *preallocation = NULL;
> > > > const char *compat = NULL;
> > > > int cluste...
2020 Mar 09
0
Re: [PATCH] lib: Autodetect backing format and specify it explicitly.
...le changed, 13 insertions(+)
>
> diff --git a/lib/create.c b/lib/create.c
> index e2a59b88d..e30286c39 100644
> --- a/lib/create.c
> +++ b/lib/create.c
> @@ -255,6 +255,7 @@ disk_create_qcow2 (guestfs_h *g, const char *filename, int64_t size,
> const struct guestfs_disk_create_argv *optargs)
> {
> const char *backingformat = NULL;
> + CLEANUP_FREE char *backingformat_free = NULL;
> const char *preallocation = NULL;
> const char *compat = NULL;
> int clustersize = -1;
> @@ -302,6 +303,18 @@ disk_create_qcow2 (guestfs_h *g, const char *filenam...
2020 Mar 09
0
Re: [PATCH] lib: Autodetect backing format and specify it explicitly.
...a/lib/create.c b/lib/create.c
> > > index e2a59b88d..e30286c39 100644
> > > --- a/lib/create.c
> > > +++ b/lib/create.c
> > > @@ -255,6 +255,7 @@ disk_create_qcow2 (guestfs_h *g, const char *filename, int64_t size,
> > > const struct guestfs_disk_create_argv *optargs)
> > > {
> > > const char *backingformat = NULL;
> > > + CLEANUP_FREE char *backingformat_free = NULL;
> > > const char *preallocation = NULL;
> > > const char *compat = NULL;
> > > int clustersize = -1;
> > > @@...
2020 Mar 09
0
Re: [PATCH] lib: Autodetect backing format and specify it explicitly.
...> index e2a59b88d..e30286c39 100644
> > > > > --- a/lib/create.c
> > > > > +++ b/lib/create.c
> > > > > @@ -255,6 +255,7 @@ disk_create_qcow2 (guestfs_h *g, const char *filename, int64_t size,
> > > > > const struct guestfs_disk_create_argv *optargs)
> > > > > {
> > > > > const char *backingformat = NULL;
> > > > > + CLEANUP_FREE char *backingformat_free = NULL;
> > > > > const char *preallocation = NULL;
> > > > > const char *compat = NULL;
> >...
2017 Sep 19
0
[PATCH 6/6] lib: Use guestfs_int_make_temp_path in a few more places.
...backing_drive;
if (drv->src.format) {
diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c
index 98c947288..e5121799e 100644
--- a/lib/launch-libvirt.c
+++ b/lib/launch-libvirt.c
@@ -224,11 +224,10 @@ make_qcow2_overlay (guestfs_h *g, const char *backing_drive,
char *overlay;
struct guestfs_disk_create_argv optargs;
- if (guestfs_int_lazy_make_tmpdir (g) == -1)
+ overlay = guestfs_int_make_temp_path (g, "overlay", "qcow2");
+ if (!overlay)
return NULL;
- overlay = safe_asprintf (g, "%s/overlay%d", g->tmpdir, ++g->unique);
-
optargs.bitmask = GUESTFS_...
2015 May 26
6
[PATCH 0/6] Update the way that API versions are generated for the man page.
The existing mechanism was clunky, slow and used ~ 10 MB of
local disk.
Rich.
2015 Sep 29
0
[PATCH 4/4] lib: Remove unused header files.
...ate.c
+++ b/src/create.c
@@ -39,7 +39,6 @@
#include "guestfs.h"
#include "guestfs-internal.h"
#include "guestfs-internal-actions.h"
-#include "guestfs_protocol.h"
static int disk_create_raw (guestfs_h *g, const char *filename, int64_t size, const struct guestfs_disk_create_argv *optargs);
static int disk_create_qcow2 (guestfs_h *g, const char *filename, int64_t size, const char *backingfile, const struct guestfs_disk_create_argv *optargs);
diff --git a/src/dbdump.c b/src/dbdump.c
index db0f433..95a8dfb 100644
--- a/src/dbdump.c
+++ b/src/dbdump.c
@@ -20,13 +20,7 @@
#i...
2020 Feb 24
3
*** buffer overflow detected *** accessing invalid FD in libguestfs
...y=0x7fffbc008d60,
filename=filename@entry=0x7fffbc0301f0
"/tmp/libguestfszZtmRI/overlay1.qcow2", format=<optimized out>,
format@entry=0x7ffff4843998 "qcow2", size=size@entry=-1,
optargs=optargs@entry=0x7fffca7fb1a0) at ../../../lib/create.c:88
#11 0x00007ffff4794ca5 in guestfs_disk_create_argv (g=g@entry=0x7fffbc008d60,
filename=filename@entry=0x7fffbc0301f0
"/tmp/libguestfszZtmRI/overlay1.qcow2",
format=format@entry=0x7ffff4843998 "qcow2", size=size@entry=-1,
optargs=optargs@entry=0x7fffca7fb1a0) at ../../../lib/actions-3.c:224
#12 0x00007ffff4807b18 in create_co...
2020 Feb 20
0
buffer overflow detected in collectd using libguestfs
...from
/lib/x86_64-linux-gnu/libc.so.6
#7 0x00007ffff47ed8ba in ?? () from
/usr/lib/x86_64-linux-gnu/libguestfs.so.0
#8 0x00007ffff47ee2f5 in ?? () from
/usr/lib/x86_64-linux-gnu/libguestfs.so.0
#9 0x00007ffff47efefc in ?? () from
/usr/lib/x86_64-linux-gnu/libguestfs.so.0
#10 0x00007ffff4794ca5 in guestfs_disk_create_argv () from
/usr/lib/x86_64-linux-gnu/libguestfs.so.0
#11 0x00007ffff4807b18 in ?? () from
/usr/lib/x86_64-linux-gnu/libguestfs.so.0
#12 0x00007ffff47f0b44 in ?? () from
/usr/lib/x86_64-linux-gnu/libguestfs.so.0
#13 0x00007ffff47f0d7b in ?? () from
/usr/lib/x86_64-linux-gnu/libguestfs.so.0
#14 0x00007f...
2015 Sep 29
8
[PATCH 1/4] lib: actions: Remove some unused header files.
---
generator/c.ml | 2 --
1 file changed, 2 deletions(-)
diff --git a/generator/c.ml b/generator/c.ml
index 055b683..963cf21 100644
--- a/generator/c.ml
+++ b/generator/c.ml
@@ -1213,9 +1213,7 @@ and generate_client_actions hash () =
#include <stdlib.h>
#include <stdint.h>
#include <inttypes.h>
-#include <sys/types.h>
#include <sys/stat.h>
-#include
2017 Sep 20
7
[PATCH v2] 0/6] Various clean ups in lib/
v1 -> v2:
- Remove the unnecessary calls to guestfs_int_lazy_make_tmpdir
in the final patch.
Rich.
2017 Sep 19
7
[PATCH 0/6] Various clean ups in lib/
Miscellaneous small cleanups in lib/ directory.
Rich.
2015 Oct 05
0
[PATCH 2/2] Fix whitespace.
...cbcdbc5 100644
--- a/src/create.c
+++ b/src/create.c
@@ -46,8 +46,8 @@ static char *qemu_escape_param (guestfs_h *g, const char *param);
int
guestfs_impl_disk_create (guestfs_h *g, const char *filename,
- const char *format, int64_t size,
- const struct guestfs_disk_create_argv *optargs)
+ const char *format, int64_t size,
+ const struct guestfs_disk_create_argv *optargs)
{
const char *backingfile;
diff --git a/src/dbdump.c b/src/dbdump.c
index 95a8dfb..7c17ce6 100644
--- a/src/dbdump.c
+++ b/src/dbdump.c
@@ -53,8 +53,8 @@ struct cb_data {
*/
int
guestfs...